New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Use Step Down rounding while collecting deposits with too many decimals #2648

Open

martianatwork opened this issue Aug 3, 2020 · 1 comment

martianatwork commented Aug 3, 2020

Version:
2.4-stable

Additional Info:
No changes in deposit & withdrawal process

Steps to reproduce:

send a transaction with exactly "0.055796386110991888"
System will show the deposit as "0.0557963861109919"
When collecting system will try to collect "0.0557963861109919" because we have less funds on blockchain this transaction will not be accepted.

Solution:
Instead of using"0.0557963861109919" system should use "0.0557963861109918" or "0.05579638611099187"

antonDigitalMagic commented Mar 6, 2021

Rounding on monetary amounts is a bad practice.
Fix proposed in #2851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment