Deposits less then min_collect amount never go to system wallets, even multiple when balance on deposit address is higher then minimal collection amount

[foraone]

Problem 1. Lets assume we have minimal collection amount is 0.1 ETH and there are 2 deposit transactions for 0.055 ETH total amount on the deposit address will be 0.11 ETH which is more then limit, but that balance is not collected.

Problem 2. When I later transfer 0.2 ETH to the same deposit address, only 0.2 ETH is collected, but not 0.31 ETH (actual balance of the wallet)

Problem 3. In Peatio sates of first 2 transactions are "collected", so neither Peatio, nor Admin user can't see that those coins/tokens never landed to hot wallet. There is no way to collect remaining balance (even with PR for 2.5 with collection in API) of deposit address to Hot/Warm/Cold wallet because in system it is marked as collected.

Tested on Peatio 2.5

[mnaichuk]

hello @foraone all logic related to spreading between wallets you can find here

peatio/app/services/wallet_service.rb

Line 131 in e1617e9

def spread_between_wallets(deposit, destination_wallets)

as you can see here:

      # So we collect everything to current wallet.
      if left_amount < dw[:min_collection_amount]
        amount_for_wallet += left_amount
        left_amount = 0
      end

so it should go to the latest wallet

[zozi91]

Hello @mnaichuk

if 'deposit amount' < 'min collect amount'. what happen with this deposit state?

it will return collected or skipped ? I have tested in peatio 2.5. it return to 'collected'

If it return to 'collected'. How can admin re-collect it