Skip to content

Commit 551dfad

Browse files
committed
Improvements part of the pgcritic report now shows up
if the only problem is that solutions are not shown.
1 parent e50b77a commit 551dfad

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

templates/ContentGenerator/Instructor/PGProblemEditor/pg_critic.html.ep

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,10 @@
5454
these macros. </p>
5555
% }
5656

57-
5857
% my $has_bad_features = 0;
5958
% $has_bad_features += $results->{bad}{$_} for (keys %{$results->{bad}});
6059

61-
% # <%== dumper $results->{bad} %>
62-
63-
% if ($has_bad_features) {
60+
% if ($has_bad_features || !$results->{good}{solution}) {
6461
<h3>You can improve on the following:</h3>
6562
<p> There are features in this problem that contain old or deprecated features. The following
6663
list gives feedback of how the problem can be improved. </p>

0 commit comments

Comments
 (0)