-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Hold back incompatible kernel packages on Fedora #17265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for creating this issue @tonyhutter . I think the following change (adding explicit "Requires" dependencies for kernel and kernel-core in zfs-dkms.spec) would probably be sufficient to fix this: That said I havent tested it at all, nor have I deeply examined the RPM dependencies between the various kernel packages (which is why I didnt open a PR for it). But, it seems like holding back kernel, kernel-core and kernel-devel would have to result in basically all the core kernel packages being held back from DNF updates until zfs updates to a new version (perhaps some of the extra optional kernel packages like kernel-headers or kernel-tools might not be blocked?) Just having "Requires" dependencies on the kernel package (which is a metapackage to pull in all the various required kernel packages) and on kernel-devel might be enough even, but Im not sure how exactly dependencies get propagated through the main kernel metapackage. |
@tonyhutter - Im not sure what openzfs's policy on backporting fixes to already released zfs versions is, but...assuming 2.3.2 isnt getting released in the next day or two...maybe it is worth doing the following:
??? I mean, I completely understand not wanting to modify already released versions for the sake of stability, but...maybe this one is an exception? That commit cant really change anything about how zfs does zfs things, and it immediately solves a widespread and fairly major pain in the ass for people using zfs 2.3.x on Fedora. |
@jkool702 I would expect 99.9% of our Fedora users are going to be running zfs-2.3.1. It has usually taken about a week for everyone to auto-update to the new ZFS release RPMs due to |
@tonyhutter - thats fair. I can confirm that Fedora 41's current kernel is 6.13.12. Regarding that patch - you may actually want to explicitly set up a few more Requires/Conflicts dependencies. After some trial and error I manajed to generate a list of how all the kernel sub-packages depend on each other.
Ignoring the debug kernel packages, I think the following list is the smallest set of kernel packages that (through their chained dependencies) will ensure all the possible kernel subpackages are blocked from being installed until zfs updates
ALSO, I think that having
If, for reasons Im not currently seeing, the "Requires" part has to be there to make this all work then...i guess figure out which ones are not going to cause problems if a version for a newer kernel installed and then all the rest become explicit dependencies of zfs-dkms??? |
@tonyhutter - I tested it and turns out just using "Requires" for kernel-devel-matched didnt work. However, expanding it to the following seems to work
To test, i recompiled the zfs-2.3-release branch with the above code substituted in rpm/generic/zfs-dkms.spec.in, built the zfs-dkms.rpm package, then reinstalled zfs-dkms using the new modified one. I then took the fedora 42 kernel (6.14.x) and re-compiled it into tthe various fedora 41 kernel rpms. I added these to a local DNF repository. running
which seems to be the correct behavior - dnf doesnt install any of the kernel packages for 6.14.3 but otherwise works normally. Its worth noting that the 6.14.3 |
I just ran into this issue on a F41 machine too that was last update about 4 weeks ago, i did a
and then at the end of the update run:
After this i tried to run another update to see what the issue for the previous run was.
That made me find this report, given that it was mentioned it F41 would not be affected due to it's current kernel version, i made this post as it seems F41 now upgrades beyond the supported zfs packages. I am not sure if the information is helpful, though as a mere mortal Linux user it caused me some trouble. I am sure I'll be able to get back to the previous state one way or another until the the 2.3.2 release from #17214 seeps through and likely fixes the problems "auto-magically" Thanks for all the work all of you do! |
I also ran into this issue today. I blindly updated my Fedora Server 41 in Cockpit, which installed 6.14 and resulted in a kernel panic, preventing me from booting. I am now booting into 6.13 and manually blocking kernel updates.
|
No, since this weekend Fedora-40 and newer will use 6.14. |
A user reported that when your upgrade your kernel packages on Fedora with ZFS installed, only the kernel-devel package gets held back to the ZFS-supported version, but not the other kernel packages. So if ZFS only supports the 6.13 kernel, Fedora will still happily upgrade the kernel RPM to 6.14, but hold back kernel-devel at 6.13, for example. This commit includes version checks for the 'kernel' dependency, typically provided by the 'kernel-core' package. Closes: openzfs#17265 Original-patch-by: @jkool702 Signed-off-by: Tony Hutter <[email protected]>
System information
Describe the problem you're observing
A user reported that when your upgrade your kernel packages on Fedora with ZFS installed, only the
kernel-devel
package gets held back to the ZFS-supported version, but not the otherkernel
packages. So if ZFS only supports the 6.13 kernel, Fedora will still happily upgrade thekernel
RPMs to 6.14, but hold backkernel-devel
at 6.13, for example.I see d02257c makes mention of holding back the kernel version, but it only holds back kernel-devel. It seems we should be holding back the kernel packages as well.
Describe how to reproduce the problem
User reported upgrading kernel packages on Fedora causes the issue.
Include any warning/errors/backtraces from the system logs
The text was updated successfully, but these errors were encountered: