Skip to content

Unable to download zim #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mou7665 opened this issue Mar 26, 2025 · 8 comments
Open

Unable to download zim #819

mou7665 opened this issue Mar 26, 2025 · 8 comments
Labels

Comments

@mou7665
Copy link

mou7665 commented Mar 26, 2025

Image
Clicking on any download link

@audiodude
Copy link
Member

This is because the ZIM has expired. There should be a little red (i) next to "download ZIM" that tells you "This ZIM file has expired (2 weeks)". As the message says, the ZIM expires after 2 weeks.

@mou7665
Copy link
Author

mou7665 commented Mar 29, 2025

Unfortunately, there was not any option to recreate the zim or a red (i) until 2 days later

@kelson42 kelson42 reopened this Mar 30, 2025
@kelson42
Copy link
Collaborator

From my point of view we should have a proper error. Considering we use a redirect to Wasabi, this hould be easily doable.

In addition, the file should be easy to recreate, I wonder why it's not.

@audiodude
Copy link
Member

From my point of view we should have a proper error. Considering we use a redirect to Wasabi, this hould be easily doable.

We just respond with a 302 to the wasabi URL. If we'd like to detect this situation and show a more helpful error message, we would have to do a fetch with the requests library first and check for a 404.

In addition, the file should be easy to recreate, I wonder why it's not.

We don't automatically re-create ZIMs. This was a decision made long ago. When a ZIM expires, we let the user know and require them to recreate the ZIM themselves.

@kelson42
Copy link
Collaborator

kelson42 commented Apr 4, 2025

From my point of view we should have a proper error. Considering we use a redirect to Wasabi, this hould be easily doable.

We just respond with a 302 to the wasabi URL. If we'd like to detect this situation and show a more helpful error message, we would have to do a fetch with the requests library first and check for a 404.

Yes, displaying a proper message about expiration and a simple invitation - with a button - to recreate straight the ZIM file.

In addition, the file should be easy to recreate, I wonder why it's not.

We don't automatically re-create ZIMs. This was a decision made long ago. When a ZIM expires, we let the user know and require them to recreate the ZIM themselves.

I think this is still correct.

@mou7665
Copy link
Author

mou7665 commented Apr 5, 2025

The zim was recreated, but the download button was still there ever after expiry.

@audiodude
Copy link
Member

@mou7665 That's a good point, we shouldn't display the download link if we suspect the ZIM is expired.

@kelson42 kelson42 added the bug label Apr 5, 2025
@mou7665
Copy link
Author

mou7665 commented Apr 12, 2025

I had this same issue 3 days ago, where the selection still had the download link even after expiry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants