Merge pull request #652 from opsmill/pog-ruff-S108

Linting: Probable insecure usage of temporary file or directory

Author: ogenstad

pyproject.toml

@@ -201,7 +201,6 @@ ignore = [
     "PTH109",  # `os.getcwd()` should be replaced by `Path.cwd()`
     "RUF005",  # Consider `[*path, str(key)]` instead of concatenation
     "RUF029",  # Function is declared `async`, but doesn't `await` or use `async` features.
-    "S108",    # Probable insecure usage of temporary file or directory
     "S311",    # Standard pseudo-random generators are not suitable for cryptographic purposes
     "S701",    # By default, jinja2 sets `autoescape` to `False`. Consider using `autoescape=True`
     "SIM102",  # Use a single `if` statement instead of nested `if` statements

tests/unit/sdk/checks/test_checks.py

@@ -1,3 +1,5 @@
+from pathlib import Path
+
 import pytest
 
 from infrahub_sdk import InfrahubClient
@@ -6,7 +8,7 @@
 pytestmark = pytest.mark.httpx_mock(can_send_already_matched_responses=True)
 
 
-async def test_class_init() -> None:
+async def test_class_init(tmp_path: Path) -> None:
     class IFCheckNoQuery(InfrahubCheck):
         pass
 
@@ -29,9 +31,9 @@ class IFCheckNoName(InfrahubCheck):
     check = IFCheckNoName()
     assert check.name == "IFCheckNoName"
 
-    check = IFCheckWithName(root_directory="/tmp")
+    check = IFCheckWithName(root_directory=str(tmp_path))
     assert check.name == "my_check"
-    assert check.root_directory == "/tmp"
+    assert check.root_directory == str(tmp_path)
 
 
 async def test_async_init(client) -> None: