-
Notifications
You must be signed in to change notification settings - Fork 7
Add flake #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flake #676
Conversation
WalkthroughThis pull request adds a flake.nix file that defines a Nix flake for the Infrahub development environment. The flake declares dependencies on nixpkgs and flake-utils, and configures per-system outputs using flake-utils. It establishes a default development shell via devShells.default that includes git, gh, and vale as build inputs. The shell environment includes a hook that prints the environment name and the versions of the included tools upon activation. Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying infrahub-sdk-python with
|
| Latest commit: |
08ff111
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7ed6b3e6.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pog-use-nix-flake.infrahub-sdk-python.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
flake.nix (1)
1-32: Flake structure looks good; only small optional polish around mkShell & pinningThe flake wiring and
devShells.defaultdefinition are correct and will yield a usable dev shell on all default systems (eachDefaultSystem). The shellHook is straightforward and helpful.Two small, optional tweaks you may want to consider:
- Use
packagesinstead ofbuildInputswithpkgs.mkShellto align with current Nix conventions for dev shells:- devShells.default = pkgs.mkShell { - buildInputs = [ - pkgs.git - pkgs.gh - pkgs.vale - ]; + devShells.default = pkgs.mkShell { + packages = [ + pkgs.git + pkgs.gh + pkgs.vale + ];
- If you care about long‑term reproducibility of the dev environment, consider pinning
nixpkgsto a release branch or specific revision instead ofnixos-unstable, or documenting that the flake intentionally tracks unstable.These are purely optional; as written, the flake is valid and usable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
flake.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
flake.nix(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Cloudflare Pages
Add files for Nix flake.
Summary by CodeRabbit
Chores
✏️ Tip: You can customize this high-level summary in your review settings.