update linter version

Author: Mat001

.golangci.yml

@@ -1,68 +1,63 @@
 linters-settings:
- govet:
-   check-shadowing: true
- golint:
-   min-confidence: 0
- gocyclo:
-   min-complexity: 16
- maligned:
-   suggest-new: true
- dupl:
-   threshold: 200
- goconst:
-   min-len: 2
-   min-occurrences: 2
- misspell:
-   locale: US
- lll:
-   line-length: 140
- gocritic:
-   enabled-tags:
-     - performance
-     - style
-     - experimental
-   disabled-checks:
-     - wrapperFunc
-     - hugeParam
-     - rangeValCopy
+  govet:
+    check-shadowing: true
+  gocyclo:
+    min-complexity: 16
+  dupl:
+    threshold: 200
+  goconst:
+    min-len: 2
+    min-occurrences: 2
+  misspell:
+    locale: US
+  lll:
+    line-length: 140
+  gocritic:
+    enabled-tags:
+      - performance
+      - style
+      - experimental
+    disabled-checks:
+      - wrapperFunc
+      - hugeParam
+      - rangeValCopy
+  revive:
+    min-confidence: 0
 
 linters:
- disable-all: true
- enable:
-   - deadcode
-   - dupl
-   - gas
-   - gocritic
-   - gocyclo
-   - golint
-   - gosimple
-   - govet
-   - ineffassign
-   - maligned
-   - megacheck
-   - misspell
-   - nakedret
-   - prealloc
-   - scopelint
-   - structcheck
-   - stylecheck
-   - typecheck
-   - unconvert
-   - unparam
-   - varcheck
- fast: false
+  disable-all: true
+  enable:
+    - unused
+    - dupl
+    - gosec
+    # - gocritic  # Temporarily disabled due to compatibility issues with Go 1.24
+    - gocyclo
+    - revive
+    - gosimple
+    - govet
+    - ineffassign
+    - staticcheck
+    - misspell
+    - nakedret
+    - prealloc
+    - exportloopref
+    - stylecheck
+    - typecheck
+    - unconvert
+    - unparam
+  fast: false
 
 run:
- skip-dirs:
-   - vendor
- concurrency: 4
+  skip-dirs:
+    - vendor
+  concurrency: 4
 
 issues:
- exclude-rules:
-   - text: "weak cryptographic primitive"
-     linters:
-       - gosec
- exclude-use-default: false
+  exclude-rules:
+    - text: "weak cryptographic primitive"
+      linters:
+        - gosec
+  exclude-use-default: false
 
 service:
- golangci-lint-version: 1.54.2
+  golangci-lint-version: 1.64.2

Makefile

@@ -36,7 +36,7 @@ build: $(TARGET) check-go ## builds and installs binary in bin/
 
 check-go:
 ifndef GOPATH
-	$(error "go is not available please install golang version 1.21.0+, https://golang.org/dl/")
+	$(error "go is not available please install golang version 1.24.0+, https://golang.org/dl/")
 endif
 
 clean: check-go ## runs `go clean` and removes the bin/ dir
@@ -50,9 +50,11 @@ cover-html: cover ## generates test coverage html report
 	$(GOCMD) tool cover -html=$(COVER_FILE)
 
 setup: check-go ## installs all dev and ci dependencies, but does not install golang 
-## "go get" won't work for newer go versions, need to use "go install github.com/rakyll/statik"
+## Install golangci-lint
+## golangci-lint is not yet fully supporting gl v1.24, need to wait a bit. Should work after some time
+## skip linting until then
 ifeq (,$(wildcard $(GOLINT)))
-	curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $(GOPATH)/bin v1.54.2
+    curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GOPATH)/bin v1.64.2
 endif
 ## "go get" won't work for newer go versions, need to use "go install github.com/rakyll/statik"
 ifeq (,$(wildcard $(GOPATH)/bin/statik))

README.md

@@ -15,7 +15,7 @@ Refer to the [Agent's developer documentation](https://docs.developers.optimizel
 
 ### Requirements
 
-Optimizely Agent is implemented in [Golang](https://golang.org/). Golang version 1.21.0+ is required for developing and compiling from source.
+Optimizely Agent is implemented in [Golang](https://golang.org/). Golang version 1.24.0+ is required for developing and compiling from source.
 Installers and binary archives for most platforms can be downloaded directly from the Go [downloads](https://go.dev/dl/) page.
 
 ### Run from source (Linux / OSX)

scripts/build.ps1

@@ -102,7 +102,7 @@ function main($mode) {
     # noninteractive mode: ./build.ps1 noninteractive (default: interactive)
 
     # check if go is installed, if not, install it.
-    checkPrereq 'Go Programming Language amd64 go1.20.1' https://dl.google.com/go/go1.20.1.windows-amd64.msi f06fdfa56f3aba62cbf80dacddbcc1150f4990cc117a9477047d3a3529ee3e80 $mode
+    checkPrereq 'Go Programming Language amd64 go1.20.1' https://dl.google.com/go/go1.24.0.windows-amd64.msi f06fdfa56f3aba62cbf80dacddbcc1150f4990cc117a9477047d3a3529ee3e80 $mode
     # same but with git
     checkPrereq 'Git version 2.39.2' https://github.com/git-for-windows/git/releases/download/v2.39.2.windows.1/Git-2.39.2-64-bit.exe d7608fbd854b3689102ff48b03c8cc77b35138f9f7350d134306da0ba5751464 $mode
 

scripts/dockerfiles/Dockerfile.alpine

@@ -1,6 +1,6 @@
 ARG GO_VERSION
 FROM golang:$GO_VERSION-alpine3.21 as builder
-# hadolint ignore=DL3018 - test comment
+# hadolint ignore=DL3018
 RUN addgroup -S agentgroup && adduser -S agentuser -G agentgroup
 RUN apk add --no-cache make gcc libc-dev git curl
 WORKDIR /go/src/github.com/optimizely/agent