Skip to content

Commit 4020086

Browse files
wip: evenhandler build successfull
1 parent 5c75d58 commit 4020086

File tree

6 files changed

+60
-44
lines changed

6 files changed

+60
-44
lines changed

event-handler/build.gradle

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,9 @@ dependencies {
5959

6060
testImplementation "junit:junit:$junit_ver"
6161
testImplementation "org.mockito:mockito-core:$mockito_ver"
62-
testImplementation "org.powermock:powermock-module-junit4:$powermock_ver"
63-
testImplementation "org.powermock:powermock-api-mockito2:$powermock_ver"
62+
testImplementation "org.mockito:mockito-inline:$mockito_ver"
63+
// testImplementation "org.powermock:powermock-module-junit4:$powermock_ver"
64+
// testImplementation "org.powermock:powermock-api-mockito2:$powermock_ver"
6465
testImplementation "com.noveogroup.android:android-logger:$android_logger_ver"
6566

6667
androidTestImplementation "androidx.work:work-testing:$work_runtime"
@@ -72,9 +73,10 @@ dependencies {
7273
androidTestImplementation "androidx.test:core-ktx:$androidx_test_core"
7374

7475
androidTestImplementation "org.mockito:mockito-core:$mockito_ver"
75-
androidTestImplementation "com.crittercism.dexmaker:dexmaker:$dexmaker_ver"
76-
androidTestImplementation "com.crittercism.dexmaker:dexmaker-dx:$dexmaker_ver"
77-
androidTestImplementation "com.crittercism.dexmaker:dexmaker-mockito:$dexmaker_ver"
76+
androidTestImplementation "org.mockito:mockito-android:$mockito_ver"
77+
// androidTestImplementation "com.crittercism.dexmaker:dexmaker:$dexmaker_ver"
78+
// androidTestImplementation "com.crittercism.dexmaker:dexmaker-dx:$dexmaker_ver"
79+
// androidTestImplementation "com.crittercism.dexmaker:dexmaker-mockito:$dexmaker_ver"
7880
androidTestImplementation "com.noveogroup.android:android-logger:$android_logger_ver"
7981
androidTestImplementation "com.fasterxml.jackson.core:jackson-databind:$jacksonversion"
8082
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"

event-handler/src/androidTest/java/com/optimizely/ab/android/event_handler/EventClientTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@
3434
import java.net.HttpURLConnection;
3535
import java.net.URL;
3636

37-
import static org.mockito.Matchers.any;
38-
import static org.mockito.Matchers.anyInt;
39-
import static org.mockito.Matchers.contains;
37+
import static org.mockito.ArgumentMatchers.any;
38+
import static org.mockito.ArgumentMatchers.anyInt;
39+
import static org.mockito.ArgumentMatchers.contains;
4040
import static org.mockito.Mockito.doThrow;
4141
import static org.mockito.Mockito.mock;
4242
import static org.mockito.Mockito.verify;

event-handler/src/androidTest/java/com/optimizely/ab/android/event_handler/EventReschedulerTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@
2323
import org.junit.Ignore;
2424
import org.junit.Test;
2525
import org.junit.runner.RunWith;
26-
import org.mockito.runners.MockitoJUnitRunner;
26+
import org.mockito.junit.MockitoJUnitRunner;
2727
import org.slf4j.Logger;
2828

29-
import static org.mockito.Matchers.any;
30-
import static org.mockito.Matchers.matches;
29+
import static org.mockito.ArgumentMatchers.any;
30+
import static org.mockito.ArgumentMatchers.matches;
3131
import static org.mockito.Mockito.doNothing;
3232
import static org.mockito.Mockito.doReturn;
3333
import static org.mockito.Mockito.doThrow;

event-handler/src/test/java/com/optimizely/ab/android/event_handler/EventClientTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import org.mockito.ArgumentCaptor;
2525
import org.mockito.Mock;
2626
import org.mockito.exceptions.base.MockitoException;
27-
import org.mockito.runners.MockitoJUnitRunner;
27+
import org.mockito.junit.MockitoJUnitRunner;
2828
import org.slf4j.Logger;
2929

3030
import java.io.IOException;
@@ -35,8 +35,8 @@
3535

3636
import static junit.framework.Assert.assertEquals;
3737
import static junit.framework.Assert.assertFalse;
38-
import static org.mockito.Matchers.any;
39-
import static org.mockito.Matchers.eq;
38+
import static org.mockito.ArgumentMatchers.any;
39+
import static org.mockito.ArgumentMatchers.eq;
4040
import static org.mockito.Mockito.mock;
4141
import static org.mockito.Mockito.verify;
4242
import static org.mockito.Mockito.when;

event-handler/src/test/java/com/optimizely/ab/android/event_handler/EventWorkerUnitTest.java

Lines changed: 43 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,14 @@
1919
import static org.junit.Assert.assertEquals;
2020
import static org.junit.Assert.assertFalse;
2121
import static org.junit.Assert.assertNull;
22-
import static org.mockito.Matchers.any;
23-
import static org.mockito.Matchers.anyString;
22+
import static org.mockito.ArgumentMatchers.any;
23+
import static org.mockito.ArgumentMatchers.anyString;
2424
import static org.mockito.Mockito.mock;
2525
import static org.mockito.Mockito.when;
26+
import static org.mockito.Mockito.*;
27+
28+
import org.mockito.MockedStatic;
29+
2630

2731
import android.content.Context;
2832

@@ -35,22 +39,17 @@
3539
import org.junit.Test;
3640
import org.junit.runner.RunWith;
3741
import org.mockito.Mockito;
38-
import org.powermock.api.mockito.PowerMockito;
39-
import org.powermock.core.classloader.annotations.PowerMockIgnore;
40-
import org.powermock.core.classloader.annotations.PrepareForTest;
41-
import org.powermock.modules.junit4.PowerMockRunner;
42+
import org.mockito.junit.MockitoJUnitRunner;
4243

4344
import java.io.IOException;
4445

4546
/**
4647
* Tests {@link EventWorker}
4748
*/
48-
@RunWith(PowerMockRunner.class)
49-
@PrepareForTest({ EventWorker.class, EventHandlerUtils.class, WorkerParameters.class })
50-
@PowerMockIgnore("jdk.internal.reflect.*")
49+
@RunWith(MockitoJUnitRunner.class)
5150
public class EventWorkerUnitTest {
5251

53-
private WorkerParameters mockWorkParams = PowerMockito.mock(WorkerParameters.class);
52+
private WorkerParameters mockWorkParams = mock(WorkerParameters.class);
5453
private EventWorker eventWorker = new EventWorker(mock(Context.class), mockWorkParams);
5554

5655
private String host = "http://www.foo.com";
@@ -72,31 +71,40 @@ public void dataForCompressedEvent() {
7271
assertEquals(data.getString("bodyCompressed"), base64);
7372
assertNull(data.getString("body"));
7473
}
75-
7674
@Test
7775
public void compressEvent() throws IOException {
7876
String base64 = "abc123";
79-
PowerMockito.mockStatic(EventHandlerUtils.class);
80-
when(EventHandlerUtils.compress(anyString())).thenReturn(base64);
8177

82-
Data data = EventWorker.compressEvent(host, smallBody);
83-
assertEquals(data.getString("url"), host);
84-
assertEquals(data.getString("bodyCompressed"), base64);
85-
assertNull(data.getString("body"));
78+
// Mocking the static method compress in EventHandlerUtils
79+
try (MockedStatic<EventHandlerUtils> mockedStatic = mockStatic(EventHandlerUtils.class)) {
80+
mockedStatic.when(() -> EventHandlerUtils.compress(anyString())).thenReturn(base64);
81+
82+
Data data = EventWorker.compressEvent(host, smallBody);
83+
84+
// Verify the results
85+
assertEquals(data.getString("url"), host);
86+
assertEquals(data.getString("bodyCompressed"), base64);
87+
assertNull(data.getString("body"));
88+
89+
// Optionally, verify that the method was called
90+
mockedStatic.verify(() -> EventHandlerUtils.compress(anyString()));
91+
}
8692
}
8793

94+
8895
@Test
8996
public void compressEventWithCompressionFailure() throws IOException {
90-
PowerMockito.mockStatic(EventHandlerUtils.class);
91-
PowerMockito.doThrow(new IOException()).when(EventHandlerUtils.class);
92-
EventHandlerUtils.compress(anyString()); // PowerMockito throws exception on this static method
97+
try (MockedStatic<EventHandlerUtils> mockedStatic = mockStatic(EventHandlerUtils.class)) {
98+
mockedStatic.when(() -> EventHandlerUtils.compress(anyString())).thenThrow(new IOException());
9399

94-
// return original body if compress fails
100+
// return original body if compress fails
95101

96-
Data data = EventWorker.compressEvent(host, smallBody);
97-
assertEquals(data.getString("url"), host);
98-
assertEquals(data.getString("body"), smallBody);
99-
assertNull(data.getByteArray("bodyCompressed"));
102+
Data data = EventWorker.compressEvent(host, smallBody);
103+
assertEquals(data.getString("url"), host);
104+
assertEquals(data.getString("body"), smallBody);
105+
assertNull(data.getByteArray("bodyCompressed"));
106+
107+
}
100108
}
101109

102110
@Test
@@ -155,12 +163,17 @@ public void getEventBodyFromInputDataCompressed() {
155163
public void getEventBodyFromInputDataDecompressFailure() throws Exception {
156164
Data data = EventWorker.compressEvent(host, smallBody);
157165

158-
PowerMockito.mockStatic(EventHandlerUtils.class);
159-
PowerMockito.doThrow(new IOException()).when(EventHandlerUtils.class);
160-
EventHandlerUtils.decompress(any()); // PowerMockito throws exception on this static method
166+
try (MockedStatic<EventHandlerUtils> mockedStatic = mockStatic(EventHandlerUtils.class)) {
167+
mockedStatic.when(() -> EventHandlerUtils.compress(anyString())).thenThrow(new IOException());
161168

162-
String str = eventWorker.getEventBodyFromInputData(data);
163-
assertNull(str);
169+
// return original body if compress fails
170+
171+
EventHandlerUtils.decompress(any());
172+
173+
String str = eventWorker.getEventBodyFromInputData(data);
174+
assertNull(str);
175+
176+
}
164177
}
165178

166179
@Test
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
mock-maker-inline

0 commit comments

Comments
 (0)