[FSSDK-11589] Add go-sdk logic to support agent for cmab (#412)

* Fix CMAB error handling to properly propagate error reasons in Decision objects

* add go-sdk logic to support agent for cmab

* cleanup debug statements

* add cmab cache options to getAllOptions

* fix failing fsc tests

* add cmab errors file

* adjust lowercase

* add test

* fix error message propagation in resons

* add error handling to feature experiment servvice

* Add more error handling to feature exper and composite feature service

* nil back to err

* add reasons message to composite feature service GetDecision

* use AddError for reasons

* Trigger PR check

* fix cyclomatic complexity by refactoring client.go code

* fix lint error

* fix lint

* Trigger PR check

* remove implicit error handling - PR feedback

* [FSSDK-11649] Fix FSC failed tests for CMAB (#411)

* Fix CMAB error handling to properly propagate error reasons in Decision objects

* add cmab cache options to getAllOptions

* fix failing fsc tests

* add cmab errors file

* adjust lowercase

* add test

* fix error message propagation in resons

* add error handling to feature experiment servvice

* Add more error handling to feature exper and composite feature service

* nil back to err

* add reasons message to composite feature service GetDecision

* use AddError for reasons

* Trigger PR check

* remove implicit error handling - PR feedback

* use nil instead of err for legacy

* fix error format

* Fix lint issue with fsc error

* Rename error var, lint stuttering issue

* add go-sdk logic to support agent for cmab

* fix failing fsc tests

* adjust lowercase

* fix error message propagation in resons

* add error handling to feature experiment servvice

* Add more error handling to feature exper and composite feature service

* Trigger PR check

* fix cyclomatic complexity by refactoring client.go code

* Trigger PR check

* remove implicit error handling - PR feedback

* Update license year

* Force GitHub refresh

* change nill to err in feat exper service

* fix tests

* add two tests

* Force GitHub refresh

* Add tests to address coveralls

* add couple more tests

* few more tests

* add test for TrGetCmabDecision

* fix formatting

* add optional CmabUUID field to OptimizelyDecision for CMAB support

* simplify cmab agent support in go-sdk

* Add CMAB config struct and constants

* fix tests

* cleanup

* format

* add tests for coveralls

* add new etst and format

* Add CMAB support with config merging and remove CmabUUID from public API

* fix low test coverage

* fix PR comments

* additional fixes to pr comments

* Fix whitespace in experiment_bucketer_service_test.go to match master

- Restore correct space indentation to match master branch
- Addresses coworker comment: 'can we keep this file unchanged?'

* update pred endpoint back to preduction, remove inte

Author: Mat001

.golangci.yml

@@ -1,12 +1,13 @@
 linters-settings:
  govet:
-   check-shadowing: true
+   enable:
+     - shadow
+ # golint removed in newer versions, but works in v1.54.2
  golint:
    min-confidence: 0
  gocyclo:
    min-complexity: 16
- maligned:
-   suggest-new: true
+ # maligned removed - replaced by govet fieldalignment
  dupl:
    threshold: 100
  goconst:
@@ -31,45 +32,57 @@ linters-settings:
 linters:
  disable-all: true
  enable:
-   - megacheck
-   - golint
+   # Core linters
    - govet
-   - unconvert
-   - megacheck
-   - structcheck
-   - gas
-   - gocyclo
-   - dupl
-   - misspell
-   - unparam
-   - varcheck
-   - deadcode
    - typecheck
    - ineffassign
-   - varcheck
+   - gofmt
+   
+   # Static analysis
+   - staticcheck
+   - gosimple
+   - unused
+   
+   # Security
+   - gosec
+   
+   # Style and quality
+   - golint  # deprecated but still works in v1.54.2
    - stylecheck
-   #- gochecknoinits
-   - scopelint
+   
+   # Code complexity
+   - gocyclo
+   - dupl
    - gocritic
-   - golint
    - nakedret
-   - gosimple
-   - prealloc 
-   - maligned
-   - gofmt
+   
+   # Performance
+   - prealloc
+   - unconvert
+   
+   # Correctness
+   - unparam
+   - misspell
+   
+   # Replacing deprecated linters
+   - exportloopref  # replaces scopelint (works in v1.54.2)
+   # - fieldalignment # replaces maligned (in govet)
  fast: false
+ 
+ # Enable additional checks
+ enable-all: false
 
 run:
- skip-dirs:
-   - vendor
  concurrency: 4
 
 issues:
+ exclude-dirs:
+   - vendor
  exclude-rules:
    - text: "weak cryptographic primitive"
      linters:
        - gosec
  exclude-use-default: false
 
 service:
- golangci-lint-version: 1.17.x
+ golangci-lint-version: 1.54.x

pkg/client/client.go

@@ -1,5 +1,5 @@
 /****************************************************************************
- * Copyright 2019-2024, Optimizely, Inc. and contributors                   *
+ * Copyright 2019-2025, Optimizely, Inc. and contributors                   *
  *                                                                          *
  * Licensed under the Apache License, Version 2.0 (the "License");          *
  * you may not use this file except in compliance with the License.         *
@@ -173,6 +173,7 @@ func (o *OptimizelyClient) decide(userContext *OptimizelyUserContext, key string
 		Attributes:        userContext.GetUserAttributes(),
 		QualifiedSegments: userContext.GetQualifiedSegments(),
 	}
+
 	var variationKey string
 	var eventSent, flagEnabled bool
 	allOptions := o.getAllOptions(options)
@@ -469,7 +470,7 @@ func (o *OptimizelyClient) Activate(experimentKey string, userContext entities.U
 }
 
 // IsFeatureEnabled returns true if the feature is enabled for the given user. If the user is part of a feature test
-// then an impression event will be queued up to be sent to the Optimizely log endpoint for results processing.
+// then an impression event will be queued up to the Optimizely log endpoint for results processing.
 func (o *OptimizelyClient) IsFeatureEnabled(featureKey string, userContext entities.UserContext) (result bool, err error) {
 
 	defer func() {

pkg/client/factory.go

@@ -1,5 +1,5 @@
 /****************************************************************************
- * Copyright 2019-2020,2022-2024 Optimizely, Inc. and contributors          *
+ * Copyright 2019-2020,2022-2025 Optimizely, Inc. and contributors          *
  *                                                                          *
  * Licensed under the Apache License, Version 2.0 (the "License");          *
  * you may not use this file except in compliance with the License.         *
@@ -22,6 +22,7 @@ import (
 	"errors"
 	"time"
 
+	"github.com/optimizely/go-sdk/v2/pkg/cmab"
 	"github.com/optimizely/go-sdk/v2/pkg/config"
 	"github.com/optimizely/go-sdk/v2/pkg/decide"
 	"github.com/optimizely/go-sdk/v2/pkg/decision"
@@ -53,6 +54,7 @@ type OptimizelyFactory struct {
 	overrideStore        decision.ExperimentOverrideStore
 	userProfileService   decision.UserProfileService
 	notificationCenter   notification.Center
+	cmabConfig           *cmab.Config
 
 	// ODP
 	segmentsCacheSize    int
@@ -159,6 +161,10 @@ func (f *OptimizelyFactory) Client(clientOptions ...OptionFunc) (*OptimizelyClie
 		if f.overrideStore != nil {
 			experimentServiceOptions = append(experimentServiceOptions, decision.WithOverrideStore(f.overrideStore))
 		}
+		// Add CMAB config option if provided
+		if f.cmabConfig != nil {
+			experimentServiceOptions = append(experimentServiceOptions, decision.WithCmabConfig(f.cmabConfig))
+		}
 		compositeExperimentService := decision.NewCompositeExperimentService(f.SDKKey, experimentServiceOptions...)
 		compositeService := decision.NewCompositeService(f.SDKKey, decision.WithCompositeExperimentService(compositeExperimentService))
 		appClient.DecisionService = compositeService
@@ -320,6 +326,13 @@ func WithTracer(tracer tracing.Tracer) OptionFunc {
 	}
 }
 
+// WithCmabConfig sets the CMAB configuration options
+func WithCmabConfig(cmabConfig *cmab.Config) OptionFunc {
+	return func(f *OptimizelyFactory) {
+		f.cmabConfig = cmabConfig
+	}
+}
+
 // StaticClient returns a client initialized with a static project config.
 func (f *OptimizelyFactory) StaticClient() (optlyClient *OptimizelyClient, err error) {
 

pkg/client/factory_test.go

@@ -28,6 +28,7 @@ import (
 	"github.com/stretchr/testify/mock"
 
 	"github.com/optimizely/go-sdk/v2/pkg/cache"
+	"github.com/optimizely/go-sdk/v2/pkg/cmab"
 	"github.com/optimizely/go-sdk/v2/pkg/config"
 	"github.com/optimizely/go-sdk/v2/pkg/decide"
 	"github.com/optimizely/go-sdk/v2/pkg/decision"
@@ -434,3 +435,141 @@ func TestConvertDecideOptionsWithCMABOptions(t *testing.T) {
 	assert.True(t, convertedOptions.ResetCMABCache)
 	assert.True(t, convertedOptions.InvalidateUserCMABCache)
 }
+
+func TestAllOptionFunctions(t *testing.T) {
+	f := &OptimizelyFactory{}
+
+	// Test all option functions to ensure they're covered
+	WithDatafileAccessToken("token")(f)
+	WithSegmentsCacheSize(123)(f)
+	WithSegmentsCacheTimeout(2 * time.Second)(f)
+	WithOdpDisabled(true)(f)
+
+	// Verify some options were set
+	assert.Equal(t, "token", f.DatafileAccessToken)
+	assert.Equal(t, 123, f.segmentsCacheSize)
+	assert.True(t, f.odpDisabled)
+}
+
+func TestStaticClientError(t *testing.T) {
+	// Use invalid datafile to force an error
+	factory := OptimizelyFactory{Datafile: []byte("invalid json"), SDKKey: ""}
+	client, err := factory.StaticClient()
+	assert.Error(t, err)
+	assert.Nil(t, client)
+}
+
+func TestFactoryWithCmabConfig(t *testing.T) {
+	factory := OptimizelyFactory{}
+	cmabConfig := cmab.Config{
+		CacheSize:   100,
+		CacheTTL:    time.Minute,
+		HTTPTimeout: 30 * time.Second,
+		RetryConfig: &cmab.RetryConfig{
+			MaxRetries: 5,
+		},
+	}
+
+	// Test the option function
+	WithCmabConfig(&cmabConfig)(&factory)
+
+	assert.Equal(t, &cmabConfig, factory.cmabConfig)
+	assert.Equal(t, 100, factory.cmabConfig.CacheSize)
+	assert.Equal(t, time.Minute, factory.cmabConfig.CacheTTL)
+	assert.Equal(t, 30*time.Second, factory.cmabConfig.HTTPTimeout)
+	assert.NotNil(t, factory.cmabConfig.RetryConfig)
+	assert.Equal(t, 5, factory.cmabConfig.RetryConfig.MaxRetries)
+}
+
+func TestFactoryCmabConfigPassedToDecisionService(t *testing.T) {
+	// Test that CMAB config is correctly passed to decision service when creating client
+	cmabConfig := cmab.Config{
+		CacheSize:   200,
+		CacheTTL:    2 * time.Minute,
+		HTTPTimeout: 20 * time.Second,
+		RetryConfig: &cmab.RetryConfig{
+			MaxRetries: 3,
+		},
+	}
+
+	factory := OptimizelyFactory{
+		SDKKey:     "test_sdk_key",
+		cmabConfig: &cmabConfig,
+	}
+
+	// Verify the config is set
+	assert.Equal(t, &cmabConfig, factory.cmabConfig)
+	assert.Equal(t, 200, factory.cmabConfig.CacheSize)
+	assert.Equal(t, 2*time.Minute, factory.cmabConfig.CacheTTL)
+	assert.NotNil(t, factory.cmabConfig.RetryConfig)
+}
+
+func TestFactoryOptionFunctions(t *testing.T) {
+	factory := &OptimizelyFactory{}
+
+	// Test all option functions to ensure they're covered
+	WithDatafileAccessToken("test_token")(factory)
+	WithSegmentsCacheSize(100)(factory)
+	WithSegmentsCacheTimeout(5 * time.Second)(factory)
+	WithOdpDisabled(true)(factory)
+	WithCmabConfig(&cmab.Config{CacheSize: 50})(factory)
+
+	// Verify options were set
+	assert.Equal(t, "test_token", factory.DatafileAccessToken)
+	assert.Equal(t, 100, factory.segmentsCacheSize)
+	assert.Equal(t, 5*time.Second, factory.segmentsCacheTimeout)
+	assert.True(t, factory.odpDisabled)
+	assert.Equal(t, &cmab.Config{CacheSize: 50}, factory.cmabConfig)
+}
+
+func TestWithCmabConfigOption(t *testing.T) {
+	factory := &OptimizelyFactory{}
+	testConfig := cmab.Config{
+		CacheSize: 200,
+		CacheTTL:  2 * time.Minute,
+	}
+	WithCmabConfig(&testConfig)(factory)
+	assert.Equal(t, &testConfig, factory.cmabConfig)
+}
+
+func TestClientWithCmabConfig(t *testing.T) {
+	// Test client creation with non-empty CMAB config (tests reflect.DeepEqual path)
+	cmabConfig := cmab.Config{
+		CacheSize:   200,
+		CacheTTL:    5 * time.Minute,
+		HTTPTimeout: 30 * time.Second,
+		RetryConfig: &cmab.RetryConfig{
+			MaxRetries: 5,
+		},
+	}
+
+	factory := OptimizelyFactory{
+		SDKKey: "test_sdk_key",
+	}
+
+	client, err := factory.Client(WithCmabConfig(&cmabConfig))
+	assert.NoError(t, err)
+	assert.NotNil(t, client)
+
+	// Verify the CMAB config was applied by checking if DecisionService exists
+	// This tests the reflect.DeepEqual check on lines 166-167
+	assert.NotNil(t, client.DecisionService)
+	client.Close()
+}
+
+func TestClientWithEmptyCmabConfig(t *testing.T) {
+	// Test client creation with empty CMAB config (tests reflect.DeepEqual returns true)
+	emptyCmabConfig := cmab.Config{}
+
+	factory := OptimizelyFactory{
+		SDKKey: "test_sdk_key",
+	}
+
+	client, err := factory.Client(WithCmabConfig(&emptyCmabConfig))
+	assert.NoError(t, err)
+	assert.NotNil(t, client)
+
+	// Verify client still works with empty config
+	assert.NotNil(t, client.DecisionService)
+	client.Close()
+}

pkg/client/optimizely_decision.go

@@ -33,7 +33,13 @@ type OptimizelyDecision struct {
 }
 
 // NewOptimizelyDecision creates and returns a new instance of OptimizelyDecision
-func NewOptimizelyDecision(variationKey, ruleKey, flagKey string, enabled bool, variables *optimizelyjson.OptimizelyJSON, userContext OptimizelyUserContext, reasons []string) OptimizelyDecision {
+func NewOptimizelyDecision(
+	variationKey, ruleKey, flagKey string,
+	enabled bool,
+	variables *optimizelyjson.OptimizelyJSON,
+	userContext OptimizelyUserContext,
+	reasons []string,
+) OptimizelyDecision {
 	return OptimizelyDecision{
 		VariationKey: variationKey,
 		Enabled:      enabled,