fix fsc

Author: raju-opti

lib/core/decision_service/index.ts

@@ -32,6 +32,7 @@ import {
   getVariationKeyFromId,
   isActive,
   ProjectConfig,
+  getTrafficAllocation,
 } from '../../project_config/project_config';
 import { AudienceEvaluator, createAudienceEvaluator } from '../audience_evaluator';
 import * as stringValidator from '../../utils/string_value_validator';
@@ -593,7 +594,7 @@ export class DecisionService {
     bucketingId: string,
     userId: string
   ): BucketerParams {
-    let trafficAllocationConfig: TrafficAllocation[] = experiment.trafficAllocation;
+    let trafficAllocationConfig: TrafficAllocation[] = getTrafficAllocation(configObj, experiment.id);
     if (experiment.cmab) {
       trafficAllocationConfig = [{
         entityId: CMAB_DUMMY_ENTITY_ID,

lib/project_config/project_config.spec.ts

@@ -457,6 +457,32 @@ describe('getVariationKeyFromId', () => {
   });
 });
 
+describe('getTrafficAllocation', () => {
+  let testData: Record<string, any>;
+  let configObj: ProjectConfig;
+
+  beforeEach(function() {
+    testData = cloneDeep(testDatafile.getTestProjectConfig());
+    configObj = projectConfig.createProjectConfig(cloneDeep(testData) as JSON);
+  });
+
+  it('should retrieve traffic allocation given valid experiment key in getTrafficAllocation', function() {
+    expect(projectConfig.getTrafficAllocation(configObj, testData.experiments[0].id)).toEqual(
+      testData.experiments[0].trafficAllocation
+    );
+  });
+
+  it('should throw error for invalid experient key in getTrafficAllocation', function() {
+    expect(() => {
+      projectConfig.getTrafficAllocation(configObj, 'invalidExperimentId');
+    }).toThrowError(
+      expect.objectContaining({
+        baseMessage: INVALID_EXPERIMENT_ID,
+        params: ['invalidExperimentId'],
+      })
+    );
+  });
+});
 
 describe('getVariationIdFromExperimentAndVariationKey', () => {
   let testData: Record<string, any>;

lib/project_config/project_config.tests.js

@@ -402,6 +402,21 @@ describe('lib/core/project_config', function() {
       );
     });
 
+    it('should retrieve traffic allocation given valid experiment key in getTrafficAllocation', function() {
+      assert.deepEqual(
+        projectConfig.getTrafficAllocation(configObj, testData.experiments[0].id),
+        testData.experiments[0].trafficAllocation
+      );
+    });
+
+    it('should throw error for invalid experient key in getTrafficAllocation', function() {
+      const ex = assert.throws(function() {
+        projectConfig.getTrafficAllocation(configObj, 'invalidExperimentId');
+      });
+      assert.equal(ex.baseMessage, INVALID_EXPERIMENT_ID);
+      assert.deepEqual(ex.params, ['invalidExperimentId']);
+    });
+    
     describe('#getVariationIdFromExperimentAndVariationKey', function() {
       it('should return the variation id for the given experiment key and variation key', function() {
         assert.strictEqual(

lib/project_config/project_config.ts

@@ -559,6 +559,22 @@ export const getExperimentFromKey = function(projectConfig: ProjectConfig, exper
   throw new OptimizelyError(EXPERIMENT_KEY_NOT_IN_DATAFILE, experimentKey);
 };
 
+
+/**
+ * Given an experiment id, returns the traffic allocation within that experiment
+ * @param  {ProjectConfig}  projectConfig  Object representing project configuration
+ * @param  {string}         experimentId   Id representing the experiment
+ * @return {TrafficAllocation[]}           Traffic allocation for the experiment
+ * @throws If experiment key is not in datafile
+ */
+export const getTrafficAllocation = function(projectConfig: ProjectConfig, experimentId: string): TrafficAllocation[] {
+  const experiment = projectConfig.experimentIdMap[experimentId];
+  if (!experiment) {
+    throw new OptimizelyError(INVALID_EXPERIMENT_ID, experimentId);
+  }
+  return experiment.trafficAllocation;
+};
+
 /**
  * Get experiment from provided experiment id. Log an error if no experiment
  * exists in the project config with the given ID.
@@ -879,4 +895,5 @@ export default {
   isFeatureExperiment,
   toDatafile,
   tryCreatingProjectConfig,
+  getTrafficAllocation,
 };