[FSSDK-11981] review update

Author: junaed-optimizely

lib/core/decision_service/cmab/cmab_service.ts

@@ -25,7 +25,8 @@ import murmurhash from "murmurhash";
 import { DecideOptionsMap } from "..";
 import { SerialRunner } from "../../../utils/executor/serial_runner";
 import {
-  CMAB_CACHE_ATTRIBUTES_MISMATCH,
+  CMAB_CACHE_HIT,
+  CMAB_CACHE_MISS,
   IGNORE_CMAB_CACHE,
   INVALIDATE_CMAB_CACHE,
   RESET_CMAB_CACHE,
@@ -66,6 +67,7 @@ export type CmabServiceOptions = {
 
 const SERIALIZER_BUCKETS = 1000;
 const LOGGER_NAME = 'CmabService';
+
 export class DefaultCmabService implements CmabService {
   private cmabCache: CacheWithRemove<CmabCacheValue>;
   private cmabClient: CmabClient;
@@ -132,9 +134,10 @@ export class DefaultCmabService implements CmabService {
 
     if (cachedValue) {
       if (cachedValue.attributesHash === attributesHash) {
+        this.logger?.debug(CMAB_CACHE_HIT, userId, ruleId);
         return { variationId: cachedValue.variationId, cmabUuid: cachedValue.cmabUuid };
       } else {
-        this.logger?.debug(CMAB_CACHE_ATTRIBUTES_MISMATCH, userId, ruleId);
+        this.logger?.debug(CMAB_CACHE_MISS, userId, ruleId);
         this.cmabCache.remove(cacheKey);
       }
     }

lib/message/log_message.ts

@@ -64,6 +64,7 @@ export const EVENT_STORE_FULL = 'Event store is full. Not saving event with id %
 export const IGNORE_CMAB_CACHE = 'Ignoring CMAB cache for user %s and rule %s.';
 export const RESET_CMAB_CACHE = 'Resetting CMAB cache for user %s and rule %s.';
 export const INVALIDATE_CMAB_CACHE = 'Invalidating CMAB cache for user %s and rule %s.';
-export const CMAB_CACHE_ATTRIBUTES_MISMATCH = 'CMAB cache attributes mismatch for user %s and rule %s, fetching new decision.';
+export const CMAB_CACHE_HIT = 'Cache hit for user %s and rule %s.';
+export const CMAB_CACHE_MISS = 'Cache miss for user %s and rule %s.'; 
 
 export const messages: string[] = [];