Skip to content

Commit f519711

Browse files
authored
fix: Allow logLevel to support string type to avoid compiler type error (#627)
* Fix LogLevel type to avoid compiler type error * Add string type to Config logLevel * Update changelog
1 parent 1c25d23 commit f519711

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

packages/optimizely-sdk/CHANGELOG.MD

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
1010

1111
- In `Optimizely` class, use `any` type when assigning the return value of `setTimeout`. This is to allow it to type check regardless of whether it uses the browser or Node version of `setTimeout` ([PR #623](https://github.com/optimizely/javascript-sdk/pull/623)), ([Issue #622](https://github.com/optimizely/javascript-sdk/issues/622))
1212

13+
- Allow to pass string type `logLevel` to `createInstance`. ([Issue #614](https://github.com/optimizely/javascript-sdk/issues/614))
14+
1315
### New Features
1416

1517
- Added `enabled` field to decision metadata structure to support upcoming application-controlled introduction of tracking for non-experiment Flag decisions ([#619](https://github.com/optimizely/javascript-sdk/pull/619))

packages/optimizely-sdk/lib/index.d.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ declare module '@optimizely/optimizely-sdk' {
7373
eventDispatcher?: EventDispatcher;
7474
logger?: LogHandler;
7575
logLevel?:
76+
| string
7677
| enums.LOG_LEVEL.DEBUG
7778
| enums.LOG_LEVEL.ERROR
7879
| enums.LOG_LEVEL.INFO
@@ -205,7 +206,7 @@ declare module '@optimizely/optimizely-sdk/lib/plugins/logger' {
205206
import { LogHandler } from '@optimizely/js-sdk-logging';
206207

207208
export interface LoggerConfig {
208-
logLevel?: enums.LOG_LEVEL;
209+
logLevel?: enums.LOG_LEVEL | string;
209210
logToConsole?: boolean;
210211
prefix?: string;
211212
}

packages/optimizely-sdk/lib/shared_types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ export interface SDKOptions {
145145
// flag to validate if this instance is valid
146146
isValidInstance: boolean;
147147
// level of logging i.e debug, info, error, warning etc
148-
logLevel?: LogLevel;
148+
logLevel?: LogLevel | string;
149149
// LogHandler object for logging
150150
logger?: LogHandler;
151151
// sdk key

0 commit comments

Comments
 (0)