From 047b93739f78ceb4d61002c83a7d627a6ca0d1dc Mon Sep 17 00:00:00 2001 From: Kenneth Kutyn Date: Tue, 24 Sep 2019 09:19:06 +1000 Subject: [PATCH] Updates and Fixed Found and fixed a couple issues: 1. Need to wait for body before trying to add extension 2. Need to check if extension exists before attempting to remove 3. Default value for selector was not one of the options. --- Extensions/Editor Extensions/Template/config.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Extensions/Editor Extensions/Template/config.json b/Extensions/Editor Extensions/Template/config.json index 40f9caa..867bc56 100644 --- a/Extensions/Editor Extensions/Template/config.json +++ b/Extensions/Editor Extensions/Template/config.json @@ -4,7 +4,7 @@ "edit_page_url": "www.optimizely.com", "form_schema": [ { - "default_value": "append", + "default_value": "beforebegin", "field_type": "dropdown", "name": "position", "label": "Position", @@ -53,9 +53,9 @@ ], "description": "", "options": { - "html": "
\n", + "html": "
\n\t\n
\n", "css": "", - "apply_js": "document.querySelector(extension.selector).insertAdjacentHTML(extension.position, extension.$html);\n", - "undo_js": "document.getElementById(\"optimizely-extension-\" + extension.$instance).remove();" + "apply_js": "var utils = optimizely.get('utils');\n\nutils.waitForElement('body')\n .then(function(elem) {\n\t\tdocument.querySelector(extension.selector).insertAdjacentHTML(extension.position, extension.$html);\n});\n", + "undo_js": "if (document.getElementById(\"optimizely-extension-\" + extension.$instance)){\n\tdocument.getElementById(\"optimizely-extension-\" + extension.$instance).remove();\n}" } -} \ No newline at end of file +}