Fix reactor isDispatching getting stuck if noop action

Author: jordangarcia

src/reactor.js

@@ -128,14 +128,15 @@ class Reactor {
 
     if (this.__batchDepth > 0) {
       this.__batchDispatchCount++
-    } else if (this.state !== prevState) {
-      try {
-        this.__notify()
-      } catch (e) {
-        this.__isDispatching = false
-        throw e
+    } else {
+      if (this.state !== prevState) {
+        try {
+          this.__notify()
+        } catch (e) {
+          this.__isDispatching = false
+          throw e
+        }
       }
-
       this.__isDispatching = false
     }
   }

tests/reactor-tests.js

@@ -209,6 +209,13 @@ describe('Reactor', () => {
 
         expect(() => reactor.dispatch('setTax', 5)).not.toThrow()
       })
+
+      it('should allow subsequent dispatches if a dispatched action doesnt cause state change', () => {
+        reactor.dispatch('noop')
+
+        expect(() => reactor.dispatch('setTax', 5)).not.toThrow()
+      })
+
       it('should allow subsequent dispatches if an observer throws an error', () => {
         var unWatchFn = reactor.observe([], state => {
           throw new Error('observer error')
@@ -1109,6 +1116,14 @@ describe('Reactor', () => {
       }).not.toThrow()
     })
 
+    it('should allow subsequent dispatches if batched action doesnt cause state change', () => {
+      reactor.batch(() => {
+        reactor.dispatch('noop')
+      })
+
+      expect(() => reactor.dispatch('add', 'one')).not.toThrow()
+    })
+
     it('should allow subsequent dispatches if an error is raised in an observer', () => {
       var unWatchFn = reactor.observe([], state => {
         throw new Error('observe error')