Skip to content

Commit 607a8de

Browse files
authored
refact: changed getFeatureVariableJson to getFeatureVariableJSON (#202)
1 parent 6acd713 commit 607a8de

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/Optimizely/Entity/FeatureVariable.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ public static function getFeatureVariableMethodName($type)
151151
case FeatureVariable::INTEGER_TYPE:
152152
return "getFeatureVariableInteger";
153153
case FeatureVariable::JSON_TYPE:
154-
return "getFeatureVariableJson";
154+
return "getFeatureVariableJSON";
155155
case FeatureVariable::STRING_TYPE:
156156
return "getFeatureVariableString";
157157
default:

src/Optimizely/Optimizely.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -809,7 +809,7 @@ public function getFeatureVariableString($featureFlagKey, $variableKey, $userId,
809809
*
810810
* @return array Associative array of json variable including key and value
811811
*/
812-
public function getFeatureVariableJson($featureFlagKey, $variableKey, $userId, $attributes = null)
812+
public function getFeatureVariableJSON($featureFlagKey, $variableKey, $userId, $attributes = null)
813813
{
814814
return $this->getFeatureVariableValueForType(
815815
$featureFlagKey,

tests/OptimizelyTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4009,7 +4009,7 @@ public function testGetFeatureVariableString()
40094009
);
40104010
}
40114011

4012-
public function testGetFeatureVariableJson()
4012+
public function testGetFeatureVariableJSON()
40134013
{
40144014
$optimizelyMock = $this->getMockBuilder(Optimizely::class)
40154015
->setConstructorArgs(array($this->datafile, null, $this->loggerMock))
@@ -4023,11 +4023,11 @@ public function testGetFeatureVariableJson()
40234023
->will($this->returnValueMap($map));
40244024
$this->assertSame(
40254025
json_decode("{\"text\": \"variable value\"}", true),
4026-
$optimizelyMock->getFeatureVariableJson('json_single_variable_feature', 'json_variable', 'user_id', [])
4026+
$optimizelyMock->getFeatureVariableJSON('json_single_variable_feature', 'json_variable', 'user_id', [])
40274027
);
40284028
}
40294029

4030-
public function testGetFeatureVariableJsonCallsDecisionListenerGivenUserInExperimentAndFeatureFlagIsEnabled()
4030+
public function testGetFeatureVariableJSONCallsDecisionListenerGivenUserInExperimentAndFeatureFlagIsEnabled()
40314031
{
40324032
// should return specific value
40334033
$decisionServiceMock = $this->getMockBuilder(DecisionService::class)
@@ -4076,7 +4076,7 @@ public function testGetFeatureVariableJsonCallsDecisionListenerGivenUserInExperi
40764076

40774077
$this->optimizelyObject->notificationCenter = $this->notificationCenterMock;
40784078

4079-
$this->optimizelyObject->getFeatureVariableJson('multiple_variables_feature', 'json_variable', 'user_id', []);
4079+
$this->optimizelyObject->getFeatureVariableJSON('multiple_variables_feature', 'json_variable', 'user_id', []);
40804080
}
40814081

40824082
public function testGetAllFeatureVariablesReturnsValuesGivenUserInExperimentAndFeatureFlagIsEnabled()

0 commit comments

Comments
 (0)