Skip to content

Commit d2f14bd

Browse files
[FSSDK-10198] odp not integrated error (#262)
* ODP integration error resolve by removing unnecessary qualified segment fetching * Condition order adjustment * Javascript sdk upgrade, odp integration public method addition * client test adjustment * package json update with explicit sdk version declaration
1 parent 3389cd6 commit d2f14bd

File tree

4 files changed

+11
-9
lines changed

4 files changed

+11
-9
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"access": "public"
3535
},
3636
"dependencies": {
37-
"@optimizely/optimizely-sdk": "^5.3.0",
37+
"@optimizely/optimizely-sdk": "^5.3.2",
3838
"hoist-non-react-statics": "^3.3.0",
3939
"prop-types": "^15.6.2",
4040
"utility-types": "^2.1.0 || ^3.0.0"

src/client.spec.ts

+1
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ describe('ReactSDKClient', () => {
7979
getFeatureVariableString: jest.fn(() => null),
8080
getOptimizelyConfig: jest.fn(() => null),
8181
getProjectConfig: jest.fn(() => null),
82+
isOdpIntegrated: jest.fn(() => true),
8283
onReady: jest.fn(() => Promise.resolve({ success: false })),
8384
close: jest.fn(),
8485
getVuid: jest.fn(),

src/client.ts

+6-5
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ export const DefaultUser: UserInfo = {
5454
attributes: {},
5555
};
5656

57-
export interface ReactSDKClient extends Omit<optimizely.Client, 'createUserContext' | 'getProjectConfig'> {
57+
export interface ReactSDKClient
58+
extends Omit<optimizely.Client, 'createUserContext' | 'getProjectConfig' | 'isOdpIntegrated'> {
5859
user: UserInfo;
5960

6061
onReady(opts?: { timeout?: number }): Promise<any>;
@@ -364,14 +365,14 @@ class OptimizelyReactSDKClient implements ReactSDKClient {
364365
}
365366

366367
public async fetchQualifiedSegments(options?: optimizely.OptimizelySegmentOption[]): Promise<boolean> {
367-
if (this.odpExplicitlyOff) {
368-
return true;
369-
}
370-
371368
if (!this.userContext) {
372369
return false;
373370
}
374371

372+
if (this.odpExplicitlyOff || !this._client?.isOdpIntegrated()) {
373+
return true;
374+
}
375+
375376
return await this.userContext.fetchQualifiedSegments(options);
376377
}
377378

yarn.lock

+3-3
Original file line numberDiff line numberDiff line change
@@ -656,9 +656,9 @@
656656
"@jridgewell/sourcemap-codec" "^1.4.10"
657657

658658
"@optimizely/optimizely-sdk@^5.3.0":
659-
version "5.3.0"
660-
resolved "https://registry.yarnpkg.com/@optimizely/optimizely-sdk/-/optimizely-sdk-5.3.0.tgz#dd1ca9d19287b31675d2f95c24234e074ade9a8b"
661-
integrity sha512-PzfjcApCvcHGir8XWSG3IBaOJXvPADjqpzXypEWTfArrONA3FlmqdnwDAlxF4b557fo/UZI6ZCyj3AWrG8cprg==
659+
version "5.3.2"
660+
resolved "https://registry.yarnpkg.com/@optimizely/optimizely-sdk/-/optimizely-sdk-5.3.2.tgz#4a4918485c9319b2237f6e32d901c3ff7e998051"
661+
integrity sha512-9d3sRusZfkN+CCq7C7DXp0bKam+dx2cDPPdcBQxLfwtTKFulzf6kGwnz4pVTtjwQ89vbJz10iJNMmD9qtSduPw==
662662
dependencies:
663663
decompress-response "^4.2.1"
664664
json-schema "^0.4.0"

0 commit comments

Comments
 (0)