Skip to content

Commit d990bbe

Browse files
linting mistakes corrected
1 parent 1af30c9 commit d990bbe

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

lib/optimizely/helpers/validator.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,11 @@ def inputs_valid?(variables, logger = NoOpLogger.new, level = Logger::ERROR)
122122

123123
return false unless variables.respond_to?(:each) && !variables.empty?
124124

125-
is_valid = true
125+
is_valid = true # rubocop:disable Lint/UselessAssignment
126126
if variables.include? :user_id
127127
# Empty str is a valid user ID.
128128
unless variables[:user_id].is_a?(String)
129-
is_valid = false
129+
is_valid = false # rubocop:disable Lint/UselessAssignment
130130
logger.log(level, "#{Constants::INPUT_VARIABLES['USER_ID']} is invalid")
131131
end
132132
variables.delete :user_id

lib/optimizely/optimizely_factory.rb

-1
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ def self.custom_instance( # rubocop:disable Metrics/ParameterLists
142142
notification_center = nil,
143143
settings = nil
144144
)
145-
146145
error_handler ||= NoOpErrorHandler.new
147146
logger ||= NoOpLogger.new
148147
notification_center = notification_center.is_a?(Optimizely::NotificationCenter) ? notification_center : NotificationCenter.new(logger, error_handler)

0 commit comments

Comments
 (0)