WMS 11892 QA Fixes (#426)

* QA Fixes

Clarified instructions, QA

* Minor QA Fixes

More QA fixes

Author: lmfarley10

atom-agent-multi-tool/deploy-agent-tools/deploy-agent-tools.md

@@ -6,7 +6,6 @@ This lab will go through the steps on configuring the GenAI Agent tools. First w
 
 The following agent tools will be configured: 
 * General LLM Chat (Built-in)
-* Document Understanding
 * Weather
 * RAG 
 * SQL
@@ -115,11 +114,9 @@ This task will help you ensure that the Dynamic Group and Policy are correctly d
 
 This task will help you to create a VCN and private subnet in your compartment. This will be used for the ADB for the SQL Tool.
 
-1. Go to Networking -> Virtual cloud networks and Create VCN. Provide IPv4 CIDR Blocks as 10.0.0.0/16
+1. Go to Networking -> Virtual cloud networks and select the VCN created in Lab 1.
 
-2. Go to the newly created VCN and click on Create Subnet. Provide IPv4 CIDR Block as 10.0.1.0/24 and click on Private Subnet. You can leave rest as default. Click on Create Subnet.
-
-3. Click on newly created subnet and go to the Security List. Add following ingress rules in the security list. Make sure to have the ingress rule to access database port 1521-1522
+2. Click on the private subnet and go to the Security List. Add following ingress rules in the security list. Make sure to have the ingress rule to access database port 1521-1522
 
     ![Ingress Rules](images/adb/ingress_rules.png)
 
@@ -248,7 +245,13 @@ CREATE TABLE Employees (
 </copy>
 ```
 
-> **Note** If you are using your own table, you can get a better idea of the schema by running DESC table_name;
+> **Note** If using your own table, to get a better idea of the schema run
+
+```sql
+DESC table_name;
+```
+ 
+in SQL Developer. 
 
 ![Create SQL Tool](images/sqltool/create-tool.png)
 
@@ -265,17 +268,17 @@ CREATE TABLE Employees (
 
   ![Test SQL Tool](./images/sql/test-sql-tool-2.png)
 
-  > * **Note** If your sql tool is not returning the correct response, it can be helpful to provide an in-line example to the tool. Also see [SQL Tool Guidelines](https://docs.oracle.com/en-us/iaas/Content/generative-ai-agents/sqltool-guidelines.htm#sqltool-iclexamples)
+  > * **Note** If the sql tool is not returning the correct response, it can be helpful to provide an in-line example to the tool. Also see [SQL Tool Guidelines](https://docs.oracle.com/en-us/iaas/Content/generative-ai-agents/sqltool-guidelines.htm#sqltool-iclexamples)
 
-  > * **Note** Also make sure your agent is using the correct tool for the job. If the agent is using the wrong tool, make sure to add a more detailed description and/or routing instructions.
+  > * **Note** Also make sure the agent is using the correct tool for the job. If the agent is using the wrong tool, make sure to add a more detailed description and/or routing instructions.
 
-  > * **Note** If you are getting 404 errors, you are likely missing a policy. Refer back to Task 1 step 6. 
+  > * **Note** If returning 404 errors, there is likely a missing policy. Refer back to [Task 2 step 6](./deploy-agent-tools.md#task-2-dynamic-group-and-policy-definition-for-adb-and-db-tools-connection). 
 
-  > * **Note** If you are querying a large table and getting 100+ rows of results, the query will fail. Try adding more filters to your query to reduce size of response. 
+  > * **Note** If querying a large table and getting 100+ rows of results, the query will fail. Try adding more filters to the query to reduce size of response. 
 
 ## Task 9: Create a Weather Tool
 
-  1. Navigate to your agent tools and create a new tool called "get_weather" 
+  1. Navigate to the agent tools and create a new custom function tool called "get_weather" 
 
   - Give the following description - 
 
@@ -306,7 +309,7 @@ In this section, we will delve into the process of creating and deploying an Ora
 
 2. Navigate back to your function application created in the previous lab.
 
-3. Select Getting Started > Cloud setup and take note of the steps to login and deploy the functions.
+3. Select Application > Cloud shell setup > View guide and take note of the steps to login and deploy the functions.
 
     ![Fn Cloud Setup](images/fn-deploy/cloud-shell.png)
 
@@ -315,7 +318,7 @@ In this section, we will delve into the process of creating and deploying an Ora
         - Logging in to the container registry 
         - Deploying the function to your application
 
-   > **Note:** You don't need to run the last invoke command. We will be invoking the function later from ODA. 
+   > **Note:** The init command doesn't need to be run since the fn is already provided. The last invoke command also doesn't need to be ran. We will be invoking the function later from ODA. 
 
 4. At the top right of the oci console, open a new cloud shell
 
@@ -357,15 +360,23 @@ In this section, we will delve into the process of creating and deploying an Ora
   </copy>
   ```
 
-  - Take note of the function invoke endpoint once created
+  - Take note of the function invoke endpoint once created.
 
 ![Deployed Function](images/fn-deploy/deploy_function.png)
 
-> **Note** If you get an error with the architecture, you can change the architecture from the cloud shell 
+> **Note** If there is an error with the architecture, the architecture can be changed from the cloud shell. 
+
+> **Note** If you run into space issues, you can delete any unused containers with 
+
+```bash
+$ docker image prune 
+or 
+$ docker image prune -a 
+```
 
 ![Change Architecture](images/fn-deploy/change-architecture-cs.png)
 
-> **Note** Functions can sometimes time out when invoked for the first time (cold start). To avoid this, you can enable provisioned concurrency on your function to enable hot starts. 
+> **Note** Functions can sometimes time out when invoked for the first time (cold start). To avoid this, enable provisioned concurrency on the function to enable hot starts. 
 
 ![Provisioned Concurrency](images/fn-deploy/provisioned-concurrency.png)
 
@@ -388,4 +399,4 @@ In this section, we will delve into the process of creating and deploying an Ora
   * **Abhinav Jain**, Senior Cloud Engineer, NACIE
 
 **Last Updated By/Date**
-  * **Luke Farley**, Senior Cloud Engineer, NACIE, May 2025
+  * **Luke Farley**, Senior Cloud Engineer, NACIE, Sept 2025

atom-agent-multi-tool/deploy-agent-tools/images/adb/ingress_rules.png

@@ -34,7 +34,7 @@ This task will help you to create Oracle Digital Assistant under your chosen com
 
    ![Navigate to Digital Assistant](images/oda/oda_provision_1.png)
 
-   > **Note:** You can find Digital Assistant under the AI Services.
+   > **Note:** Digital Assistant can be found under AI Services.
 
 2. Provide the information for **Compartment**, **Name** , **Description** (optional) & **Shape**. Click **Create**
 
@@ -87,7 +87,8 @@ Rule 3
     ```text
     <copy>
     Allow any-user to use fn-invocation in tenancy where request.principal.id='ocid1.odainstance.oc1.us-chicago-1.XXXXXXXXXXXXXXXXXXXX'
-    Allow dynamic-group odaDynamicGroup to use fn-invocation in tenancy
+    Allow dynamic-group <your-dynamic-group> to use fn-invocation in tenancy
+    Allow dynamic-group <your-dynamic-group> to manage genai-agent-family in tenancy
     </copy>
     ```
 
@@ -107,11 +108,11 @@ Rule 3
 
 3. Test the connection. If successful, you should get a 200 response with a session id. Note the session id for the next Task. 
 
-    > **Note** If you get a 404 error, that likely means a policy is missing or misconfigured. Check Task 2 and make sure the ODA service can connect to the agent service. 
+    > **Note** If it's throwing a 404 error, that likely means a policy is missing or misconfigured. Check [Task 2](./integrate-digital-assistant.md#task-2-dynamic-group--policy-creation-for-oracle-digital-assistant) and make sure the ODA service can connect to the agent service. 
 
 ## Task 4: Configure API Endpoint to Agent Function
 
-1. Open your ODA service console provisioned in Task 1 and navigate to API services > Add Service
+1. Open the ODA service console provisioned in Task 1 and navigate to API services > Add Service
 
     ![API Services](images/oda/oda-configure-fn.png)
 
@@ -128,17 +129,21 @@ Rule 3
     </copy>
     ```
     
-3. If configured correctly, you should get a success response 
+    > * **Note** Be sure to include OCI Resource Principal as authentication. 
+
+3. If configured correctly, there should be a success response 
 
     ![200 Response](images/oda/success-response.png)
 
-    > * **Note** 404 responses usually indicate a policy is missing/misconfigured. Please refer back to Task 2.
+    > * **Note** 404 responses usually indicate a policy is missing/misconfigured. Please refer back to [Task 2](./integrate-digital-assistant.md#task-2-dynamic-group--policy-creation-for-oracle-digital-assistant).
+
+    > * **Note** Session IDs by default last for one hour. After one hour a new session id will have to be created. 
 
-    > * **Note** Session IDs by default last for one hour. After one hour you will have to generate a new session id. 
+    > * **Note** If the function isn't enabled to have hot starts, the function might need to be invoked twice before getting a 200 response. 
 
 ## Task 5: Import Skill
 
-1. Import the following skill 
+1. Import the following skill under Development > Skills > Import Skill (top right)
 
     [genai-agent-adk-livelab](https://idb6enfdcxbl.objectstorage.us-chicago-1.oci.customer-oci.com/n/idb6enfdcxbl/b/Livelabs/o/atom-multi-tool-livelab%2Fgenaiagentadklivelab(1.0).zip)
 
@@ -150,7 +155,7 @@ Rule 3
 
 4. Open the 'UnresolvedIntent' flow and select the 'callAgent' state
 
-5. In the REST service select your own function api endpoint 
+5. In the REST service select the function api endpoint 
 
     ![Configure Agent Fn](images/oda/skill-config-fn.png)
 
@@ -165,17 +170,19 @@ Rule 3
     </copy>
     ```
 
-7. Train the bot and select preview (top right). Ask a question such as 'How are you'. If everything was configured correctly, you should get a response. 
+7. Set the Result variable to 'agentResult'.
 
-    > **Note** You can review any unexpected behavior in the preview of ODA to diagnose any issues. 
+8. Train the bot and select preview (top right). Ask a question such as 'How are you'. If everything was configured correctly, you should get a response. 
+
+    > **Note** Any unexpected behavior can be reviewed in the preview of ODA to diagnose issues. 
     
 ## Task 6: Configure & Expose Skill
 
 1. Navigate to Development > Channels and select 'Add Channel' 
 
     ![Add Channel](images/oda/add-channel.png)
 
-2. Select Oracle Web, disable client authentication, and put '*' as allowed domains 
+2. Select Oracle Web, disable client authentication, and put '*' as allowed domains. Also make sure the channel is routed to the skill and enabled.
 
     ![Create Channel](images/oda/create-channel.png)
 
@@ -217,7 +224,7 @@ Rule 3
 
     * **URI** = '<https://oda-XXXXXXXXXXXXXXXXXXXXXX.data.digitalassistant.oci.oraclecloud.com/>'
     * **channelId** = 'XXXXXXXXXXXXXXXXXXXXXXXXXXXX'
-    * Please change value of initUserHiddenMessage on Line 32 from 'what can you do' to 'Hello'
+    * Please make sure the initUserHiddenMessage on Line 32 is 'Hello'
 
     ![Create Channel](images/vb/vb_config.png)
 
@@ -235,15 +242,17 @@ Rule 3
 
     ![Invoke Tools](images/vb/chat-sql.png)
 
-     > * **Note** If you are using your own tables with lots of data and it occasionally throws 'Oops' errors, this can be fixed by optimizing your sql queries. This can be done by filtering your results to remove unnecessary columns, specifically by providing in-line sql example to the sql tool. Refer back to the previous lab on creating sql tools. 
+     > * **Note** If using your own tables with lots of data and it occasionally throws 'Oops' errors, this can be fixed by optimizing the sql queries. This can be done by filtering the results to remove unnecessary columns, specifically by providing in-line sql example to the sql tool. Refer back to the [previous lab](../deploy-agent-tools/deploy-agent-tools.md#task-8-create-sql-tool) on creating sql tools. 
 
     * You can also invoke the raq tool or ask general questions 
 
     ![RAG and General Questions](images/vb/chat-3.png)
 
 **Troubleshooting** 
 
-1. If you get 404 errors, it's likely a permission issue. Please review the policies. 
+1. If there are 404 errors, it's likely a permission issue. Please review the policies. 
+
+2. For other errors, logging can be enabled in the function application under Monitoring > Function Invocation logs.
 
 ## Acknowledgements
 
@@ -255,4 +264,4 @@ Rule 3
 * **Abhinav Jain**, Senior Cloud Engineer, NACIE
 
 **Last Updated By/Date:**
-* **Luke Farley**, Senior Cloud Engineer, NACIE, May 2025
+* **Luke Farley**, Senior Cloud Engineer, NACIE, Sept 2025

atom-agent-multi-tool/integrate-digital-assistant/integrate-digital-assistant.md

@@ -170,26 +170,14 @@ This task will help you to create Oracle Object Storage Bucket under your chosen
 
     **Note:** The Gen AI Agents service currently supports .pdf and .txt file formats
 
-    <!--TODO: should we provide a sample dataset? -->
+    If you would like to use a sample pdf, click [here](https://objectstorage.us-chicago-1.oraclecloud.com/p/FGxCnVLMgA-0O62bDnhbQCc-0dHHE8nbUaWpCGITsYtkeX3LA8dXp7NYeL_F609R/n/idb6enfdcxbl/b/Livelabs/o/atom-multi-tool-livelab/Design%20Considerations%20for%20GenAI%20Apps.pdf)
 
     ![object storage select files](images/kb/os_file_select.png)
 
 2. Click Upload -> Close to upload the PDF file in the Object Storage Bucket.
 
     ![object storage upload files](images/kb/os_upload.png)
 
-3. Create a PAR (Pre-Authenticated Request) for your newly created bucket.
-
-    ![create par](images/kb/create_par.png)
-
-4. Create this PAR at the bucket level and not the object level. Also, change the expiration date to a future date preferably 4-5 years from now.
-
-    ![create par bucket](images/kb/create_par_bucket.png)
-
-5. Copy over the PAR URL highlighted in the image below. Please copy over the second URL and not the first one.
-
-    ![par url](images/kb/par_url.png)
-
 ## Task 6: Provision Knowledge Base
 
 This task will help you to create Oracle Generative AI Agent’s Knowledge Base under your chosen compartment.
@@ -244,6 +232,8 @@ This task will help you to create Oracle Generative AI Agent under your chosen c
 
     ![agent creation wizard](images/agent/agent_wizard.png)
 
+    > **Note** The agent tools will be configured in the next lab.
+
 3. In few minutes the status of recently created Agent will change from Creating to Active
 
     Click on “Endpoints” menu item in the left panel and then the Endpoint link in the right panel.
@@ -269,7 +259,7 @@ In this section, we will deploy a VCN, OCI Function application, and a serverles
 
     ![Create VCN](images/functions/networking-vcn.png)
 
-    - Select 'Start VCN Wizard' 
+    - Select Actions > 'Start VCN Wizard' 
 
     ![Start VCN Wizard](images/functions/vcn-wizard.png)
 
@@ -283,7 +273,7 @@ In this section, we will deploy a VCN, OCI Function application, and a serverles
 
     - Navigate to Review and Create and select 'Create'
 
-3. Create function application using subnet in previous step
+3. Create function application using the public subnet in previous step
 
     - From the Cloud Console, navigate to Developer Services > Functions > Applications 
 
@@ -293,7 +283,7 @@ In this section, we will deploy a VCN, OCI Function application, and a serverles
 
     ![Fn App Config](images/functions/fn-app-config.png)
 
-4. You may now **proceed to the next lab*
+4. You may now **proceed to the next lab**
 
 ## Learn More
 
@@ -314,4 +304,4 @@ In this section, we will deploy a VCN, OCI Function application, and a serverles
 * **Yanir Shahak**, Senior Principal Software Engineer
 
 **Last Updated By/Date:**
-* **Luke Farley**, Senior Cloud Engineer, NACIE, May 2025
+* **Luke Farley**, Senior Cloud Engineer, NACIE, Sept 2025