Fixes an issue where the --served-model-name attribute was being added by default to all deployments. (#1271)

Author: mrDzurb

ads/aqua/modeldeployment/deployment.py

@@ -563,16 +563,13 @@ def _create(
 
         params = f"{params} {deployment_params}".strip()
 
-        if create_deployment_details.model_name:
-            # Replace existing --served-model-name argument if present, otherwise add it
-            if "--served-model-name" in params:
-                params = re.sub(
-                    r"--served-model-name\s+\S+",
-                    f"--served-model-name {create_deployment_details.model_name}",
-                    params,
-                )
-            else:
-                params += f" --served-model-name {create_deployment_details.model_name}"
+        if create_deployment_details.model_name and "--served-model-name" in params:
+            # Replace existing --served-model-name argument with custom name provided by user
+            params = re.sub(
+                r"--served-model-name\s+\S+",
+                f"--served-model-name {create_deployment_details.model_name}",
+                params,
+            )
 
         if params:
             env_var.update({"PARAMS": params})