Skip to content

Commit 62a8c69

Browse files
author
Tim Middleton
authored
The correct help screen is not being displayed when help is selected in Show Connections window (#59)
1 parent ef3ab4c commit 62a8c69

File tree

7 files changed

+241
-88
lines changed

7 files changed

+241
-88
lines changed

‎coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/panel/util/ExportableJTable.java‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,10 @@ public void actionPerformed(ActionEvent event)
179179
else if (src.equals(m_menuItemHelp))
180180
{
181181
String sSimpleName = dataModel.getClass().getSimpleName();
182+
if ("".equals(sSimpleName))
183+
{
184+
sSimpleName = "ProxyConnectionsTableModel";
185+
}
182186

183187
try
184188
{

‎help/help.adoc‎

Lines changed: 44 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ For the main Coherence VisualVM Plugin documentation please see https://github.c
4343
** <<FederationOutboundTableModel, Federation Outbound Table>>
4444
** <<FederationInboundTableModel, Federation Inbound Table>>
4545
* <<ProxyTableModel, Proxy Servers Table>>
46+
** <<ProxyConnectionsTableModel, Proxy Connections Table>>
4647
* <<HttpProxyTableModel, Http Servers Table>>
4748
** <<HttpProxyMemberTableModel, Http Servers Detail Table>>
4849
* <<PersistenceTableModel, Persistence Table>>
@@ -67,7 +68,7 @@ Please see the https://www.oracle.com/pls/topic/lookup?ctx=en/middleware/standal
6768

6869
This table shows information regarding the machines that are part of a Coherence Cluster.
6970

70-
All attributes are from `Coherence:type=Platform,Domain=java.lang,subType=OperatingSystem` except for `Machine Name` which is from `NodeMBean` (`Coherence:type=Node`).
71+
All attributes are from `Coherence:type=Platform,Domain=java.lang,subType=OperatingSystem` except for `Machine Name` which is from `Node MBean` (`Coherence:type=Node`).
7172

7273
!===
7374
|**Column** | **Source / Comment**
@@ -86,7 +87,7 @@ See https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manag
8687

8788
This table shows information regarding all the members in a Coherence cluster.
8889

89-
All attributes are from `NodeMBean` (`Coherence:type=Node,nodeId=n`).
90+
All attributes are from `Node MBean` (`Coherence:type=Node,nodeId=n`).
9091

9192
!===
9293
|**Column** | **Source / Comment**
@@ -109,7 +110,7 @@ See https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manag
109110

110111
This table shows service summary information regarding all the services in a Coherence cluster.
111112

112-
All attributes are summarized from `ServiceMBean` (`Coherence:type=Service,name=serviceName`).
113+
All attributes are summarized from `Service MBean` (`Coherence:type=Service,name=serviceName`).
113114

114115
!===
115116
|**Column** | **Source / Comment**
@@ -131,7 +132,7 @@ See https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manag
131132

132133
This table shows service detail information regarding the selected service.
133134

134-
All attributes are from `ServiceMBean` for specific nodes. (`Coherence:type=Service,name=serviceName,nodeId=n`).
135+
All attributes are from `Service MBean` for specific nodes. (`Coherence:type=Service,name=serviceName,nodeId=n`).
135136

136137
!===
137138
|**Column** | **Source / Comment**
@@ -151,7 +152,7 @@ See https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manag
151152

152153
This table shows cache summary for all caches in a Coherence cluster.
153154

154-
All attributes are summarized from `CacheMBean` (`Coherence:type=CacheMBean,tier=back`).
155+
All attributes are summarized from `Cache MBean` (`Coherence:type=CacheMBean,tier=back`).
155156

156157
!===
157158
|**Column** | **Source / Comment**
@@ -171,7 +172,7 @@ See https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manag
171172
==== Cache Size and Access Details Table
172173
This table shows cache details regarding the selected cache.
173174

174-
All attributes are from `CacheMBean` (`Coherence:type=CacheMBean,tier=back`).
175+
All attributes are from `Cache MBean` (`Coherence:type=CacheMBean,tier=back`).
175176

176177
!===
177178
|**Column** | **Source / Comment**
@@ -190,14 +191,14 @@ See https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manag
190191
==== Front Cache Size and Access Details Table
191192
This table shows cache front details regarding the selected cache.
192193

193-
All attributes are from `CacheMBean` (`Coherence:type=CacheMBean,tier=front`) and are the same as the above table.
194+
All attributes are from `Cache MBean` (`Coherence:type=CacheMBean,tier=front`) and are the same as the above table.
194195

195196
[#CacheStorageManagerTableModel]
196197
=== Cache Storage Details
197198

198199
This table shows cache storage regarding the selected cache.
199200

200-
All attributes are from `StorageManager` (`Coherence:type=StorageManager,service=serviceName,cache=cacheName`).
201+
All attributes are from `StorageManager MBean` (`Coherence:type=StorageManager,service=serviceName,cache=cacheName`).
201202

202203
!===
203204
|**Column** | **Source / Comment**
@@ -221,7 +222,7 @@ See https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manag
221222

222223
This table shows federation summary details in a Coherence cluster.
223224

224-
All attributes are summarised from `DestinationMBean` and `OriginMBean` (Coherence:type=Federation,subType=Destination` and `Coherence:type=Federation,subType=Origin`).
225+
All attributes are summarised from `Destination MBean` and `Origin MBean` (Coherence:type=Federation,subType=Destination` and `Coherence:type=Federation,subType=Origin`).
225226

226227
!===
227228
|**Column** | **Source / Comment**
@@ -242,7 +243,7 @@ https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manage/or
242243

243244
This table shows federation outbound details for the selected service.
244245

245-
All attributes are from `DestinationMBean` (Coherence:type=Federation,subType=Destination`).
246+
All attributes are from `Destination MBean` (Coherence:type=Federation,subType=Destination`).
246247

247248
!===
248249
|**Column** | **Source / Comment**
@@ -263,7 +264,7 @@ See https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manag
263264

264265
This table shows federation inbound details for the selected service.
265266

266-
All attributes are from `OriginMBean` (Coherence:type=Federation,subType=Origin`).
267+
All attributes are from `Origin MBean` (Coherence:type=Federation,subType=Origin`).
267268

268269
!===
269270
|**Column** | **Source / Comment**
@@ -284,13 +285,13 @@ See https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manag
284285

285286
This table shows summary for proxy servers in a Coherence cluster.
286287

287-
All attributes are summarised from `ConnectionManagerMBean` where `Procotol=tcp` and `ConnectionMBean` (`Coherence:type=ConnectionManager` and `Coherence:type=Connection`).
288+
All attributes are summarised from `ConnectionManager MBean` where `Procotol=tcp` and `ConnectionMBean` (`Coherence:type=ConnectionManager` and `Coherence:type=Connection`).
288289

289290
!===
290291
|**Column** | **Source / Comment**
291292
|IP Address/Port | HostIP
292293
|Service Name | name (key)
293-
|Node Id | ndoeId (key)
294+
|Node Id | nodeId (key)
294295
|Connection Count | ConnectionCount
295296
|Outgoing Msg Backlog | OutgoingMessageBacklog
296297
|Total Bytes Rcv | TotalBytesReceived
@@ -302,12 +303,35 @@ All attributes are summarised from `ConnectionManagerMBean` where `Procotol=tcp`
302303
See https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manage/oracle-coherence-mbeans-reference.html#GUID-022FB1A1-F377-405A-A424-2CB1781330C1[ConnectionManagerMBean]
303304
or https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manage/oracle-coherence-mbeans-reference.html#GUID-F247B2A6-85A6-4F87-AD69-C0E184EF25D5[ConnectionMBean] documentation for more information.
304305

306+
[#ProxyConnectionsTableModel]
307+
=== Proxy Connections Table
308+
309+
This table shows summary for proxy connections servers in a Coherence cluster.
310+
311+
All attributes are summarised from `Connection MBean` (`Coherence:type=Connection`).
312+
313+
!===
314+
|**Column** | **Source / Comment**
315+
|UUID | UUID (key)
316+
|Connection ms | ConnectionTimeMillis
317+
|Connection Time | calculated
318+
|Connection Count | ConnectionCount
319+
|Remote Address | RemoteAddress : RemotePort
320+
|Data Sent | TotalBytesSent
321+
|Data Rec | TotalBytesReceived
322+
|Backlog| OutgoingByteBacklog
323+
|Client Process | ClientProcessName
324+
|Role | ClientRole
325+
!===
326+
327+
See https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manage/oracle-coherence-mbeans-reference.html#GUID-F247B2A6-85A6-4F87-AD69-C0E184EF25D5[ConnectionMBean] documentation for more information.
328+
305329
[#HttpProxyTableModel]
306330
=== Http Servers Table
307331

308332
This table shows summary for Http servers running in the Coherence cluster.
309333

310-
All attributes are summarised from `ConnectionManagerMBean` where `Procotol=http` (`Coherence:type=ConnectionManager`).
334+
All attributes are summarised from `ConnectionManager MBean` where `Procotol=http` (`Coherence:type=ConnectionManager`).
311335

312336
!===
313337
|**Column** | **Source / Comment**
@@ -327,7 +351,7 @@ See https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manag
327351

328352
This table shows Http server details for the selected Http server.
329353

330-
All attributes are from `ConnectionManagerMBean` where `Procotol=http` (`Coherence:type=ConnectionManager`).
354+
All attributes are from `ConnectionManager MBean` where `Procotol=http` (`Coherence:type=ConnectionManager`).
331355

332356
!===
333357
|**Column** | **Source / Comment**
@@ -346,8 +370,8 @@ See https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manag
346370

347371
This table shows Persistence summary for the Coherence cluster.
348372

349-
All attributes are summarized from `ServiceMBean` (`Coherence:type=Service,name=serviceName`) except for
350-
`Snapshot Count` and `Status` which are from `PersistenceMBean` (`Coherence:type=Persistence)`.
373+
All attributes are summarized from `Service MBean` (`Coherence:type=Service,name=serviceName`) except for
374+
`Snapshot Count` and `Status` which are from `Persistence MBean` (`Coherence:type=Persistence)`.
351375

352376
!===
353377
|**Column** | **Source / Comment**
@@ -370,7 +394,7 @@ https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manage/or
370394

371395
These tables show Elastic data summary for the Coherence cluster for either RAM or Flash Journal.
372396

373-
All attributes are from `RamJournalRM` or `FlashJournalRM` (`Coherence:type=Journal,name=FlashJournalRM` or `Coherence:type=Journal,name=RamJournalRM`).
397+
All attributes are from `RamJournalRM MBean` or `FlashJournalRM MBean` (`Coherence:type=Journal,name=FlashJournalRM` or `Coherence:type=Journal,name=RamJournalRM`).
374398

375399
!===
376400
|**Column** | **Source / Comment**
@@ -391,7 +415,7 @@ https://docs.oracle.com/en/middleware/standalone/coherence/14.1.1.2206/manage/or
391415

392416
This table shows health summary data for the Coherence cluster.
393417

394-
All attributes are summarised from `HeatlhMBean` (`Coherence:type=Health`).
418+
All attributes are summarised from `Heatlh MBean` (`Coherence:type=Health`).
395419

396420
!===
397421
|**Column** | **Source / Comment**
@@ -428,7 +452,7 @@ All attributes are summarised from `Coherence:type=GrpcNamedCacheProxy` MBean.
428452

429453
This table shows executor data for the Coherence cluster.
430454

431-
All attributes are summarised from `ExecutorMBean` (`Coherence:type=Executor`).
455+
All attributes are summarised from `Executor MBean` (`Coherence:type=Executor`).
432456

433457
!===
434458
|**Column** | **Source / Comment**

‎help/help_1212.adoc‎

Lines changed: 33 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ For the main Coherence VisualVM Plugin documentation please see https://github.c
3838
** <<CacheDetailTableModel, Cache Details Tables>>
3939
** <<CacheStorageManagerTableModel, Cache Storage Table>>
4040
* <<ProxyTableModel, Proxy Servers Table>>
41+
** <<ProxyConnectionsTableModel, Proxy Connections Table>>
4142
* <<ElasticData, Elastic Data Tables>>
4243
* <<HttpSessionTableModel, Http Session Table>>
4344
* <<JCacheConfigurationTableModel, JCache Tables>>
@@ -70,7 +71,7 @@ See https://docs.oracle.com/middleware/1212/coherence/COHMG/appendix_mbean.htm#C
7071

7172
This table shows information regarding all the members in a Coherence cluster.
7273

73-
All attributes are from `NodeMBean` (`Coherence:type=Node,nodeId=n`).
74+
All attributes are from `Node MBean` (`Coherence:type=Node,nodeId=n`).
7475

7576
!===
7677
|**Column** | **Source / Comment**
@@ -93,7 +94,7 @@ See https://docs.oracle.com/middleware/1212/coherence/COHMG/appendix_mbean.htm#C
9394

9495
This table shows service summary information regarding all the services in a Coherence cluster.
9596

96-
All attributes are summarized from `ServiceMBean` (`Coherence:type=Service,name=serviceName`).
97+
All attributes are summarized from `Service MBean` (`Coherence:type=Service,name=serviceName`).
9798

9899
!===
99100
|**Column** | **Source / Comment**
@@ -115,7 +116,7 @@ See https://docs.oracle.com/middleware/1212/coherence/COHMG/appendix_mbean.htm#C
115116

116117
This table shows service detail information regarding the selected service.
117118

118-
All attributes are from `ServiceMBean` for specific nodes. (`Coherence:type=Service,name=serviceName,nodeId=n`).
119+
All attributes are from `Service MBean` for specific nodes. (`Coherence:type=Service,name=serviceName,nodeId=n`).
119120

120121
!===
121122
|**Column** | **Source / Comment**
@@ -135,7 +136,7 @@ See https://docs.oracle.com/middleware/1212/coherence/COHMG/appendix_mbean.htm#C
135136

136137
This table shows cache summary for all caches in a Coherence cluster.
137138

138-
All attributes are summarized from `CacheMBean` (`Coherence:type=CacheMBean,tier=back`).
139+
All attributes are summarized from `Cache MBean` (`Coherence:type=CacheMBean,tier=back`).
139140

140141
!===
141142
|**Column** | **Source / Comment**
@@ -155,7 +156,7 @@ See https://docs.oracle.com/middleware/1212/coherence/COHMG/appendix_mbean.htm[C
155156
==== Cache Size and Access Details Table
156157
This table shows cache details regarding the selected cache.
157158

158-
All attributes are from `CacheMBean` (`Coherence:type=CacheMBean,tier=back`).
159+
All attributes are from `Cache MBean` (`Coherence:type=CacheMBean,tier=back`).
159160

160161
!===
161162
|**Column** | **Source / Comment**
@@ -174,7 +175,7 @@ See https://docs.oracle.com/middleware/1212/coherence/COHMG/appendix_mbean.htm[C
174175
==== Front Cache Size and Access Details Table
175176
This table shows cache front details regarding the selected cache.
176177

177-
All attributes are from `CacheMBean` (`Coherence:type=CacheMBean,tier=front`) and are the same as the above table.
178+
All attributes are from `Cache MBean` (`Coherence:type=CacheMBean,tier=front`) and are the same as the above table.
178179

179180
[#CacheStorageManagerTableModel]
180181
=== Cache Storage Details
@@ -205,13 +206,13 @@ See https://docs.oracle.com/middleware/1212/coherence/COHMG/appendix_mbean.htm#C
205206

206207
This table shows summary for proxy servers in a Coherence cluster.
207208

208-
All attributes are summarised from `ConnectionManagerMBean` where `Procotol=tcp` and `ConnectionMBean` (`Coherence:type=ConnectionManager` and `Coherence:type=Connection`).
209+
All attributes are summarised from `ConnectionManager MBean` where `Procotol=tcp` and `ConnectionMBean` (`Coherence:type=ConnectionManager` and `Coherence:type=Connection`).
209210

210211
!===
211212
|**Column** | **Source / Comment**
212213
|IP Address/Port | HostIP
213214
|Service Name | name (key)
214-
|Node Id | ndoeId (key)
215+
|Node Id | nodeId (key)
215216
|Connection Count | ConnectionCount
216217
|Outgoing Msg Backlog | OutgoingMessageBacklog
217218
|Total Bytes Rcv | TotalBytesReceived
@@ -223,12 +224,35 @@ All attributes are summarised from `ConnectionManagerMBean` where `Procotol=tcp`
223224
See https://docs.oracle.com/middleware/1212/coherence/COHMG/appendix_mbean.htm#CHDCIIIH[ConnectionManagerMBean]
224225
or https://docs.oracle.com/middleware/1212/coherence/COHMG/appendix_mbean.htm#CHDGBBEJ[ConnectionMBean] documentation for more information.
225226

227+
[#ProxyConnectionsTableModel]
228+
=== Proxy Connections Table
229+
230+
This table shows summary for proxy connections servers in a Coherence cluster.
231+
232+
All attributes are summarised from `Connection MBean` (`Coherence:type=Connection`).
233+
234+
!===
235+
|**Column** | **Source / Comment**
236+
|UUID | UUID (key)
237+
|Connection ms | ConnectionTimeMillis
238+
|Connection Time | calculated
239+
|Connection Count | ConnectionCount
240+
|Remote Address | RemoteAddress : RemotePort
241+
|Data Sent | TotalBytesSent
242+
|Data Rec | TotalBytesReceived
243+
|Backlog| OutgoingByteBacklog
244+
|Client Process | ClientProcessName
245+
|Role | ClientRole
246+
!===
247+
248+
See https://docs.oracle.com/middleware/1212/coherence/COHMG/appendix_mbean.htm#CHDGBBEJ[ConnectionMBean] documentation for more information.
249+
226250
[#ElasticData]
227251
=== Elastic Data Tables
228252

229253
These tables show Elastic data summary for the Coherence cluster for either RAM or Flash Journal.
230254

231-
All attributes are from `RamJournalRM` or `FlashJournalRM` (`Coherence:type=Journal,name=FlashJournalRM` or `Coherence:type=Journal,name=RamJournalRM`).
255+
All attributes are from `RamJournalRM MBean` or `FlashJournalRM MBean` (`Coherence:type=Journal,name=FlashJournalRM` or `Coherence:type=Journal,name=RamJournalRM`).
232256

233257
!===
234258
|**Column** | **Source / Comment**

0 commit comments

Comments
 (0)