Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to ensure an isNone value isn't 'replaced' with another isNone value #71

Closed
dgeb opened this issue Nov 11, 2014 · 3 comments
Closed

Add tests to ensure an isNone value isn't 'replaced' with another isNone value #71

dgeb opened this issue Nov 11, 2014 · 3 comments

Comments

@dgeb
Copy link
Member

dgeb commented Nov 11, 2014

See #70
@dgeb dgeb changed the title Add tests for #70 Add tests to ensure an isNone value isn't 'replaced' with another isNone value Nov 11, 2014
@dgeb dgeb mentioned this issue Nov 11, 2014
Merged
@chrisyunker
Copy link
Contributor

I added this test: #73.
It checks for the infinite loop caused by this bug in a 2 source, bi-directional connected system (which causes a timeout). Let me know if you need something more precise.

@dgeb
Copy link
Member Author

dgeb commented Nov 12, 2014

@chrisyunker that's great - thanks!

I merged your tests and tried to clarify the conditionals in that method a bit further.

@dgeb dgeb closed this as completed Nov 12, 2014
@chrisyunker
Copy link
Contributor

Looks great, thanks for the quick turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisyunker @dgeb