Cloud Posse
Issue with github-action-atmos-affected-trigger-spacelift Not Triggering Affected Stacks
#32
-
ContextWe’ve encountered an issue with the Initial setupOur workflow was configured as follows: name: "Deploy Affected Spacelift Stacks"
on:
pull_request:
types: [closed]
branches:
- main
jobs:
run:
if: github.event.pull_request.merged == true
runs-on:
group: vnext
steps:
- name: Atmos Affected Stacks Trigger Spacelift
uses: cloudposse/github-action-atmos-affected-trigger-spacelift@v2
with:
atmos-config-path: ./rootfs/usr/local/etc/atmos
deploy: true
github-token: ${{ secrets.GITHUB_TOKEN }}
head-ref: ${{ github.sha }}~1
install-jq: true
jq-version: 1.7
atmos-version: 1.153.0The error we encountered indicates that the action is not detecting any affected stacks:
Summary of Discussionhttps://sweetops.slack.com/archives/C0313BVSVQD/p1738773568526219 Trigger vs. Head Ref:
Impact of Atmos Changes:
Action Versioning:
Long-Term Resolution:
|
Beta Was this translation helpful? Give feedback.
Replies: 4 comments 5 replies
-
Atmos Version BehaviorIn older Atmos versions the command |
Beta Was this translation helpful? Give feedback.
-
Workaround with
|
Beta Was this translation helpful? Give feedback.
-
Head Ref Issue with Squash CommitsOur configuration uses squash commits. Using |
Beta Was this translation helpful? Give feedback.
-
SolutionThe problem is a conflict between where the workflow is called and what we're setting as What we have above is triggered on Change the trigger to on pushes to Alternatively, we should keep the trigger for on You can also use |
Beta Was this translation helpful? Give feedback.
-
|
@milldr I updated our workflow to use this solution and was greeted with: Warning: Unexpected input(s) 'base-ref', valid inputs are ['atmos-config-path', 'atmos-version', 'default-branch', 'deploy', 'github-token', 'head-ref', 'install-atmos', 'install-jq', 'install-spacectl', 'install-terraform', 'jq-force', 'jq-version', 'spacectl-version', 'spacelift-api-key-id', 'spacelift-api-key-secret', 'spacelift-endpoint', 'terraform-version', 'trigger-method', 'skip-atmos-functions']Would the advisable solution be to adjust the trigger to be on pushes to main with the |
Beta Was this translation helpful? Give feedback.
-
|
Yes that's my mistake. base-ref is not necessary. It's discovered in the nested action, cloudposse/github-action-atmos-affected-stacks |
Beta Was this translation helpful? Give feedback.
-
No because this is a Spacelift trigger. In order to trigger spacelift, we add a comment to the PR -- which Spacelift monitors. Therefore it has to be triggered on the PR event. Does this below solve your issue? (1) trigger on PR, (2) set head-ref, (3) remove base-ref and skip-atmos-functions name: "Deploy Affected Spacelift Stacks"
on:
pull_request:
types: [closed]
branches:
- main
jobs:
run:
if: github.event.pull_request.merged == true
runs-on: ["self-hosted", "default"]
steps:
- name: Atmos Affected Stacks Trigger Spacelift
uses: cloudposse/github-action-atmos-affected-trigger-spacelift@v2
with:
atmos-config-path: ./rootfs/usr/local/etc/atmos
deploy: true
github-token: ${{ secrets.GITHUB_TOKEN }}
head-ref: ${{ github.event.pull_request.head.sha }} |
Beta Was this translation helpful? Give feedback.
-
|
We had a misunderstanding with the git references and further discussed this in Slack. Following up here for any future reference: The issue is that by the time the PR has merged, the sha of the main branch (base-ref) has been updated, so we're comparing the wrong diff. Instead, we need to get the previous sha of the main branch, but since the workflow is running on the PR we need to first fetch the history of the base ref. Here's the solution: name: "Deploy Affected Spacelift Stacks"
on:
pull_request:
types: [closed]
branches:
- main
jobs:
run:
if: github.event.pull_request.merged == true
runs-on: ["self-hosted", "default"]
steps:
- name: Checkout repository with extra history
uses: actions/checkout@v3
with:
fetch-depth: 0
# We want to use 1 previous commit from the base branch SHA
# This is because by the time this workflow runs, the PR branch has already been merged.
# It's critical to use the base branch SHA to get the correct changes, not the previous commit from the PR branch.
- name: Determine previous commit on base branch
id: get_parent
shell: bash
run: |
# For squash merges, github.event.pull_request.base.sha represents the state of the base branch
# when the PR was created (or last updated). This may be stale compared to the actual commit
# on the main branch at the time of the merge. Using 'HEAD~1' after the merge ensures we get
# the commit that was the tip of main immediately before the squash merge commit was added.
echo "Merge commit: $(git rev-parse HEAD)"
PARENT=$(git rev-parse HEAD~1)
echo "Parent (base) commit: $PARENT"
echo "parent_commit=$PARENT" >> "$GITHUB_OUTPUT"
- name: Atmos Affected Stacks Trigger Spacelift
uses: cloudposse/github-action-atmos-affected-trigger-spacelift@v2
with:
atmos-config-path: ./rootfs/usr/local/etc/atmos
deploy: true
github-token: ${{ secrets.GITHUB_TOKEN }}
skip-atmos-functions: "true"
head-ref: ${{ steps.get_parent.outputs.parent_commit }} |
Beta Was this translation helpful? Give feedback.
We had a misunderstanding with the git references and further discussed this in Slack. Following up here for any future reference:
The issue is that by the time the PR has merged, the sha of the main branch (base-ref) has been updated, so we're comparing the wrong diff. Instead, we need to get the previous sha of the main branch, but since the workflow is running on the PR we need to first fetch the history of the base ref.
Here's the solution: