-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce dedicated types for reporters #10028
Comments
This to me seems purely a UI requirement in ORT server, and may change. |
While triggered by ORT Server related UI questions, I also see value for the ORT CLI (which also is a UI) in this feature. For example,
I disagree here. The type of a report is an inherent feature of the report itself. Any UI (CLI and ORT Server) should use the same type for a report, because a specific report format knows best what type it is. As such, the type should be implemented as part of the reporter API in ORT (core). |
The problem with this are custom plugins and template reports where the type cannot be known ahead of time. The latter is a challenge for the implementation because it requires a way to set the type of the report when generating it, maybe from within the template, and to make it available programmatically, so that the CLI or any other tool like the server can show it. |
Hm, I still believe how ORT server's UI groups things is out-of-scope of the ORT project. Would it make sense to do this with a labeling mechanism? key-value-pairs associated with plugins, which ORT does not know how to interpret. Such as If such labels could be additionally (to the hard-coding) be configured in |
What about
|
Not liking INTERNAL_USE enum as WebApp and EvaluatedModel are shared between parties (know 3 users that share them external) and several tools use EvaluatedModel as input such as Hermine project see their Uploading a BOM file doc. |
Then please make constructive proposals for other names. |
While designing the UI to download reports from ORT Server, the topic came up what an appropriate grouping of reports could be. Currently, the ORT Server only has "SBOMs" and "Other" groups, but this categorization could be more fine-granular, and provide more information about the intended use or target audience.
Thus the idea came up to introduce a dedicated
ReporterType
enum. As reporters are plugins and we'll never be able to offer proper types for all (third-party) reports, there certainly needs to be anOTHER
enum entry. But what else should we have to start with? (We can always add more distinct types later.)The current proposal would be
(I believe to have captured all our current reports in the above categorization.)
The text was updated successfully, but these errors were encountered: