Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardize translation method #2

Closed
Rakesh-Ranga-Buram opened this issue Sep 9, 2024 · 1 comment
Closed

standardize translation method #2

Rakesh-Ranga-Buram opened this issue Sep 9, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@Rakesh-Ranga-Buram
Copy link
Collaborator

Rakesh-Ranga-Buram commented Sep 9, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
In many places OED uses translate() and in some it uses FormatMessage(). They both appear to return a string.

Describe the solution you'd like
OED should pick the better of these two and use it consistently in the code. Maybe research the two and propose one to the project. Then make the needed edits once everyone agrees.

Describe alternatives you've considered
Leave as is

Additional context
None
@Rakesh-Ranga-Buram Rakesh-Ranga-Buram added the good first issue Good for newcomers label Sep 9, 2024
@Rakesh-Ranga-Buram
Copy link
Collaborator Author

Tracked in upstream, OpenEnergyDashboard#1205

kungfuchicken pushed a commit that referenced this issue Jan 31, 2025
@shankarp05
Merge pull request #2 from aravindb24/shankar
aef734f 
Shankar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rakesh-Ranga-Buram