Identify any redundancy within existing code

[cheezyrock]

There are spots in the code which are redundant. For example, there are multiple times a database connection is opened, whereas we should probably have only one method that is responsible for opening and closing the database. Each of these identifications will lead to additional issues created.

[hollowtree11]

The first redundancy I see in postgres_connector.py is the try/catch/except blocks that come up in nearly the same structure in every function as follows:
try:
with self.connection.cursor() as cur:
cur.execute(sql, (function_id,))
result = cur.fetchall()
except Exception:
self.connection.rollback()
result = None
finally:
if cur:
cur.close()
To handle this, we could create a try_query function that takes an SQL statement and handles the execution of the statement and error handling within it.

[hollowtree11]

Another redundancy I notice in postgres_connector.py is that the code often manually converts rows into Python dictionaries instead of using DictCursor like is used in get_system. The manual conversion is shown as follows:
column_names = [desc[0] for desc in cur.description]
result = [dict(zip(column_names, row)) for row in rows]
and the use of DictCursor in get_system is as follows:
cursor_factory=psycopg2.extras.DictCursor
) as cur:
cur.execute(sql, (ip,))
temp = cur.fetchone()
Changing this conversion would eliminate many lines of unnecessary code in postgres_connector.py.

[DylAstralith]

Redundancy found in DataTable.js. It seems like DataTable.js was deprecated and replaced by PaginatedDataTable.js. Both files work similarly, rendering an HTML table. But DataTable.js seemed to be a WIP, as it used a mock pagination unlike PaginatedDataTable.js.

[DylAstralith]

Redundancy found InfoTable2.js, and InfoTable3.js. Just like before, it seems these two files are deprecated . They've been replaced by a single InfoTable.js which is called by SystemDetails.js. It also seems like the "rational twists" tab was defined in InfoTable2.js, but was moved to a separate file (RationalTwistsTable.js).

[DylAstralith]

Redundancy found in MultiplierInvariantsTable.js. Not sure if this has been deprecated or if it is an unfinished feature. Seems like this was suppose to outline multiplier invariants for each function in the function details page. The data it displays is hardcoded. Additionally, it exports the function InfoTable(), which is the same name as the exported function in InfoTable.js.

[DylAstralith]

Redundancy found in PaginatedDataTables.js, ModelsTable.js, and FunctionAttributes.js. All three files have a different way of rendering exponents on the webpage. It would be best to separate renderExponent() into its own file that is called by the forementioned files.