Skip to content

Commit 44a7db9

Browse files
committed
fix: resolution: only add resolver as task.resolver_usernames if used admin privileges
Signed-off-by: Romain Beuque <[email protected]>
1 parent 8f364dd commit 44a7db9

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

api/handler/resolution.go

+6-4
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,12 @@ func CreateResolution(c *gin.Context, in *createResolutionIn) (*resolution.Resol
5757

5858
// adding current resolver to task.resolver_usernames, to be able to list resolved tasks
5959
// as 'resolvable', if current resolver used admins privileges.
60-
t.ResolverUsernames = append(t.ResolverUsernames, resUser)
61-
if err := t.Update(dbp, false, false); err != nil {
62-
dbp.Rollback()
63-
return nil, err
60+
if auth.IsAdmin(c) == nil {
61+
t.ResolverUsernames = append(t.ResolverUsernames, resUser)
62+
if err := t.Update(dbp, false, false); err != nil {
63+
dbp.Rollback()
64+
return nil, err
65+
}
6466
}
6567

6668
r, err := resolution.Create(dbp, t, in.ResolverInputs, resUser, false, nil) // TODO accept delay in handler

0 commit comments

Comments
 (0)