Skip to content

Permission to incorporate this code into other packages #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
staticfloat opened this issue Dec 15, 2016 · 4 comments
Open

Permission to incorporate this code into other packages #1

staticfloat opened this issue Dec 15, 2016 · 4 comments

Comments

@staticfloat
Copy link

Hey there @oyd11. Would you give permission for me to include this lpc_burg function in a more general package, such as DSP.jl? I think it would be very useful alongside other spectral estimation methods I'm planning on contributing to that package.

@oyd11
Copy link
Owner

oyd11 commented Dec 16, 2016

Sounds great, so firstly - go ahead!

I also meant to add more spectral estimation methods (and documentation and tests for this one) [ specifically - there's a spectral-reassignment method I've implemented and not uploaded yet, and a filter-design pack ]

@oyd11
Copy link
Owner

oyd11 commented Dec 16, 2016

So @staticfloat : when you actually do that - let me know, so that I'll make any updates / tests etc on a fork of DSP.jl or wherever you end up incorporating these functions into, thanks!

@staticfloat
Copy link
Author

staticfloat commented May 10, 2017

@oyd11 A cool 5 months later, I've actually opened a pull request, as you can see linked above.

@oyd11
Copy link
Owner

oyd11 commented May 13, 2017

thanks @staticfloat ! I'll join and monitor the package discussion, add relevant tests there, it'll be great seeing this refactored into the DSP package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants