Fix segmentation failure in ConstantTypeSubstitution #5271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Still <[email protected]>
Signed-off-by: Vladimir Still <[email protected]>
vlstill
added
the
core
|
@vlstill Looks like test is failing? |
|
Is the test supposed to fail? If so it should be in the p4_16_errors directory. In any case it needs expected outputs as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5268.
As the
getType(..., true)should fail with aBUG, I don't think we need to add anything more than just a check for the type being null. In the example from issue, there is a preceding type error which supresses theBUG_CHECKabout unknown type (as the type map is possibly inconsistent due to previous errors).