Client: throw Exception if empty auth is set

Author: glaubinix

src/HttpClient/Plugin/RequestSignature.php

@@ -27,6 +27,10 @@ class RequestSignature implements Plugin
      */
     public function __construct($token, $secret)
     {
+        if (!$token || !$secret) {
+            throw new \InvalidArgumentException('$token and $secret must be set');
+        }
+
         $this->token = $token;
         $this->secret = $secret;
     }

tests/HttpClient/Plugin/RequestSignatureTest.php

@@ -65,4 +65,23 @@ public function testPrefixRequestPathSmoke()
 
         $this->assertNotNull($promise->wait(true)->getHeader('Authorization')[0]);
     }
+
+    /**
+     * @dataProvider tokenSecretProvider
+     */
+    public function testMissingTokenOrSecret(string $token, string $secret): void
+    {
+        $this->expectException(\InvalidArgumentException::class);
+
+        new RequestSignature($token, $secret);
+    }
+
+    public function tokenSecretProvider(): array
+    {
+        return [
+            ['', ''],
+            ['token', ''],
+            ['', 'secret'],
+        ];
+    }
 }