Skip to content

Commit 6e512a8

Browse files
committed
chore: node 24 fails of dry-run publish over existing version
1 parent 36b0e4d commit 6e512a8

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

.github/workflows/build-and-test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,11 +181,11 @@ jobs:
181181

182182
- if: ${{ matrix.docker == true && matrix.alpine == true && matrix.arch == 'amd64' && matrix.os == 'ubuntu-latest' }}
183183
name: test linux amd64 musl
184-
run: docker run -v $PWD:/home --platform linux/${{ matrix.arch }} --rm node:${{ matrix.node-version }}-alpine bin/sh -c 'apk add jq gettext-envsubst bash curl gcompat file && cd /home && /home/script/ci/unpack-and-test.sh'
184+
run: docker run -v $PWD:/home -e NODE_VERSION=${{ matrix.node-version }} --platform linux/${{ matrix.arch }} --rm node:${{ matrix.node-version }}-alpine bin/sh -c 'apk add jq gettext-envsubst bash curl gcompat file && cd /home && /home/script/ci/unpack-and-test.sh'
185185

186186
- if: ${{ matrix.docker == true && matrix.alpine == true && matrix.arch == 'arm64' && matrix.os == 'ubuntu-24.04-arm' }}
187187
name: test linux arm64 musl
188-
run: docker run -v $PWD:/home --platform linux/${{ matrix.arch }} --rm node:${{ matrix.node-version }}-alpine bin/sh -c 'apk add jq gettext-envsubst bash curl file protoc protobuf-dev && cd /home && /home/script/ci/unpack-and-test.sh'
188+
run: docker run -v $PWD:/home -e NODE_VERSION=${{ matrix.node-version }} --platform linux/${{ matrix.arch }} --rm node:${{ matrix.node-version }}-alpine bin/sh -c 'apk add jq gettext-envsubst bash curl file protoc protobuf-dev && cd /home && /home/script/ci/unpack-and-test.sh'
189189

190190
release_dry_run:
191191
runs-on: ubuntu-latest

script/ci/build-opt-dependencies.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,11 @@ build() {
7070
if [ "${PUBLISH:-false}" = true ]; then
7171
(cd $node_pkg && npm publish --access public)
7272
else
73-
(cd $node_pkg && npm publish --access public --dry-run)
73+
if [ "${NODE_VERSION:-0}" -ge 24 ] 2>/dev/null; then
74+
(cd "$node_pkg" && npm publish --access public --dry-run) || true
75+
else
76+
(cd $node_pkg && npm publish --access public --dry-run)
77+
fi
7478
fi
7579
done
7680
}

0 commit comments

Comments
 (0)