Skip to content

Conversation

@star1327p
Copy link
Contributor

Correct more typos in code comments.

Continued from #63042.

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

num_format_str : optional number format string
"""
# Create a XlsxWriter format object.
# Create an XlsxWriter format object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this one is wrong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbrockmendel Yes, "an xlsx" is the correct usage. Even Adobe writes "an xlsx" on their official website.

https://www.adobe.com/uk/acrobat/resources/document-files/spreadsheet-files/xls.html

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general rule is to use "an" when the starting sound of the word is a vowel. Here, that sound is "Ex".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants