Move quicksilver-pushback to require and not require-dev (#41)

* Moving pantheon-systems/quicksilver-pushback to require

* Adding readme todo

* Add missing quotes to Quicksilver Pushback

* Adding section on require vs require-dev to readme.

* Moving quicksilver-pushback to require again after botched merge

* Testing Quicksilver Pushback

* Delete test file

Author: stevector

README.md

@@ -60,7 +60,7 @@ Even within the `/web` directory you may notice that other directories and files
 
 #### `composer.json`
 
-If you are just browsing this repository on GitHub, you may not see some of the directories mentioned above like `wp-admin`. That is because WordPress core and its plugins are installed via Composer and ignored in the `.gitignore` file. Specific plugins are added to the project via `composer.json` and `composer.lock` keeps track of the exact version of each plugin (or other dependency). Generic Composer dependencies (not WordPress plugins or themes) are downloaded to the `/vendor` folder.
+If you are just browsing this repository on GitHub, you may not see some of the directories mentioned above like `wp-admin`. That is because WordPress core and its plugins are installed via Composer and ignored in the `.gitignore` file. Specific plugins are added to the project via `composer.json` and `composer.lock` keeps track of the exact version of each plugin (or other dependency). Generic Composer dependencies (not WordPress plugins or themes) are downloaded to the `/vendor` folder. Use the `require` section for any dependencies you wish to push to Pantheon, even those that might only be used on non-Live environments. Dependencies added in `require-dev` such as `php_codesniffer` or `phpunit` will not be pushed to Pantheon by the CI scripts.
 
 ## Behat tests
 

composer.json

@@ -17,13 +17,14 @@
   ],
   "require": {
     "composer/installers": "^1.3.0",
-    "vlucas/phpdotenv": "^2.4.0",
-    "wpackagist-plugin/wp-native-php-sessions": "^0.6.0",
-    "wpackagist-plugin/pantheon-advanced-page-cache": "^0.1.4",
-    "wpackagist-theme/twentyseventeen": "^1.1",
+    "pantheon-systems/quicksilver-pushback": "^1.0",
     "pantheon-systems/wordpress-composer": "^4.8.2",
     "roots/wp-password-bcrypt": "^1.0.0",
-    "rvtraveller/qs-composer-installer": "^1.1"
+    "rvtraveller/qs-composer-installer": "^1.1",
+    "vlucas/phpdotenv": "^2.4.0",
+    "wpackagist-plugin/pantheon-advanced-page-cache": "^0.1.4",
+    "wpackagist-plugin/wp-native-php-sessions": "^0.6.0",
+    "wpackagist-theme/twentyseventeen": "^1.1"
   },
   "require-dev": {
     "roave/security-advisories": "dev-master",
@@ -33,8 +34,7 @@
     "squizlabs/php_codesniffer": "^2.9.0",
     "wp-coding-standards/wpcs": "dev-master",
     "phpunit/phpunit": "^6.1",
-    "brain/monkey": "^1.4",
-    "pantheon-systems/quicksilver-pushback": "~1"
+    "brain/monkey": "^1.4"
   },
   "config": {
     "vendor-dir": "vendor",

composer.lock

@@ -15,5 +15,5 @@ workflows:
   sync_code:
     after:
       - type: webphp
-        description: Push changes back to GitHub if needed
+        description: 'Push changes back to GitHub if needed'
         script: private/scripts/quicksilver/quicksilver-pushback/push-back-to-github.php