Merge pull request #254 from parallaxinc/cleardown

phated · phated · commit 32d4c72d3bc8 · 2015-09-09T16:43:36.000-07:00
Improve clear-down to avoid accidental scrolling
diff --git a/src/lib/terminal.js b/src/lib/terminal.js
@@ -103,8 +103,7 @@ class Terminal {
 
   clearBelow(){
     const { lines, pointerLine } = this.state;
-    const newLines = lines.slice(0, Math.min(pointerLine + 1, lines.length));
-    this.state.lines = newLines;
+    _.fill(lines, '', pointerLine + 1, lines.length);
   }
 
   tab(){

Original file line number	Diff line number	Diff line change
`@@ -103,8 +103,7 @@ class Terminal {`
`103`	`103`
`104`	`104`	`clearBelow(){`
`105`	`105`	`const { lines, pointerLine } = this.state;`
`106`		`- const newLines = lines.slice(0, Math.min(pointerLine + 1, lines.length));`
`107`		`- this.state.lines = newLines;`
	`106`	`+ _.fill(lines, '', pointerLine + 1, lines.length);`
`108`	`107`	`}`
`109`	`108`
`110`	`109`	`tab(){`