Skip to content

Commit d5cbba1

Browse files
committed
Merge pull request #246 from parallaxinc/search-messages
Added search status bar
2 parents 1fdde65 + a06c1a3 commit d5cbba1

File tree

3 files changed

+30
-3
lines changed

3 files changed

+30
-3
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
},
99
"dependencies": {
1010
"@phated/redux-create-store": "^0.3.0",
11-
"bs2-serial": "^0.11.0",
11+
"bs2-serial": "^0.12.0",
1212
"codemirror": "^4.13.0",
1313
"frylord": "^0.7.1",
1414
"holovisor": "^0.2.0",

src/plugins/handlers.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,8 @@ function handlers(app, opts, done){
524524
function selectDevice(device) {
525525
const { content } = workspace.getState();
526526

527-
if(!device.match) {
527+
// need to make sure we have all the information before rewriting the source
528+
if(!device.match && device.name && device.program) {
528529
const { name } = device;
529530
// TODO: handle unnamed device
530531
const { TargetStart } = device.program.raw;

src/views/download-overlay.js

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,17 @@ const ProgressBar = require('../components/progress-bar');
1313

1414
const styles = {
1515
overlay: {
16-
paddingBottom: 40
16+
paddingBottom: 40,
17+
width: 600
1718
},
1819
overlayFooter: {
1920
marginLeft: 0,
2021
display: 'flex'
2122
},
23+
errorSpan: {
24+
color: '#FF0000',
25+
display: 'inline-block'
26+
},
2227
deviceTable: {
2328
width: '100%',
2429
maxWidth: '100%',
@@ -39,6 +44,25 @@ const styles = {
3944
verticalAlign: 'top',
4045
borderTop: '1px solid #ddd'
4146
},
47+
statusTh: {
48+
padding: '8px 8px 8px 0',
49+
textAlign: 'left',
50+
borderTop: 0,
51+
borderBottom: '2px solid #ddd',
52+
verticalAlign: 'bottom',
53+
fontWeight: 'bold',
54+
maxWidth: 160
55+
},
56+
statusTd: {
57+
padding: '8px 8px 8px 0',
58+
borderSpacing: 'collapse',
59+
verticalAlign: 'top',
60+
borderTop: '1px solid #ddd',
61+
maxWidth: 160,
62+
overflow: 'auto',
63+
whiteSpace: 'nowrap',
64+
color: '#333333'
65+
},
4266
scrollingContainer: {
4367
height: 325,
4468
overflow: 'auto',
@@ -94,6 +118,7 @@ class DownloadOverlay extends React.Component {
94118
<td style={styles.deviceTd}>{device.name}</td>
95119
<td style={styles.deviceTd}>{device.version}</td>
96120
<td style={styles.deviceTd}>{device.path}</td>
121+
<td style={styles.statusTd}>{device.displayError}</td>
97122
</tr>
98123
);
99124
}
@@ -136,6 +161,7 @@ class DownloadOverlay extends React.Component {
136161
<th style={styles.deviceTh}>Device</th>
137162
<th style={styles.deviceTh}>Version</th>
138163
<th style={styles.deviceTh}>Port</th>
164+
<th style={styles.statusTh}>Status</th>
139165
</tr>
140166
</thead>
141167
<tbody>

0 commit comments

Comments
 (0)