Skip to content

Commit f8fd8b8

Browse files
PhucVH888PhucVH888
committed
Fixed forward in closure and added tests
1 parent 5f98535 commit f8fd8b8

19 files changed

+267
-78
lines changed

‎src/back/CodeGen/Closure.hs

+10-6
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,13 @@ translateClosure closure typeVars table
4343
params = A.eparams closure
4444
body = A.body closure
4545
id = Meta.getMetaId . A.getMeta $ closure
46+
idAsync = id ++ "_async"
4647
funName = closureFunName id
48+
funNameAsync = closureFunName idAsync
4749
nameForwarding = forwardingClosureImplName $ (ID.Name . show) funName
4850
envName = closureEnvName id
4951
traceName = closureTraceName id
52+
traceNameAsync = closureTraceName idAsync
5053
boundVars = map (ID.qName . show . A.pname) params
5154
freeVars = map (first ID.qnlocal) $
5255
filter (ID.isLocalQName . fst) $
@@ -79,7 +82,7 @@ translateClosure closure typeVars table
7982
,returnStmnt bodyName resultType]
8083
)
8184
forwardingClosureImpl =
82-
Function (Static $ Typ "value_t") funName
85+
Function (Static $ Typ "value_t") funNameAsync
8386
[(Ptr (Ptr encoreCtxT), encoreCtxVar),
8487
(Ptr (Ptr ponyTypeT), encoreRuntimeType),
8588
(Typ "value_t", Var "_args[]"),
@@ -92,12 +95,13 @@ translateClosure closure typeVars table
9295
,dtraceClosureExit
9396
,returnStmnt forwardingBodyName unitType])
9497
in
95-
Concat $ [buildEnvironmentForward envName freeVars fTypeVars] ++
98+
Concat $ [buildEnvironmentForward envName freeVars fTypeVars] ++
99+
[tracefunDecl traceName envName freeVars fTypeVars extractEnvironment,
100+
normalClosureImpl] ++
96101
if null $ Util.filter A.isForward body
97-
then [tracefunDecl traceName envName freeVars fTypeVars extractEnvironment,
98-
normalClosureImpl]
99-
else [tracefunDecl traceName envName freeVars fTypeVars extractEnvironmentForward,
100-
forwardingClosureImpl]
102+
then []
103+
else [tracefunDecl traceNameAsync envName freeVars fTypeVars extractEnvironmentForward,
104+
forwardingClosureImpl]
101105
| otherwise =
102106
error
103107
"Tried to translate a closure from something that was not a closure"

‎src/back/CodeGen/Expr.hs

+47-32
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ instance Translatable A.Expr (State Ctx.Context (CCode Lval, CCode Stat)) where
221221
let string = head args
222222
rest = tail args
223223
unless (Ty.isStringType $ A.getType string) $
224-
error "Expr.hs: Print expects first argument to be a string literal"
224+
error $ "Expr.hs: Print expects first argument to be a string literal"
225225
targs <- mapM translate rest
226226
let argNames = map (AsExpr . fst) targs
227227
argDecls = map snd targs
@@ -1036,7 +1036,8 @@ instance Translatable A.Expr (State Ctx.Context (CCode Lval, CCode Stat)) where
10361036
If futVar
10371037
(Seq $ initArgs ++ [Statement forwardingCall])
10381038
(Seq $ initArgs1 ++ [Statement oneWayMsg])] ++
1039-
result)
1039+
result
1040+
)
10401041
else do
10411042
(sendn, sendt) <- translate A.MessageSend{A.emeta
10421043
,A.target
@@ -1063,18 +1064,19 @@ instance Translatable A.Expr (State Ctx.Context (CCode Lval, CCode Stat)) where
10631064
isAsyncForward <- gets Ctx.isAsyncForward
10641065
let ty = getRuntimeType chain
10651066
dtraceExit = getDtraceExit eCtx
1066-
result =
1067-
case eCtx of
1068-
Ctx.ClosureContext clos -> []
1069-
_ -> [dtraceExit, Return Skip]
1067+
result = case eCtx of
1068+
Ctx.ClosureContext clos -> []
1069+
_ -> [dtraceExit, Return Skip]
10701070
futureChain =
10711071
if Util.isForwardInExpr chain
1072-
then
1073-
Call futureChainActor
1074-
[AsExpr encoreCtxVar, AsExpr nfuture, ty, AsExpr nchain]
1075-
else
1076-
Call futureChainWithFut
1077-
[AsExpr encoreCtxVar, AsExpr nfuture, ty, AsExpr nchain, AsExpr futVar]
1072+
then Call futureChainActor
1073+
[AsExpr encoreCtxVar, AsExpr nfuture, ty, AsExpr nchain]
1074+
else Call futureChainWithFut
1075+
[AsExpr encoreCtxVar, AsExpr nfuture, ty, AsExpr nchain
1076+
,AsExpr futVar, AsExpr $ AsLval $ Nam "false"]
1077+
when (A.isVarAccess chain) $
1078+
unless (A.isIdClosure chain) $
1079+
error $ "Expr.hs: The closure that contains forward must be defined in chain."
10781080
if isAsyncForward
10791081
then do
10801082
return (unit, Seq $
@@ -1150,15 +1152,21 @@ instance Translatable A.Expr (State Ctx.Context (CCode Lval, CCode Stat)) where
11501152
(nfuture,tfuture) <- translate future
11511153
(nchain, tchain) <- translate chain
11521154
result <- Ctx.genSym
1155+
isAsyncForward <- gets Ctx.isAsyncForward
11531156
let ty = getRuntimeType chain
11541157
return $ (Var result,
11551158
Seq $ [tfuture,
11561159
tchain,
1157-
(Assign (Decl (C.future, Var result))
1158-
(Call futureChainActor
1159-
[AsExpr encoreCtxVar, AsExpr nfuture, ty, AsExpr nchain]
1160-
))] ++
1161-
if (Util.isForwardInExpr chain) then [assignVar futNam (Nam result)]
1160+
if (Util.isForwardInExpr chain && isAsyncForward)
1161+
then Statement $
1162+
(Call futureChainWithFut
1163+
[AsExpr encoreCtxVar, AsExpr nfuture, ty, AsExpr nchain,
1164+
AsExpr ((Deref envName) `Dot` futNam), AsExpr $ AsLval $ Nam "true"])
1165+
else Assign (Decl (C.future, Var result))
1166+
(Call futureChainActor [AsExpr encoreCtxVar, AsExpr nfuture, ty, AsExpr nchain])
1167+
] ++
1168+
if (Util.isForwardInExpr chain && isAsyncForward)
1169+
then [assignVar futNam (Decl (C.future, Var result))]
11621170
else [])
11631171
where
11641172
metaId = Meta.getMetaId . A.getMeta $ chain
@@ -1167,31 +1175,38 @@ instance Translatable A.Expr (State Ctx.Context (CCode Lval, CCode Stat)) where
11671175

11681176
translate clos@(A.Closure{A.eparams, A.body}) = do
11691177
tmp <- Ctx.genSym
1170-
fut <- Ctx.genNamedSym "fut"
1178+
futClos <- Ctx.genNamedSym "fut_closure"
11711179
globalFunctionNames <- gets Ctx.getGlobalFunctionNames
11721180
isAsyncForward <- gets Ctx.isAsyncForward
11731181
let bound = map (ID.qLocal . A.pname) eparams
11741182
freeVars = filter (ID.isLocalQName . fst) $
11751183
Util.freeVariables bound body
11761184
ty = runtimeType . A.getType $ body
1177-
futArg = if isAsyncForward
1178-
then futVar
1179-
else (Var fut)
11801185
fillEnv <- insertAllVars freeVars fTypeVars
11811186
return
11821187
(Var tmp,
1183-
Seq $
1184-
mkEnv envName : fillEnv ++
1185-
(if isAsyncForward || (not $ Util.isForwardInExpr body)
1186-
then []
1187-
else [Assign (Decl (future, Var fut))
1188-
(Call futureMkFn [AsExpr encoreCtxVar, ty])]) ++
1189-
(if Util.isForwardInExpr body
1190-
then [assignVar futNam futArg]
1191-
else []) ++
1192-
[Assign (Decl (closure, Var tmp))
1193-
(Call closureMkFn [encoreCtxName, funName, envName, traceName, nullName])])
1188+
Seq $
1189+
mkEnv envName : fillEnv ++
1190+
if isAsyncForward then
1191+
if forwardInBody
1192+
then [Assign (Decl (future, Var futClos))
1193+
(Call futureMkFn [AsExpr encoreCtxVar, ty])
1194+
,assignVar futNam (Var futClos)
1195+
,Assign (Decl (closure, Var tmp))
1196+
(Call closureMkFn [encoreCtxName, funNameAsync, envName, traceNameAsync, nullName])]
1197+
else [Assign (Decl (closure, Var tmp))
1198+
(Call closureMkFn [encoreCtxName, funName, envName, traceName, nullName])]
1199+
else
1200+
[Assign (Decl (closure, Var tmp))
1201+
(Call closureMkFn [encoreCtxName, funName, envName, traceName, nullName])])
11941202
where
1203+
forwardInBody = Util.isForwardInExpr body
1204+
metaIdAsync = metaId ++ "_async"
1205+
idClos = A.isIdClosure body
1206+
funNameAsync = if idClos || not forwardInBody then funName
1207+
else closureFunName metaIdAsync
1208+
traceNameAsync = if idClos || not forwardInBody then traceName
1209+
else closureTraceName metaIdAsync
11951210
metaId = Meta.getMetaId . A.getMeta $ clos
11961211
funName = closureFunName metaId
11971212
envName = closureEnvName metaId

‎src/back/CodeGen/MethodDecl.hs

+12-2
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,14 @@ translateGeneral mdecl@(A.Method {A.mbody, A.mlocals})
7373
,returnStatement mType bodyn])
7474
forwardingMethodImpl =
7575
Function void nameForwarding (args ++ [(future, futVar)])
76-
(Seq [dtraceMethodEntry thisVar mName argNames
76+
(Seq $[dtraceMethodEntry thisVar mName argNames
7777
,parametricMethodTypeVars
7878
,extractTypeVars
7979
,forwardingBody
8080
,dtraceMethodExit thisVar mName
81-
,Return Skip])
81+
,Statement $ returnForForwardingMethod returnType
82+
,Return Skip]
83+
)
8284
in
8385
code ++ return (Concat $ locals ++ closures ++
8486
[normalMethodImpl] ++
@@ -133,6 +135,14 @@ translateGeneral mdecl@(A.Method {A.mbody, A.mlocals})
133135
show oldName
134136
in A.setFunctionName newName fun
135137

138+
returnForForwardingMethod returnType =
139+
let fulfilArgs = [AsExpr encoreCtxVar
140+
,AsExpr $ futVar
141+
,asEncoreArgT returnType
142+
(Cast returnType forwardingBodyName)]
143+
in
144+
If futVar (Statement $ Call futureFulfil fulfilArgs) Skip
145+
136146
callMethodWithFuture m cdecl@(A.Class {A.cname}) code
137147
| A.isActive cdecl ||
138148
A.isShared cdecl =

‎src/ir/AST/AST.hs

+13-1
Original file line numberDiff line numberDiff line change
@@ -676,7 +676,7 @@ data Expr = Skip {emeta :: Meta Expr}
676676
val :: Expr}
677677
| Suspend {emeta :: Meta Expr}
678678
| FutureChain {emeta :: Meta Expr,
679-
future :: Expr,
679+
future :: Expr,
680680
chain :: Expr}
681681
| FieldAccess {emeta :: Meta Expr,
682682
target :: Expr,
@@ -765,14 +765,26 @@ isThisAccess :: Expr -> Bool
765765
isThisAccess VarAccess {qname = QName{qnlocal}} = qnlocal == Name "this"
766766
isThisAccess _ = False
767767

768+
isIdClos :: Expr -> Bool
769+
isIdClos VarAccess{qname = QName{qnlocal}} = qnlocal == Name "_id_fun_tmp"
770+
isIdClos _ = False
771+
768772
isClosure :: Expr -> Bool
769773
isClosure Closure {} = True
770774
isClosure _ = False
771775

776+
isIdClosure :: Expr -> Bool
777+
isIdClosure VarAccess{qname = QName{qnlocal}} = qnlocal == Name "_id_fun_tmp"
778+
isIdClosure _ = False
779+
772780
isForward :: Expr -> Bool
773781
isForward Forward {} = True
774782
isForward _ = False
775783

784+
isVarAccess :: Expr -> Bool
785+
isVarAccess VarAccess{} = True
786+
isVarAccess _ = False
787+
776788
isNull :: Expr -> Bool
777789
isNull Null{} = True
778790
isNull _ = False

‎src/runtime/future/future.c

+18-7
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ static void future_finalizer(future_t *fut);
103103
static inline void future_gc_send_value(pony_ctx_t *ctx, future_t *fut);
104104
static inline void future_gc_recv_value(pony_ctx_t *ctx, future_t *fut);
105105
static void future_chain(pony_ctx_t **ctx, future_t *fut, pony_type_t *type,
106-
closure_t *c, future_t *r);
106+
closure_t *c, future_t *r, bool withForward);
107107

108108
pony_type_t future_type = {
109109
.id = ID_FUTURE,
@@ -198,6 +198,12 @@ static inline encore_arg_t run_closure(pony_ctx_t **ctx, closure_t *c, encore_ar
198198
return closure_call(ctx, c, (value_t[1]) { value });
199199
}
200200

201+
static inline void run_closure_fwd(pony_ctx_t **ctx, closure_t *c, encore_arg_t value)
202+
{
203+
closure_call(ctx, c, (value_t[1]) { value });
204+
return;
205+
}
206+
201207
bool future_fulfilled(future_t *fut)
202208
{
203209
perr("future_fulfilled");
@@ -306,30 +312,35 @@ future_t *future_chain_actor(pony_ctx_t **ctx, future_t *fut, pony_type_t *type,
306312
{
307313
ENC_DTRACE3(FUTURE_CHAINING, (uintptr_t) *ctx, (uintptr_t) fut, (uintptr_t) type);
308314
future_t *r = future_mk(ctx, type);
309-
future_chain(ctx, fut, type, c, r);
315+
future_chain(ctx, fut, type, c, r, false);
310316
return r;
311317
}
312318

313319
void future_chain_with_fut(pony_ctx_t **ctx, future_t *fut, pony_type_t *type,
314-
closure_t *c, future_t *r)
320+
closure_t *c, future_t *r, bool keepFwd)
315321
{
316322
ENC_DTRACE3(FUTURE_CHAINING, (uintptr_t) *ctx, (uintptr_t) fut, (uintptr_t) type);
317323
(void)type;
318-
future_chain(ctx, fut, type, c, r);
324+
future_chain(ctx, fut, type, c, r, keepFwd);
319325
return;
320326
}
321327

322328
static void future_chain(pony_ctx_t **ctx, future_t *fut, pony_type_t *type,
323-
closure_t *c, future_t *r)
329+
closure_t *c, future_t *r, bool withForward)
324330
{
325331
(void)type;
326332
perr("future_chain_actor");
327333
BLOCK;
328334

329335
if (fut->fulfilled) {
330336
acquire_future_value(ctx, fut);
331-
value_t result = run_closure(ctx, c, fut->value);
332-
future_fulfil(ctx, r, result);
337+
if (withForward) {
338+
run_closure_fwd(ctx, c, fut->value);
339+
}
340+
else {
341+
value_t result = run_closure(ctx, c, fut->value);
342+
future_fulfil(ctx, r, result);
343+
}
333344
UNBLOCK;
334345
return;
335346
}

‎src/runtime/future/future.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ future_t *future_chain_actor(pony_ctx_t **ctx, future_t *fut, pony_type_t *type,
5555
closure_t *c);
5656

5757
void future_chain_with_fut(pony_ctx_t **ctx, future_t *fut, pony_type_t *type,
58-
closure_t *c, future_t *r);
58+
closure_t *c, future_t *r, bool keepFwd);
5959

6060
/** Registers a callback and returns void
6161
*

‎src/tests/encore/forward/failedPolyTypeStreamWithObject.enc

+58
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
-- Error related to unknown _enc_type_t in method produce()
2+
-- read class Bar
3+
-- val v : int
4+
-- def init(v : int) : unit
5+
-- this.v = v
6+
-- end
7+
-- def getter() : int
8+
-- this.v
9+
-- end
10+
-- end
11+
active class Foo[t]
12+
stream produce(var n : int, v : t) : t
13+
while n>0 do
14+
yield(v)
15+
n -= 1
16+
end
17+
end
18+
end
19+
active class Main
20+
def main() : unit
21+
val foo = new Foo[int]
22+
val s = foo!produce(10, 42)
23+
end
24+
end
25+
26+
-- With the concrete type of stream, it works properly.
27+
{-
28+
read class Bar
29+
val v : int
30+
def init(v : int) : unit
31+
this.v = v
32+
end
33+
def getter() : int
34+
this.v
35+
end
36+
end
37+
active class Foo
38+
stream produce(var n : int) : Bar
39+
while n>0 do
40+
yield(new Bar(n))
41+
n -= 1
42+
end
43+
end
44+
end
45+
active class Main
46+
def printStream(var s : Stream[Bar]) : unit
47+
while not(eos(s)) do
48+
println("{}", (get(s)).getter())
49+
s = getNext(s)
50+
end
51+
end
52+
def main() : unit
53+
val foo = new Foo
54+
val s = foo!produce(10)
55+
this.printStream(s)
56+
end
57+
end
58+
-}

‎src/tests/encore/forward/forwardArgInClosure.enc

+5-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,11 @@ end
66

77
active class Foo
88
def join(ff : Fut[Fut[int]]) : int
9-
(ff ~~> (fun (f : Fut[int]) : unit => forward(f)))
10-
0 -- Will be disregarded since it is used to bypass the typechecker.
9+
await(ff)
10+
get(ff ~~> fun (f : Fut[int]) : int
11+
await(f)
12+
forward(f)
13+
end)
1114
end
1215

1316
def duplicate() : Fut[int]

‎src/tests/encore/forward/forwardClosMaybe.enc

+1-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ active class Crop
99
end
1010
active class Pepper
1111
def green(arg : Fut[Maybe[int]]) : Maybe[int]
12-
get(arg ~~> fun(x : Maybe[int]) : unit => forward((new Crop(x)) ! collect()))
13-
Nothing : Maybe[int]
12+
get(arg ~~> fun(x : Maybe[int]) : Maybe[int] => forward((new Crop(x)) ! collect()))
1413
end
1514
end
1615
active class Main

0 commit comments

Comments
 (0)