Skip to content

Commit bb5ce68

Browse files
wass08claude
andauthored
Viewer render modes: Solid/Rendered + textures + surface-role clay + scene themes + edges (#332)
* viewer: add Phase 1 render-modes foundation (shading/textures/colorPreset state, defaultRender prop, SSGI gating) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: Phase 2 render-modes material-class switch (Lambert in solid, Standard in rendered) Shading-aware material factories (cached per class), reactive selection in renderers via the useViewer(shading) pattern, and dirty-rebuild on toggle for geometry/door systems. Rendered mode output unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: Phase 3a render-modes surface roles + clay palette foundation Adds surfaceRole token to core NodeDefinition, per-kind default roles, ColorPreset palettes + resolveSurfaceColor/createSurfaceRoleMaterial (glazing stays translucent), and the textures-off recolor path for def.geometry kinds (slab/fence/shelf via GeometrySystem.applyDefaultSurfaceRole) + wall. Renderer- based kinds (roof/window/stair/item/column/door/ceiling/elevator) wired in 3b. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: Phase 3b render-modes textures-off recoloring for renderer/system kinds Wires clay role coloring (textures=off) for roof/roof-segment, window, stair/ stair-segment, door, item, column, ceiling, elevator via createSurfaceRoleMaterial, reactive on textures/colorPreset. Per-surface roles: roof top+edge=roof / underside=ceiling; window frame=joinery / glass=glazing; stair+door+elevator= joinery; ceiling=ceiling; column=wall; item=furnishing. textures=on unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * editor: Phase 4a render-modes UI — Solid/Rendered toggle + per-context persistence Per-context shading via renderContext discriminator + shadingByContext (persisted); <Viewer> renderContext prop seeds per-context on mount. Solid/Rendered toggle in the editor action bar + standalone toolbar + command palette. Editor mounts default to renderContext=editor / shading=solid. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: fix window-system glassMaterial type to allow clay glazing reassignment The let was inferred as MeshLambertNodeMaterial from the imported glass constant, so reassigning createSurfaceRoleMaterial('glazing') (returns THREE.Material) failed under tsc --build. Widen the annotation to THREE.Material. Surfaced by the build (check-types had replayed a stale turbo cache). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: Phase 5 lighting — add theme-driven hemisphere light, trim fill directionals 3->2 Adds a sky/ground hemisphere fill (theme-lerped) and drops the second fill directional; the hemisphere covers the shadow-side fill it provided, at one fewer per-fragment directional term (shared by Solid + Rendered). Ambient lowered since the hemisphere now carries soft fill. Intensities are a starting point — tune visually on the gpu-perf overlay. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: tune Solid lighting for more form — stronger hemisphere sky/ground contrast, lower ambient Darker hemisphere ground (#d8d6cf -> #aaa49a) + higher hemisphere intensity and lower ambient so directional shading reads as form and undersides ground without AO. Keeps Solid free of any post-processing pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: biome format render-mode files (lefthook pre-commit) Formatting-only — import wrapping, dep-array wrapping, single-line ternaries — across Phase 2-4a files that weren't biome-clean. No logic changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: scene-theme system — named environment themes (studio/paper/sunset/night/...) New SceneTheme registry (lib/scene-themes.ts) drives lights, background, and tone mapping; lights.tsx refactored data-driven (N directionals + hemisphere + ambient). sceneTheme state (persisted) + cycle-button picker in editor bar + standalone toolbar, importing the registry from the viewer barrel (single source). Default 'studio' reproduces the prior look exactly; app light/dark 'theme' untouched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * editor: Phase 7 — popover-dropdown pickers for render mode + scene theme (editor bar) Replace the shading + scene-theme cycle buttons in viewer-overlay.tsx with DropdownMenu pickers: render mode shows 2 rows (Solid/Rendered) with one-line detail; scene theme lists all themes with a derived color-swatch strip + active check. Imports the registry from the viewer barrel (single source). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * editor: Phase 7 — dropdown pickers in standalone toolbar + export DropdownMenu from barrel Replicate the render-mode + scene-theme dropdown pickers (with swatch strip + active check) to apps/editor's compact toolbar, matching viewer-overlay.tsx. Export DropdownMenu* from the @pascal-app/editor barrel for the standalone app. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer+editor: Phase 8 — crisp geometry edge overlay (off/soft/strong/sketchy) EdgeOverlaySystem draws EdgesGeometry LineSegments over node-backed building meshes (scoped via sceneRegistry, skips zone-layer/hitbox/overlay meshes), rebuilt on geometry-uuid or mode change, line color follows scene-theme background luminance; sketchy = static TSL vertex jitter. New 'edges' state (persisted, default off) + Edges dropdown in editor bar + standalone toolbar. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer+editor: edge overlay — thick lines via Line2, drop sketchy mode Switch EdgeOverlaySystem from LineBasicNodeMaterial (1px hardware cap) to LineSegments2 + Line2NodeMaterial so edges have real screen-space width (soft 1.5px / strong 3px); resolution tracks viewport. EdgeMode is now off/soft/strong (sketchy removed). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: fix edge overlay crash — webgpu Line2NodeMaterial has no settable resolution material.resolution is undefined under WebGPU (the node material reads the viewport internally); optional-chain the .set() call so it no-ops there instead of throwing. Thickness still applies via linewidth. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: edge overlay — weld vertices to fix CSG spiderweb edges + lighter strong Position-only mergeVertices before EdgesGeometry so coplanar triangles from CSG-cut walls (doors/windows) share vertices and their interior edges are suppressed — only opening outlines + silhouettes remain. Strong linewidth 3 -> 2px (was too heavy). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: edge overlay — crease-only extractor to fix CSG spiderweb Replace EdgesGeometry (which always draws unpaired boundary/T-junction edges) with buildCreaseEdges: weld positions, keep only edges shared by exactly two faces whose dihedral exceeds the threshold, drop everything unpaired. CSG-cut walls/slabs are watertight so real corners + opening outlines survive while the interior triangulation fans (coplanar or T-junction) are removed. Open meshes (bare ground plane, billboard leaves) shed their boundary clutter too. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: crease edges — coarser weld (0.1mm->1mm) to recover CSG/extrude seam edges The cap<->side-wall top edge of ExtrudeGeometry walls drifts past 0.1mm after CSG, so it stayed unpaired and was dropped. Weld at ~1mm to pair it into a real crease while staying far below feature size (wall thickness, openings). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: replace geometry edge overlay with screen-space ink (SketchUp look) Port the prototype's screen-space ink into the post-processing pipeline: depth + normal Sobel reading the scene-pass MRT. Crease term (normalized normals, center-vs-neighbour) + distance-independent depth-step term (raw Laplacian / (1-d)² with a noise gate so flat ground stays clean). Topology-agnostic, so it finally handles CSG-cut walls/openings without the spiderweb or missing-edge problems of EdgesGeometry. Driven by the existing edges off/soft/strong mode; MRT now builds when SSGI OR ink is on; ink colour tracks scene-theme luminance. Removes EdgeOverlaySystem + crease-edges (geometry approach). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: soft/strong ink modes + keep editor overlays out of the ink Two adjustments to the screen-space ink pass: 1. Soft vs strong now visibly differ. The edge masks saturate, so the old `intensity` gain did nothing once a line was detected. Replace it with a sample radius (line thickness) + opacity: soft = 1px / 50%, strong = 2px / 100%. `inkedEdges` takes `radius` + `opacity` instead of `intensity`. 2. Editor overlays (gizmos, move handles, tool previews, grid) no longer get inked. The scene pass that feeds the depth/normal MRT now renders only SCENE_LAYER; overlays render in a dedicated pass on OVERLAY_LAYER and are composited on top after the ink + outlines, so they read as crisp UI and never get inked or AO'd. New OVERLAY_LAYER constant in viewer; editor's EDITOR_LAYER re-exports it so the two stay in lockstep. Also moves WallMoveSideHandles (the wall/fence move arrows) onto EDITOR_LAYER — it was the one overlay still on SCENE_LAYER. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: render the grid in the scene pass so geometry occludes it The depth-gate fix couldn't help the grid: its material is depthWrite:false, so it never wrote overlay-pass depth and the "didn't write depth -> keep on top" term forced it on top — hence the floor grid bleeding through walls and objects. A full-floor plane can only be occluded correctly by living in the same depth context as the scene, so move the grid onto its own GRID_LAYER which the scene pass renders (alongside SCENE_LAYER). It's flat and depth-non-writing, so the screen-space ink still ignores it; gizmos/handles stay on OVERLAY_LAYER. The grid camera layer is enabled in custom-camera-controls and disabled on the thumbnail camera so thumbnails stay grid-free, matching EDITOR_LAYER. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: strong ink — match soft's 1px thickness, differ by darkness only Strong at radius 2 read too thick. Soft's 1px line is the nice one, so use it for both modes and let strong distinguish itself purely by being fully solid (opacity 1) vs soft's lighter 50%. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: shadow frustum follows the view + a shadows on/off setting The directional light's ortho shadow camera only covers ±50 around the light target, which was pinned at the origin — so zones far from origin received no shadows no matter where the camera moved. Recentre each shadow-casting light (position + target together, preserving direction) on the view focus every frame: the orbit-controls target when available, else the camera's ground projection. The shadow area now tracks wherever the user looks. Also add a persisted `shadows` toggle (default on) to the viewer store and a "Shadows" switch in the editor settings panel — the dedicated shadows control the render-modes plan deferred. Lights gate castShadow on it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * editor: shadows toggle in the standalone toolbar + a touch more shadow strength The shadows switch I added only lived in the cloud settings panel's Visibility section, which is hidden in the local/standalone editor (no projectId). Add a ShadowsToggle button next to the grid toggle in the standalone toolbar so it's reachable there, matching how Show Grid is exposed in both places. Also push shadow strength partway toward the aesthetic prototype (which runs near-black, no blur): bump the bright-key shadow-intensity cap 0.4 -> 0.55 and tighten shadow-radius 2 -> 1.5. Still softer than aesthetic by design. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * nodes: site ground receives shadows (lit material instead of unlit Basic) The site ground fill used MeshBasicMaterial — unlit, so it could never show the directional shadow, and shadows visibly truncated at the slab edge. Swap it for a lit MeshLambertNodeMaterial with receiveShadow on the mesh; the geometry is the site polygon (slab footprints punched out), so shadows now extend across the whole site and stop at its boundary, which is the desired bound. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * themes: per-theme clay palettes + 2x2 swatch in the theme pickers Each scene theme now carries a clayTints map (wall/floor/ceiling/roof/glazing) giving it a per-surface-role palette — e.g. Mediterranean's blue roof + warm walls. The theme pickers (standalone toolbar + community overlay) now render the aesthetic-style 2x2 swatch of those role tints over the theme background instead of the old 3-colour strip. Data + UI only; wiring the tints into the textures-off surface materials is a separate change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * editor: slimmer theme switcher + cloud-sun icon Shrink the scene-theme toolbar button (w-[8.5rem] -> w-28) so it stops reserving space for "Mediterranean"; the label truncates when it overflows. Swap the palette icon for cloud-sun (atmosphere/lighting, distinct from the app light/dark Sun-Moon toggle) in both the standalone toolbar and the community overlay. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * editor: theme switcher icon -> swatch-book Swap the scene-theme icon from cloud-sun to swatch-book in both the standalone toolbar and the community overlay. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * themes: colour untextured building surfaces by the active scene theme Untextured walls/roof/slab/ceiling now take the active theme's per-role colour (theme.clayTints[role], falling back to the colour preset) in BOTH textures modes. The textures toggle only governs surfaces that actually have an explicit material/preset — those still show their texture when textures are on. This is what makes e.g. Mediterranean read as a blue roof + warm walls instead of the old hardcoded white/grey defaults. - materials.ts: resolveSurfaceColor / createSurfaceRoleMaterial take an optional sceneThemeId (theme tint ?? preset palette); theme folded into the cache key. - wall-materials, roof-materials, slab/geometry, ceiling/renderer: the untextured fallback now resolves to the themed role colour instead of white/grey, in both modes; theme threaded into each builder + material cache key. - wall-cutout: now reads textures/colorPreset/sceneTheme and re-applies wall materials when any change (previously it ignored textures/colorPreset entirely). - geometry-system: threads sceneTheme into the generic surface-role path + rebuild effect. Renderers/preview call sites thread sceneTheme through. Doors/windows/stairs/columns/items still use their existing defaults — a follow-up pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(slab): recessed (negative-elevation) slabs extrude downward again The registry geometry builder created the slab mesh at Y=0 without applying the negative-elevation offset, so recessed slabs rendered above the floor plane (pool geometry is built locally with its floor cap at Y=0 and walls rising to Y=|elevation|, so the mesh must be shifted down by `elevation` to recess). The runtime slab-system already did this; the static builder path didn't. Mirror it: shift mesh.position.y by elevation when negative. Positive elevation unchanged. Unrelated to render modes — bundled into this branch's PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(roof): legacy roofs render again — migration wrote invalid wallHeight 0 Legacy roof nodes (old format, no `children`) were migrated with a hardcoded `wallHeight: 0`. With zero wall height the eave height (`wallHeight - autoDrop`) went negative in getRoofSegmentBrushes, producing geometrically invalid brushes; three-bvh-csg then spammed "TriangleClipper: Coplanar clip not handled" every frame and emitted NaN positions, so the merged roof geometry failed computeBoundingSphere and never rendered. - core/use-scene migration: wallHeight 0 -> 0.5 (the RoofSegmentNode schema default), so migrated segments have a valid wall height. - roof-system: clamp eave height to >= 0.01 so an intentional wallHeight 0 can never yield a negative eave, and guard updateMergedRoofGeometry so a CSG result with NaN positions is discarded (keep the last good mesh, warn once per roof) instead of poisoning the buffer + spamming the console. Unrelated to render modes — bundled into this branch's PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(column): columns cast and receive shadows Column meshes (box, beam, cylinder, sphere, torus) rendered without castShadow/ receiveShadow, so columns neither dropped a shadow nor caught one — unlike walls, slabs and roofs. Set both on all column shape meshes. Unrelated to render modes — bundled into this branch's PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * viewer: default edges to soft Editor defaults are now solid shading / studio theme / soft edges / shadows on. Shading (solid, via EDITOR_DEFAULT_RENDER), theme (studio) and shadows (on) were already the defaults; edges was 'off' — make 'soft' the default. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * themes: fold light/dark into the scene theme (remove the separate toggle) The viewer had two overlapping appearance controls: a light/dark `theme` toggle AND scene themes (which already drive the 3D background + lights). They conflicted — e.g. Night/Twilight are dark themes, but the light/dark toggle was an independent axis still tinting the 2D scene chrome. Unify on the scene theme: add an explicit `appearance: 'light' | 'dark'` to each SceneTheme (twilight/night = dark, the rest = light) and drive everything the old toggle drove off it — canvas backdrop, grid line colours, measurement-label/ cursor/site-edge contrast, the site ground fill, the ground occluder, and the mobile viewer bg. The editor UI chrome is unaffected (always dark via a fixed body class). Removes the `theme`/`setTheme` store state (+ persistence) and every light/dark toggle UI: the standalone toolbar Sun/Moon button, the community overlay theme switch, the command-palette command, and the ifc-converter preview toolbar button. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * themes: per-theme ground colour + add the "Verdant" nature theme - Add a `ground` colour to every SceneTheme and drive the site ground fill + the infinite ground-occluder off it (instead of the binary isDark ? #1f2433 : #fafafa). Dark themes now get a lit mid-tone ground (twilight #4a4566, night #2b3247) so the ground reads as ground rather than going near-black. - Add a new green/nature scene theme "Verdant": soft green sky + lit, with a green roof clay tint and mossy ground. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * wiki: document the surface-colour / theme system The colour-per-node/renderer/system model from the render-modes work was undocumented. Add wiki/architecture/materials-and-themes.md covering surface roles, colour presets, the textures axis, scene themes (appearance / ground / clay tints), and the "untextured surfaces are theme-coloured in both modes" invariant + where each kind wires it. Also fix two pages that the same work made stale: - node-definitions: geometry builders receive (shading, textures, colorPreset, sceneTheme); document the `surfaceRole` token + applyDefaultSurfaceRole. - layers: OVERLAY_LAYER (1, viewer) with EDITOR_LAYER now its alias, the new GRID_LAYER (3, rendered in the scene pass for depth occlusion), and the overlay pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * nodes: wire #330 roof-accessory kinds into the surface-role/theme colours PR #330's new kinds (chimney, dormer, skylight, solar-panel, ridge-vent, box-vent) use custom renderers, so the generic textures-off recolour path never reached them — they fell back to hardcoded colours. Wire each renderer into the render-modes system: read shading/textures/colorPreset/sceneTheme and resolve untextured surfaces via createSurfaceRoleMaterial (and force the role colour when textures are off), matching column/ceiling. Roles: chimney body→wall / cap→roof; dormer wall→wall, roof→roof, glass→glazing, frame→joinery; skylight glass→glazing / frame→joinery; ridge-vent + box-vent→roof; solar-panel frame→roof (the dark product-specific cell face is left as-is). Each definition also gets its dominant `surfaceRole` token. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(roof): legacy-roof migration must use a non-zero wallHeight The render-modes/#330 merge left the legacy roof→roof-segment migration writing `wallHeight: 0`. With #330's pitch model that builds a flat, zero-volume wall CSG brush, which three-bvh-csg can't clip ("Coplanar clip not handled") and yields NaN positions — so the migrated old roof never renders. Use the schema default 0.5 (what new roofs use), giving a valid wall. The eave clamp + merged- geometry NaN guard added earlier stay as defense-in-depth. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(roof): guard slope frame against missing/NaN pitch (no more NaN geometry) getSegmentSlopeFrame used `pitch <= 0` to detect flat/zero-pitch, but an undefined or NaN pitch (a segment from an older migration that set `roofHeight` instead of `pitch`, or stale persisted data) slips past that check and computes Math.tan(NaN) → NaN tanTheta/activeRh → NaN segment geometry → the merged-roof CSG spews "Coplanar clip not handled" and NaN positions, so the roof never renders. Use `!(pitch > 0)` so any non-positive/non-finite pitch resolves to the flat frame. Self-heals bad data regardless of how the segment was produced. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(roof): migration guarantees a positive pitch for every roof-segment Segments saved with neither a valid pitch nor a roofHeight (older/partial saves, e.g. landing home-graph) fell through the legacy roofHeight->pitch branch, leaving pitch undefined. The slope-frame guard then resolved them to a flat frame, so the roof rendered as a slab instead of pitched. Branch 2b now normalises any segment lacking a valid pitch: derive from roofHeight when present, else fall back to the schema default (40deg). The migration result is cast (not zod-parsed), so this is the only place the default lands. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 87384cf commit bb5ce68

140 files changed

Lines changed: 4041 additions & 1691 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

apps/editor/app/layout.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,7 @@ export default function RootLayout({
3333
>
3434
<head>
3535
{process.env.NODE_ENV === 'development' && (
36-
<script
37-
async
38-
crossOrigin="anonymous"
39-
src="//unpkg.com/react-scan/dist/auto.global.js"
40-
/>
36+
<script async crossOrigin="anonymous" src="//unpkg.com/react-scan/dist/auto.global.js" />
4137
)}
4238
</head>
4339
<body className="font-sans">

apps/editor/components/viewer-toolbar.tsx

Lines changed: 180 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,36 @@
11
'use client'
22

33
import { Icon as IconifyIcon } from '@iconify/react'
4-
import { useEditor, useSidebarStore, type ViewMode } from '@pascal-app/editor'
5-
import { useViewer } from '@pascal-app/viewer'
64
import {
5+
DropdownMenu,
6+
DropdownMenuContent,
7+
DropdownMenuItem,
8+
DropdownMenuTrigger,
9+
useEditor,
10+
useSidebarStore,
11+
type ViewMode,
12+
} from '@pascal-app/editor'
13+
import {
14+
CLAY_PALETTE,
15+
type EdgeMode,
16+
getSceneTheme,
17+
SCENE_THEMES,
18+
useViewer,
19+
} from '@pascal-app/viewer'
20+
import {
21+
Box,
22+
Check,
723
ChevronsLeft,
824
ChevronsRight,
925
Columns2,
26+
Contrast,
1027
Eye,
1128
EyeOff,
1229
Footprints,
1330
Grid2X2,
14-
Moon,
15-
Sun,
31+
PenLine,
32+
Sparkles,
33+
SwatchBook,
1634
} from 'lucide-react'
1735
import Image from 'next/image'
1836
import { type ReactNode, useCallback } from 'react'
@@ -83,6 +101,11 @@ const wallModeConfig: Record<string, { icon: string; label: string }> = {
83101
down: { icon: '/icons/walllow.png', label: 'Low' },
84102
}
85103

104+
const SHADING_OPTIONS = [
105+
{ id: 'solid', name: 'Solid', detail: 'Flat and fast — no ambient occlusion', icon: Box },
106+
{ id: 'rendered', name: 'Rendered', detail: 'Full ambient occlusion', icon: Sparkles },
107+
] as const
108+
86109
function ViewModeControl() {
87110
const viewMode = useEditor((state) => state.viewMode)
88111
const setViewMode = useEditor((state) => state.setViewMode)
@@ -216,6 +239,134 @@ function WallModeToggle() {
216239
)
217240
}
218241

242+
function RenderModeMenu() {
243+
const shading = useViewer((state) => state.shading)
244+
const setShading = useViewer((state) => state.setShading)
245+
const active = SHADING_OPTIONS.find((option) => option.id === shading) ?? SHADING_OPTIONS[0]
246+
const ActiveIcon = active.icon
247+
248+
return (
249+
<DropdownMenu>
250+
<ToolbarTooltip label={`Render: ${active.name}`}>
251+
<DropdownMenuTrigger asChild>
252+
<button
253+
aria-label={`Render: ${active.name}`}
254+
className={cn(
255+
TOOLBAR_BTN,
256+
'w-auto gap-1.5 px-2.5',
257+
shading === 'rendered' && 'bg-white/10 text-foreground/90',
258+
)}
259+
type="button"
260+
>
261+
<ActiveIcon className="h-3.5 w-3.5" />
262+
<span className="font-medium text-xs">{active.name}</span>
263+
</button>
264+
</DropdownMenuTrigger>
265+
</ToolbarTooltip>
266+
<DropdownMenuContent align="center" className="min-w-56" side="bottom">
267+
{SHADING_OPTIONS.map((option) => {
268+
const OptionIcon = option.icon
269+
return (
270+
<DropdownMenuItem key={option.id} onSelect={() => setShading(option.id)}>
271+
<OptionIcon className="h-4 w-4" />
272+
<div className="flex flex-col">
273+
<span className="text-foreground">{option.name}</span>
274+
<span className="text-muted-foreground text-xs">{option.detail}</span>
275+
</div>
276+
{shading === option.id ? <Check className="ml-auto h-4 w-4 text-foreground" /> : null}
277+
</DropdownMenuItem>
278+
)
279+
})}
280+
</DropdownMenuContent>
281+
</DropdownMenu>
282+
)
283+
}
284+
285+
function SceneThemeMenu() {
286+
const sceneTheme = useViewer((state) => state.sceneTheme)
287+
const setSceneTheme = useViewer((state) => state.setSceneTheme)
288+
const active = getSceneTheme(sceneTheme)
289+
290+
return (
291+
<DropdownMenu>
292+
<ToolbarTooltip label={`Scene theme: ${active.name}`}>
293+
<DropdownMenuTrigger asChild>
294+
<button
295+
aria-label={`Scene theme: ${active.name}`}
296+
className={cn(TOOLBAR_BTN, 'w-28 gap-1.5 px-2.5 text-foreground/90')}
297+
type="button"
298+
>
299+
<SwatchBook className="h-3.5 w-3.5 shrink-0" />
300+
<span className="truncate font-medium text-xs">{active.name}</span>
301+
</button>
302+
</DropdownMenuTrigger>
303+
</ToolbarTooltip>
304+
<DropdownMenuContent align="center" className="min-w-48" side="bottom">
305+
{SCENE_THEMES.map((theme) => {
306+
const swatches = (['wall', 'roof', 'floor', 'glazing'] as const).map(
307+
(role) => theme.clayTints?.[role] ?? CLAY_PALETTE[role],
308+
)
309+
return (
310+
<DropdownMenuItem key={theme.id} onSelect={() => setSceneTheme(theme.id)}>
311+
<span
312+
className="grid h-5 w-5 shrink-0 grid-cols-2 overflow-hidden rounded-sm border border-black/10"
313+
style={{ backgroundColor: theme.background }}
314+
>
315+
{swatches.map((color, index) => (
316+
<span key={`${theme.id}-${index}`} style={{ backgroundColor: color }} />
317+
))}
318+
</span>
319+
<span className="text-foreground">{theme.name}</span>
320+
{sceneTheme === theme.id ? (
321+
<Check className="ml-auto h-4 w-4 text-foreground" />
322+
) : null}
323+
</DropdownMenuItem>
324+
)
325+
})}
326+
</DropdownMenuContent>
327+
</DropdownMenu>
328+
)
329+
}
330+
331+
const EDGE_OPTIONS = [
332+
{ id: 'off', name: 'Off', detail: 'No edge lines' },
333+
{ id: 'soft', name: 'Soft', detail: 'Faint outline of major creases' },
334+
{ id: 'strong', name: 'Strong', detail: 'Crisp, opaque edge lines' },
335+
] as const satisfies readonly { id: EdgeMode; name: string; detail: string }[]
336+
337+
function EdgesMenu() {
338+
const edges = useViewer((state) => state.edges)
339+
const setEdges = useViewer((state) => state.setEdges)
340+
const active = EDGE_OPTIONS.find((option) => option.id === edges) ?? EDGE_OPTIONS[0]
341+
342+
return (
343+
<DropdownMenu>
344+
<ToolbarTooltip label={`Edges: ${active.name}`}>
345+
<DropdownMenuTrigger asChild>
346+
<button
347+
aria-label={`Edges: ${active.name}`}
348+
className={cn(TOOLBAR_BTN, edges !== 'off' && 'bg-white/10 text-foreground/90')}
349+
type="button"
350+
>
351+
<PenLine className="h-4 w-4" />
352+
</button>
353+
</DropdownMenuTrigger>
354+
</ToolbarTooltip>
355+
<DropdownMenuContent align="center" className="min-w-56" side="bottom">
356+
{EDGE_OPTIONS.map((option) => (
357+
<DropdownMenuItem key={option.id} onSelect={() => setEdges(option.id)}>
358+
<div className="flex flex-col">
359+
<span className="text-foreground">{option.name}</span>
360+
<span className="text-muted-foreground text-xs">{option.detail}</span>
361+
</div>
362+
{edges === option.id ? <Check className="ml-auto h-4 w-4 text-foreground" /> : null}
363+
</DropdownMenuItem>
364+
))}
365+
</DropdownMenuContent>
366+
</DropdownMenu>
367+
)
368+
}
369+
219370
function GridVisibilityToggle() {
220371
const showGrid = useViewer((state) => state.showGrid)
221372
const setShowGrid = useViewer((state) => state.setShowGrid)
@@ -242,35 +393,42 @@ function GridVisibilityToggle() {
242393
)
243394
}
244395

245-
function UnitToggle() {
246-
const unit = useViewer((state) => state.unit)
247-
const setUnit = useViewer((state) => state.setUnit)
396+
function ShadowsToggle() {
397+
const shadows = useViewer((state) => state.shadows)
398+
const setShadows = useViewer((state) => state.setShadows)
248399

249400
return (
250-
<ToolbarTooltip label={unit === 'metric' ? 'Metric (m)' : 'Imperial (ft)'}>
401+
<ToolbarTooltip label={`Shadows: ${shadows ? 'On' : 'Off'}`}>
251402
<button
252-
className={TOOLBAR_BTN}
253-
onClick={() => setUnit(unit === 'metric' ? 'imperial' : 'metric')}
403+
aria-label={`Shadows: ${shadows ? 'On' : 'Off'}`}
404+
aria-pressed={shadows}
405+
className={cn(
406+
TOOLBAR_BTN,
407+
shadows
408+
? 'bg-white/10 text-foreground/90'
409+
: 'opacity-60 grayscale hover:opacity-100 hover:grayscale-0',
410+
)}
411+
onClick={() => setShadows(!shadows)}
254412
type="button"
255413
>
256-
<span className="font-semibold text-[10px]">{unit === 'metric' ? 'm' : 'ft'}</span>
414+
<Contrast className="h-3.5 w-3.5" />
257415
</button>
258416
</ToolbarTooltip>
259417
)
260418
}
261419

262-
function ThemeToggle() {
263-
const theme = useViewer((state) => state.theme)
264-
const setTheme = useViewer((state) => state.setTheme)
420+
function UnitToggle() {
421+
const unit = useViewer((state) => state.unit)
422+
const setUnit = useViewer((state) => state.setUnit)
265423

266424
return (
267-
<ToolbarTooltip label={theme === 'dark' ? 'Dark' : 'Light'}>
425+
<ToolbarTooltip label={unit === 'metric' ? 'Metric (m)' : 'Imperial (ft)'}>
268426
<button
269-
className={cn(TOOLBAR_BTN, theme === 'dark' ? 'text-indigo-400/70' : 'text-amber-400/70')}
270-
onClick={() => setTheme(theme === 'dark' ? 'light' : 'dark')}
427+
className={TOOLBAR_BTN}
428+
onClick={() => setUnit(unit === 'metric' ? 'imperial' : 'metric')}
271429
type="button"
272430
>
273-
{theme === 'dark' ? <Moon className="h-3.5 w-3.5" /> : <Sun className="h-3.5 w-3.5" />}
431+
<span className="font-semibold text-[10px]">{unit === 'metric' ? 'm' : 'ft'}</span>
274432
</button>
275433
</ToolbarTooltip>
276434
)
@@ -349,10 +507,13 @@ export function CommunityViewerToolbarRight() {
349507
<div className={TOOLBAR_CONTAINER}>
350508
<LevelModeToggle />
351509
<WallModeToggle />
510+
<RenderModeMenu />
511+
<SceneThemeMenu />
512+
<EdgesMenu />
352513
<GridVisibilityToggle />
514+
<ShadowsToggle />
353515
<div className="my-1.5 w-px bg-border/50" />
354516
<UnitToggle />
355-
<ThemeToggle />
356517
<CameraModeToggle />
357518
<div className="my-1.5 w-px bg-border/50" />
358519
<WalkthroughButton />

apps/ifc-converter/components/PreviewToolbar.tsx

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
import { type AnyNode, type LevelNode, useScene } from '@pascal-app/core'
1212
import { useViewer } from '@pascal-app/viewer'
13-
import { Box, Grid2x2, Layers, Layers2, Maximize, Moon, ScanLine, Square, Sun } from 'lucide-react'
13+
import { Box, Grid2x2, Layers, Layers2, Maximize, ScanLine, Square } from 'lucide-react'
1414
import { type ReactNode, useMemo } from 'react'
1515

1616
const levelModes = ['stacked', 'solo', 'exploded', 'manual'] as const
@@ -65,8 +65,6 @@ function ToolButton({
6565
export function PreviewToolbar() {
6666
const cameraMode = useViewer((s) => s.cameraMode)
6767
const setCameraMode = useViewer((s) => s.setCameraMode)
68-
const theme = useViewer((s) => s.theme)
69-
const setTheme = useViewer((s) => s.setTheme)
7068
const showGrid = useViewer((s) => s.showGrid)
7169
const setShowGrid = useViewer((s) => s.setShowGrid)
7270
const levelMode = useViewer((s) => s.levelMode)
@@ -115,13 +113,6 @@ export function PreviewToolbar() {
115113
label="Grid"
116114
onClick={() => setShowGrid(!showGrid)}
117115
/>
118-
119-
<ToolButton
120-
active={theme === 'dark'}
121-
icon={theme === 'dark' ? <Moon className="size-3.5" /> : <Sun className="size-3.5" />}
122-
label={theme === 'dark' ? 'Dark' : 'Light'}
123-
onClick={() => setTheme(theme === 'dark' ? 'light' : 'dark')}
124-
/>
125116
</div>
126117
)
127118
}

packages/core/src/events/bus.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ import type {
66
BuildingNode,
77
CeilingNode,
88
ChimneyNode,
9-
DormerNode,
109
ColumnNode,
1110
DoorNode,
11+
DormerNode,
1212
ElevatorNode,
1313
FenceNode,
1414
GuideNode,
@@ -21,8 +21,8 @@ import type {
2121
ShelfNode,
2222
SiteNode,
2323
SkylightNode,
24-
SolarPanelNode,
2524
SlabNode,
25+
SolarPanelNode,
2626
SpawnNode,
2727
StairNode,
2828
StairSegmentNode,

packages/core/src/registry/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ export type {
7070
SnapServicesLike,
7171
SurfacePoint,
7272
SurfaceQuery,
73+
SurfaceRole,
7374
SurfacesConfig,
7475
SystemContribution,
7576
ToolHint,

packages/core/src/registry/types.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,11 +512,21 @@ export type Plugin = {
512512

513513
export type AnyNodeDefinition = NodeDefinition<ZodObject<any>>
514514

515+
export type SurfaceRole =
516+
| 'wall'
517+
| 'floor'
518+
| 'ceiling'
519+
| 'roof'
520+
| 'joinery'
521+
| 'glazing'
522+
| 'furnishing'
523+
515524
export type NodeDefinition<S extends ZodObject<any>> = {
516525
kind: string
517526
schemaVersion: number
518527
schema: S
519528
category: NodeCategory
529+
surfaceRole?: SurfaceRole
520530

521531
defaults: () => Omit<z.infer<S>, 'id' | 'type'>
522532
migrate?: Record<number, (old: unknown) => unknown>

0 commit comments

Comments
 (0)