AggregateRootTestCase::expectsException() does not require exception to be thrown

[ergosarapu]

Following test passes, even though notThrowingFunction() does not throw. Could it be a bug?

        $this
        ->given(new SomeEvent())
        ->when(fn (MyAggregate $aggregate) => $aggregate->notThrowingFunction())
        ->then()
        ->expectsException(\LogicException::class);

I noticed that handleException() is only called when exception actually occurs.

event-sourcing-phpunit/src/Test/AggregateRootTestCase.php

Line 151 in 29002a3

if ($this->expectedException) {

Note that using phpunit's TestCase::expectException() properly fails test if exception is not thrown. Maybe I am not understanding the difference between TestCase::expectException() and AggregateRootTestCase::expectsException() properly.

[DanielBadura]

The goal was that this is behaving the same as phpunit's - so this should be updated. Thanks for reporting this.

Probably adding add here directly after the try catch:

event-sourcing-phpunit/src/Test/AggregateRootTestCase.php

Lines 119 to 124 in 29002a3

	} catch (Throwable $throwable) {
	$this->handleException($throwable);
	return $this;
	}

a check like $this->expectedExceptionWasNotThrown() which then asserts if values where given.

[DanielBadura]

As an update on this: I got it already working but the testing on this feature itself is a bit harder and I'm not sure yet how to solve it. 😅

see here: #15