fix: default subsegments to an empty array

willtj · web-flow · commit efcb560cbb14 · 2020-10-05T10:57:40.000+01:00
`$segment-&gt;jsonSerialize()` returns subsegments as `null` if it's empty.
diff --git a/src/Submission/DaemonSegmentSubmitter.php b/src/Submission/DaemonSegmentSubmitter.php
@@ -88,7 +88,7 @@ private function submitFragmented(Segment $segment)
     {
         $rawSegment = $segment->jsonSerialize();
         /** @var Segment[] $subsegments */
-        $subsegments = $rawSegment['subsegments'];
+        $subsegments = $rawSegment['subsegments'] ?? [];
         unset($rawSegment['subsegments']);
         $this->submitOpenSegment($rawSegment);
 

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ private function submitFragmented(Segment $segment)`
`88`	`88`	`{`
`89`	`89`	`$rawSegment = $segment->jsonSerialize();`
`90`	`90`	`/** @var Segment[] $subsegments */`
`91`		`- $subsegments = $rawSegment['subsegments'];`
	`91`	`+ $subsegments = $rawSegment['subsegments'] ?? [];`
`92`	`92`	`unset($rawSegment['subsegments']);`
`93`	`93`	`$this->submitOpenSegment($rawSegment);`
`94`	`94`