Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux support #3

Open
oneiricbotcelot opened this issue Jan 28, 2022 · 13 comments
Open

Linux support #3

oneiricbotcelot opened this issue Jan 28, 2022 · 13 comments

Comments

@oneiricbotcelot
Copy link

Hi! First of all: Thanks for providing the code and the great idea.

Secondly, is there any chance for Linux support?

@patrikzudel
Copy link
Owner

patrikzudel commented Jan 28, 2022

I will optimize the volume controlling code so it can easily be ported to Linux, atm its scrappy as I was just hurrying finishing it yesterday so I could use it today. I will update you on the progress.

Added Linux support to the TBA features.

@oneiricbotcelot
Copy link
Author

Thank you for the fast reponse, I will wait patiently. Good luck in your next officials!

@nakrule
Copy link

nakrule commented Apr 21, 2022

Any news on this feature?

@GreatBigWhiteWorld
Copy link

Any update? Seriously need this.

@patrikzudel
Copy link
Owner

I don't use Linux for gaming at the moment so do to my time constraints this is not my priority atm.
I think implementing Linux support should be straight forward though, as this is an open project anyone can give it a try! In case someone does it I'll check it out and approve their pull request!

@TosiRikhard
Copy link

I have a fork made of this that works at least with linux mint, might need tweaking for other distros and might contain bad habits. Works with running main.py from terminal, no compiled binaries etch done.

https://github.com/Cookiebot1/PatrikZeros-CSGO-Sound-Fix-Linux

@oneiricbotcelot
Copy link
Author

oneiricbotcelot commented Dec 8, 2022

I have a fork made of this that works at least with linux mint, might need tweaking for other distros and might contain bad habits. Works with running main.py from terminal, no compiled binaries etch done.

https://github.com/Cookiebot1/PatrikZeros-CSGO-Sound-Fix-Linux

I tried to install it on Arch, but it doesn't seem to work. I saw your requirements.txt with the three python packages. I could install pycaw and comtypes with pip, but I get an error on 'pip install pypiwin32'. The package seems to be faulty.

` File "/tmp/pip-download-2_xa2zmf/pypiwin32_b6ecf34a910543a1884099ba098942f1/setup.py", line 121
print "Building pywin32", pywin32_version
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?
[end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
`

@TosiRikhard
Copy link

I have a fork made of this that works at least with linux mint, might need tweaking for other distros and might contain bad habits. Works with running main.py from terminal, no compiled binaries etch done.
https://github.com/Cookiebot1/PatrikZeros-CSGO-Sound-Fix-Linux

I tried to install it on Arch, but it doesn't seem to work. I saw your requirements.txt with the three python packages. I could install pycaw and comtypes with pip, but I get an error on 'pip install pypiwin32'. The package seems to be faulty.

` File "/tmp/pip-download-2_xa2zmf/pypiwin32_b6ecf34a910543a1884099ba098942f1/setup.py", line 121 print "Building pywin32", pywin32_version ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)? [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip. error: metadata-generation-failed

× Encountered error while generating package metadata. ╰─> See above for output.

note: This is an issue with the package mentioned above, not pip. `

Sorry, I haven't modified that file, it is what the original (windows version) needs, I'm not sure if those are needed (I did not install them), and it works for me. Have you tried what happens if you only run the main.py from terminal, is it throwing any errors?

@oneiricbotcelot
Copy link
Author

If I start main.py I don't receive any terminal output at all.

@TosiRikhard
Copy link

Then it is probably working! Try launching csgo and see if the settings change the volume :)
I did not add any printing to the terminal.

@oneiricbotcelot
Copy link
Author

oneiricbotcelot commented Dec 9, 2022

It is sadly not working.

The problem with the python package pypiwin32 is an incompatibility with python 3, the package hasn't been updated in a long time.

Maybe others can provide more information.

@TosiRikhard
Copy link

I don't think you need that package installed, there is no script that utilizes anything from it on my version. If it do not work then probably something is not the same on arch as on ubuntu, and the volume control fails because of it.

@patrikzudel
Copy link
Owner

patrikzudel commented Dec 9, 2022

I have a fork made of this that works at least with linux mint, might need tweaking for other distros and might contain bad habits. Works with running main.py from terminal, no compiled binaries etch done.

https://github.com/Cookiebot1/PatrikZeros-CSGO-Sound-Fix-Linux

Nice! Good job and thanks for contributing! When I will have the time I'll try to merge the two versions so there will hopefully be one version that works on both OS's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants