Skip to content

Commit 0e5884c

Browse files
authored
feat(high contrast): add border to some hover states
2 parents e336938 + 43eb2ba commit 0e5884c

File tree

6 files changed

+1988
-771
lines changed

6 files changed

+1988
-771
lines changed

packages/module/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
},
5151
"devDependencies": {
5252
"@octokit/rest": "^18.0.0",
53-
"@patternfly/documentation-framework": "6.8.2",
53+
"@patternfly/documentation-framework": "6.28.9",
5454
"@patternfly/patternfly": "^6.1.0",
5555
"@patternfly/patternfly-a11y": "^4.3.1",
5656
"@patternfly/react-code-editor": "^6.1.0",

packages/module/patternfly-docs/patternfly-docs.config.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,7 @@
22
module.exports = {
33
sideNavItems: [{ section: 'extensions' }],
44
topNavItems: [],
5-
port: 8006
5+
port: 8006,
6+
hasThemeSwitcher: true,
7+
hasHighContrastSwitcher: true
68
};

packages/module/sass/react-catalog-view-extension/_filter-side-panel.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@
3131
margin-block-start: 0;
3232
}
3333

34-
&:hover {
35-
background-color: var(--pf-t--global--background--color--action--plain--hover);
36-
}
37-
3834
.pf-v6-c-check__label {
3935
min-height: var(--pf-t--global--spacer--md);
4036
padding: var(--pf-t--global--spacer--sm) var(--pf-t--global--spacer--xs);

packages/module/sass/react-catalog-view-extension/_vertical-tabs.scss

Lines changed: 26 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,28 +5,48 @@
55

66
.vertical-tabs-pf {
77
margin-block-end: 0;
8+
padding-block-start: var(--pf-t--global--spacer--xs);
89
}
910
}
1011

1112
.vertical-tabs-pf-tab {
1213
margin-block-start: var(--pf-t--global--spacer--sm);
14+
padding-inline-start: 0;
1315
position: relative;
1416

17+
& .vertical-tabs-pf-tab {
18+
margin-inline-start: var(--pf-t--global--spacer--md);
19+
}
20+
1521
> a {
1622
color: var( --pf-t--global--text--color--regular);
1723
text-decoration: none;
18-
display: inline-block;
19-
font-size: 13px;
20-
padding: var(--pf-t--global--spacer--sm) var(--pf-t--global--spacer--xs) var(--pf-t--global--spacer--sm) var(--pf-t--global--spacer--md);
24+
display: block;
25+
margin-inline-start: var(--pf-t--global--spacer--md);
26+
padding: var(--pf-t--global--spacer--xs) var(--pf-t--global--spacer--sm) var(--pf-t--global--spacer--xs) var(--pf-t--global--spacer--sm);
2127
vertical-align: top;
22-
width: 100%;
2328
word-break: break-word;
2429
border-radius: var(--pf-t--global--border--radius--small);
30+
position: relative;
31+
32+
&::after {
33+
content: '';
34+
position: absolute;
35+
inset: 0;
36+
border: var(--pf-t--global--border--width--action--plain--default) solid var(--pf-t--global--border--color--high-contrast);
37+
border-radius: inherit;
38+
pointer-events: none;
39+
}
2540

2641
&:hover,
2742
&:focus {
2843
background-color: var(--pf-t--global--background--color--action--plain--hover);
2944
text-decoration: none;
45+
46+
&::after {
47+
border-color: var(--pf-t--global--border--color--high-contrast);
48+
border-width: var(--pf-t--global--border--width--action--plain--hover);
49+
}
3050
}
3151

3252
&.no-wrap {
@@ -42,28 +62,19 @@
4262
}
4363

4464
&.active {
45-
> a {
46-
4765
&::before {
4866
background: var( --pf-t--global--border--color--brand--clicked);
4967
content: "\00a0"; //  
50-
left: 0;
68+
inset-inline-start: 0;
69+
inset-block-start: var(--pf-t--global--spacer--xs);
5170
position: absolute;
5271
width: var(--pf-t--global--border--width--extra-strong);
5372
}
54-
}
5573
}
5674

5775
&:first-of-type {
5876
margin-block-start: 0;
5977
}
60-
61-
> .vertical-tabs-pf {
62-
> .vertical-tabs-pf-tab {
63-
position: initial;
64-
padding-inline-start: var(--pf-t--global--spacer--md);
65-
}
66-
}
6778
}
6879

6980
.vertical-tabs-pf.restrict-tabs {

packages/module/src/components/react-catalog-view-extension.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)