Skip to content

Commit b51caaa

Browse files
committed
feat(loading): Fix the cypress tests
1 parent bdcd0ee commit b51caaa

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

cypress/component/DataViewTableBasic.cy.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ describe('DataViewTableBasic', () => {
5050

5151
cy.mount(
5252
<DataView activeState="empty">
53-
<DataViewTableBasic aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} states={{ empty: "No data found" }} />
53+
<DataViewTableBasic aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} bodyStates={{ empty: <div data-ouia-component-id="data-tr-empty">No data found</div> }} />
5454
</DataView>
5555
);
5656

@@ -69,7 +69,7 @@ describe('DataViewTableBasic', () => {
6969

7070
cy.mount(
7171
<DataView activeState="error">
72-
<DataViewTableBasic aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} bodyStates={{ error: "Some error" }} />
72+
<DataViewTableBasic aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} bodyStates={{ error: <div data-ouia-component-id="data-tr-error">Some error</div> }} />
7373
</DataView>
7474
);
7575

@@ -88,7 +88,7 @@ describe('DataViewTableBasic', () => {
8888

8989
cy.mount(
9090
<DataView activeState="loading">
91-
<DataViewTableBasic aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} bodyStates={{ loading: "Data is loading" }} />
91+
<DataViewTableBasic aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} bodyStates={{ loading: <div data-ouia-component-id="data-tr-loading">Data is loading</div> }} />
9292
</DataView>
9393
);
9494

cypress/component/DataViewTableTree.cy.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ describe('DataViewTableTree', () => {
132132

133133
cy.mount(
134134
<DataView activeState="empty">
135-
<DataViewTable isTreeTable aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} bodyStates={{ empty: "No data found" }} />
135+
<DataViewTable isTreeTable aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} bodyStates={{ empty: <div data-ouia-component-id="tree-tr-empty">No data found</div> }} />
136136
</DataView>
137137
);
138138

@@ -151,7 +151,7 @@ describe('DataViewTableTree', () => {
151151

152152
cy.mount(
153153
<DataView activeState="error">
154-
<DataViewTable isTreeTable aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} bodyStates={{ error: "Some error" }} />
154+
<DataViewTable isTreeTable aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} bodyStates={{ error: <div data-ouia-component-id="tree-tr-error">Some error</div> }} />
155155
</DataView>
156156
);
157157

@@ -161,16 +161,16 @@ describe('DataViewTableTree', () => {
161161
cy.get('[data-ouia-component-id="data-th-3"]').contains('Workspaces');
162162
cy.get('[data-ouia-component-id="data-th-4"]').contains('Last commit');
163163

164-
cy.get('[data-ouia-component-id="data-tr-error"]').should('be.visible');
165-
cy.get('[data-ouia-component-id="data-tr-error"]').contains('Some error');
164+
cy.get('[data-ouia-component-id="tree-tr-error"]').should('be.visible');
165+
cy.get('[data-ouia-component-id="tree-tr-error"]').contains('Some error');
166166
});
167167

168168
it('renders a tree data view table with a loading state', () => {
169169
const ouiaId = 'tree';
170170

171171
cy.mount(
172172
<DataView activeState="loading">
173-
<DataViewTable isTreeTable aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} bodyStates={{ loading: "Data is loading" }} />
173+
<DataViewTable isTreeTable aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} bodyStates={{ loading: <div data-ouia-component-id="tree-tr-loading">Data is loading</div> }} />
174174
</DataView>
175175
);
176176

cypress/e2e/DataView.spec.cy.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ describe('Test the Data view docs page', () => {
55

66
cy.visit('http://localhost:8006/extensions/data-view/layout');
77

8-
cy.get(`[data-ouia-component-id="${ouiaId}Heade-pagination"]`).should('exist');
9-
cy.get(`[data-ouia-component-id="${ouiaId}Heade-bulk-select"]`).should('exist');
8+
cy.get(`[data-ouia-component-id="${ouiaId}Header-pagination"]`).should('exist');
9+
cy.get(`[data-ouia-component-id="${ouiaId}Header-bulk-select"]`).should('exist');
1010

1111
cy.get(`[data-ouia-component-id="${ouiaId}Footer-pagination"]`).should('exist');
1212
cy.get(`[data-ouia-component-id="${ouiaId}Footer-bulk-select"]`).should('not.exist');

0 commit comments

Comments
 (0)