Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to build the project #34

Closed
Nilzor opened this issue Dec 22, 2015 · 12 comments
Closed

Document how to build the project #34

Nilzor opened this issue Dec 22, 2015 · 12 comments

Comments

@Nilzor
Copy link

Nilzor commented Dec 22, 2015

The README.md documents how to use the plugin but not how to build it. I'd like to fork and possibly contribute to the project but I'm new to plugin development, so a quick 1-2-3 cookbook style introduction on how to build the project would be nice.

@hibob224
Copy link

Would be appreciated as well, have managed to get the plugin to build but when attempting to use any command the plugin can't find any devices.

@julioz
Copy link

julioz commented Feb 14, 2016

I would also love to contribute to this project, but a quick cookbook as @Nilzor mentioned would be great as a "getting started". @pbreault Can you help us here? I'm pretty sure this will make more PRs to come in the future of this amazing plugin.

@eliasbagley
Copy link

+1

@fmatosqg
Copy link
Contributor

fmatosqg commented Apr 1, 2016

+1.

I've managed to get an almost successfull build with gradle, but since then I changed computers and need to start from scratch again.

@pbreault would you be interested in merging a gradle build in case mine works? It drops the configuration to a minimum, and I'd be providing the documentation for it.

Edit:
I was able to build, but since I get a run time failure it isn't fair to say I know how to build properly. I'll keep trying as this plugin has a lot of potential and there are heaps of suggestions. BTW opened #41, in case someone knows how to address that issue would mean I'm able close this one.

@pbreault
Copy link
Owner

pbreault commented Apr 7, 2016

@fmatosqg I would love it, creating a working gradle build is on my radar but I haven't got around to doing it yet. I tried to use https://github.com/JetBrains/gradle-intellij-plugin a while back but couldn't get it to work because it only fetches the core intellij distribution without any plugin... which means that adb idea can't compile since it has a strong dependency on the android plugin jar.

I can try to help you troubleshoot your issue if you submit a PR.

Meanwhile I'll flesh out the documentation on how to setup the project (which is not exactly easy because of the aforementioned dependency on the android plugin)
Thanks

@fmatosqg
Copy link
Contributor

fmatosqg commented Apr 7, 2016

I created #43 with an included android.jar copied from AS preview. What I did was download the latest preview from the canary channel and copy that single jar over this project, to be able to compile against the newest version of this dependency.

As I noticed you're making updates to make the plugin compatible with the bleeding edge of Android Studio canary, that's obviously not on the map for the gradle-intellij-plugin so far, so there's no easy way around it. I commented on it with Zolotov who's been very helpful and appears to be a driving force behind that plugin (https://intellij-support.jetbrains.com/hc/en-us/community/posts/206749645-Building-plugins-that-depends-on-android-using-gradle-plugin?page=1#community_comment_207150085).

If you wanted to build an intellij compatible version you can simply tap into the android plugin for the latest intellij version by including "plugin: android" in the gradle file, which I probably should have turned off on that PR. I'm still to understand if there's a repository anywhere to download Android Studio versions of that android.jar file, which will certainly solve the problem for adb-plugin as far as I've tested..

@fmatosqg
Copy link
Contributor

Should be covered by https://github.com/pbreault/adb-idea/blob/master/DEVELOP.md, can we close this issue?

@TomasYu
Copy link

TomasYu commented Mar 29, 2017

how to build your project ? I have try very times and failed. help me, I use Intellij .

@AITUncle
Copy link

AITUncle commented Feb 8, 2020

Should be covered by https://github.com/pbreault/adb-idea/blob/master/DEVELOP.md, can we close this issue?

@fmatosqg
Misspelling task name .

look at this:
https://github.com/vectorzeng/adb-idea/blob/master/DEVELOP.md

@fmatosqg
Copy link
Contributor

I'd vote to close it :)
Let me know if something is missing and I'd add it.

@AITUncle
Copy link

Should be covered by https://github.com/pbreault/adb-idea/blob/master/DEVELOP.md, can we close this issue?

@fmatosqg
can you merge the pull request?
#116

@Nilzor
Copy link
Author

Nilzor commented Feb 24, 2020

DEVELOP.md should cover it yes (haven't tested though). Nice to be able to close a 4+ year old issue :-)

@Nilzor Nilzor closed this as completed Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants