Merge branch 'PMM-7470_Wrong_IndexStatsCollections_flag' into release-0.20.2

Author: percona-csalguero

.github/workflows/go.yml

@@ -47,7 +47,7 @@ jobs:
     steps:
       - name: Set up Go release
         if: matrix.go-version != 'tip'
-        uses: percona-platform/setup-go@v2.1.1
+        uses: actions/setup-go@v2
         with:
           go-version: ${{ matrix.go-version }}
 
@@ -57,8 +57,8 @@ jobs:
           git clone --depth=1 https://go.googlesource.com/go $HOME/gotip
           cd $HOME/gotip/src
           ./make.bash
-          echo "::set-env name=GOROOT::$HOME/gotip"
-          echo "::add-path::$HOME/gotip/bin"
+          echo "GOROOT=$HOME/gotip" >> $GITHUB_ENV
+          echo "$HOME/gotip/bin" >> $GITHUB_PATH
 
       - name: Check out code into the Go module directory
         uses: actions/checkout@v2

main.go

@@ -18,6 +18,7 @@ package main
 
 import (
 	"fmt"
+	"log"
 	"strings"
 
 	"github.com/alecthomas/kong"
@@ -72,6 +73,15 @@ func main() {
 		return
 	}
 
+	e, err := buildExporter(opts)
+	if err != nil {
+		log.Fatal(err)
+	}
+
+	e.Run()
+}
+
+func buildExporter(opts GlobalFlags) (*exporter.Exporter, error) {
 	log := logrus.New()
 
 	levels := map[string]logrus.Level{
@@ -95,7 +105,7 @@ func main() {
 	exporterOpts := &exporter.Opts{
 		CollStatsCollections:    strings.Split(opts.CollStatsCollections, ","),
 		CompatibleMode:          opts.CompatibleMode,
-		IndexStatsCollections:   strings.Split(opts.CollStatsCollections, ","),
+		IndexStatsCollections:   strings.Split(opts.IndexStatsCollections, ","),
 		Logger:                  log,
 		Path:                    opts.WebTelemetryPath,
 		URI:                     opts.URI,
@@ -107,8 +117,8 @@ func main() {
 
 	e, err := exporter.New(exporterOpts)
 	if err != nil {
-		log.Fatal(err)
+		return nil, err
 	}
 
-	e.Run()
+	return e, nil
 }

main_test.go

@@ -0,0 +1,27 @@
+package main
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestBuildExporter(t *testing.T) {
+	opts := GlobalFlags{
+		CollStatsCollections:  "c1,c2,c3",
+		IndexStatsCollections: "i1,i2,i3",
+		URI:                   "mongodb://usr:[email protected]/",
+		GlobalConnPool:        false, // to avoid testing the connection
+		WebListenAddress:      "localhost:12345",
+		WebTelemetryPath:      "/mymetrics",
+		LogLevel:              "debug",
+
+		DisableDiagnosticData:   true,
+		DisableReplicasetStatus: true,
+
+		CompatibleMode: true,
+	}
+
+	_, err := buildExporter(opts)
+	assert.NoError(t, err)
+}