PSMDB-1078: fix TemporaryRecordStoreSimple test to handle ObjectIsBusy from dropIdent

The TemporaryRecordStoreSimple test can fail when dropIdent() returns
ErrorCodes::ObjectIsBusy, which occurs when the ident is temporarily in
use. This is a transient condition that should be retried.

This change adds retry logic to the test, retrying dropIdent() until it
succeeds when ObjectIsBusy is returned. This matches the pattern used in
production code (e.g. WiredTigerKVEngine::dropIdentForImport).

Author: plebioda

src/mongo/db/storage/kv/kv_engine_test_harness.cpp

@@ -389,7 +389,15 @@ TEST_F(KVEngineTestHarness, TemporaryRecordStoreSimple) {
         engine->checkpoint();
 
         WriteUnitOfWork wuow(opCtx.get());
-        ASSERT_OK(engine->dropIdent(shard_role_details::getRecoveryUnit(opCtx.get()), ident));
+
+        // Drop the temporary record store in a loop in case it returns ErrorCodes::ObjectIsBusy
+        Status status = Status::OK();
+        do {
+            std::this_thread::yield();
+            status = engine->dropIdent(shard_role_details::getRecoveryUnit(opCtx.get()), ident);
+            ASSERT(status.isOK() || status == ErrorCodes::ObjectIsBusy);
+        } while (status == ErrorCodes::ObjectIsBusy);
+
         wuow.commit();
     }
 }
@@ -1250,8 +1258,7 @@ TEST_F(DurableCatalogTest, Idx1) {
         md.nss = NamespaceString::createNamespaceString_forTest(boost::none, "a.b");
 
         BSONCollectionCatalogEntry::IndexMetaData imd;
-        imd.spec = BSON("name"
-                        << "foo");
+        imd.spec = BSON("name" << "foo");
         imd.ready = false;
         imd.multikey = false;
         imd.isBackgroundSecondaryBuild = false;
@@ -1285,8 +1292,7 @@ TEST_F(DurableCatalogTest, Idx1) {
         putMetaData(opCtx, catalog.get(), catalogId, md);  // remove index
 
         BSONCollectionCatalogEntry::IndexMetaData imd;
-        imd.spec = BSON("name"
-                        << "foo");
+        imd.spec = BSON("name" << "foo");
         imd.ready = false;
         imd.multikey = false;
         imd.isBackgroundSecondaryBuild = false;
@@ -1347,8 +1353,7 @@ TEST_F(DurableCatalogTest, DirectoryPerDb1) {
         md.nss = NamespaceString::createNamespaceString_forTest(boost::none, "a.b");
 
         BSONCollectionCatalogEntry::IndexMetaData imd;
-        imd.spec = BSON("name"
-                        << "foo");
+        imd.spec = BSON("name" << "foo");
         imd.ready = false;
         imd.multikey = false;
         imd.isBackgroundSecondaryBuild = false;
@@ -1406,8 +1411,7 @@ TEST_F(DurableCatalogTest, Split1) {
         md.nss = NamespaceString::createNamespaceString_forTest(boost::none, "a.b");
 
         BSONCollectionCatalogEntry::IndexMetaData imd;
-        imd.spec = BSON("name"
-                        << "foo");
+        imd.spec = BSON("name" << "foo");
         imd.ready = false;
         imd.multikey = false;
         imd.isBackgroundSecondaryBuild = false;
@@ -1465,8 +1469,7 @@ TEST_F(DurableCatalogTest, DirectoryPerAndSplit1) {
         md.nss = NamespaceString::createNamespaceString_forTest(boost::none, "a.b");
 
         BSONCollectionCatalogEntry::IndexMetaData imd;
-        imd.spec = BSON("name"
-                        << "foo");
+        imd.spec = BSON("name" << "foo");
         imd.ready = false;
         imd.multikey = false;
         imd.isBackgroundSecondaryBuild = false;
@@ -1529,10 +1532,7 @@ DEATH_TEST_REGEX_F(DurableCatalogTest,
         uow.commit();
     }
 
-    IndexDescriptor desc("",
-                         BSON("v"
-                              << "1"
-                              << "key" << BSON("a" << 1)));
+    IndexDescriptor desc("", BSON("v" << "1" << "key" << BSON("a" << 1)));
     std::unique_ptr<SortedDataInterface> sorted;
     {
         auto clientAndCtx = makeClientAndCtx("opCtx");