-
Notifications
You must be signed in to change notification settings - Fork 5
PMM-14138 Upgrade packages, fix lint errors and enforce lint with git… #994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
travagliad
wants to merge
10
commits into
v3
Choose a base branch
from
PMM-14138-fix-eslint
base: v3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PMM-7: Fix anotations and pgsql dashboards * PMM-7: Fix pgsql dashboards * PMM-7: Fix pgsql dashboards * PMM-7: Fix pgsql dashboards * PMM-7: Fix pgsql dashboards * PMM-7: Fix pgsql dashboards * PMM-7: Fix pgsql dashboards * PMM-7: Fix pgsql dashboards * PMM-7: Fix pgsql dashboards * PMM-7: Fix pgsql dashboards * PMM-7: Fix pgsql dashboards * PMM-7: Fix pgsql dashboards * PMM-7: Fix mongo upgrade * PMM-7: Fix external upgrade * PMM-7: Fix external upgrade * PMM-7: Fix qan * PMM-7: Fix qan * PMM-7: Fix qan * PMM-7: Fix qan * PMM-7: Fix qan * PMM-7: Fix qan * PMM-7: PR comment fixes * PMM-7: PR comment fixes
|
PMM-UI-Tests action: |
yurkovychv
reviewed
Oct 9, 2025
| alertRulesPage.openMoreMenu(ruleName); | ||
| I.click(alertRulesPage.buttons.deleteAlertRule); | ||
| I.waitForText(alertRulesPage.messages.confirmDelete, iaCommon.elements.modalDialog); | ||
| I.waitForText(alertRulesPage.messages.confirmDelete, undefined, iaCommon.elements.modalDialog); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undefined?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades and fixes dependencies, resolves lint errors, and enforces linting via git hooks.
Packages updated
Packages not updated (
npm outdated)@playwright/testandplaywright: Remained at 1.44.1 (latest is 1.54.1). Updating these would upgrade the browser, causing failures with Grafana (root cause unknown). To avoid breaking tests, these were not updated.mongodb: Remained at 3.7.2 (latest is 6.17.0). Updating this caused all MongoDB connection tests to fail due to breaking changes. This will be addressed in a separate ticket.@types/node,@typescript-eslint/eslint-plugin,@typescript-eslint/parser,typescript-eslint: Minor updates available, but not critical for current functionality.Security
npm auditreports 0 vulnerabilities.Other activities