Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to OPAL Client for specifying HTTPX client timeout #756

Open
ben-kiplot opened this issue Feb 10, 2025 · 1 comment
Open

Add option to OPAL Client for specifying HTTPX client timeout #756

ben-kiplot opened this issue Feb 10, 2025 · 1 comment

Comments

@ben-kiplot
Copy link

Is your feature request related to a problem? Please describe.
OPAL Client does not support specifying a HTTP timeout when using the HTTPX client (OPAL_HTTP_FETCHER_PROVIDER_CLIENT=httpx) - the default of 5 seconds is always used.

Describe the solution you'd like
The HTTPX client timeout can be specified via environment variable

Describe alternatives you've considered
N/A

Additional context
The HTTPX client supports specifying a timeout when creating the AsyncClient which could be used here: https://github.com/permitio/opal/blob/master/packages/opal-common/opal_common/fetcher/providers/http_fetch_provider.py#L76

https://www.python-httpx.org/advanced/timeouts/

@omer9564
Copy link
Contributor

Hey @ben-kiplot ,
Thanks for opening the issue, we'll open an internal ticket for that.
Of course, we'd be happy to accept a contribution if you'd like to 🤩 ( if this is urgent for you I'd suggest contributing as I currently can't guarantee any timeline on our side, I can also share contributing guidelines if you want to )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants