You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The -70 is a vertical margin. However, the fact that we have a hardcoded value is bad -- instead the value should change based on window size. Further, why is there only a vertical margin and not a horizontal margin?
@Raidakarim this is part of #9, which you self-assigned; in fact, I explicitly link to this line of code in that issue.
I would prefer if we solve all facets of one issue at once, as opposed to breaking off subparts of the issue for other people. "Responsiveness" is one desired feature, so all the changes addressing responsiveness should be in one PR/change, so that once that issue is closed we are confident that the app is responsive. Therefore, I am closing this issue, since the -70 should be addressed by #9 .
Figure out what -70 is doing in this line of code, perhaps remove magic number and test for different screen sizes.
The text was updated successfully, but these errors were encountered: