Skip to content

Investigate -70 in Video Window Height #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Raidakarim opened this issue Apr 18, 2023 · 1 comment
Closed

Investigate -70 in Video Window Height #21

Raidakarim opened this issue Apr 18, 2023 · 1 comment
Assignees

Comments

@Raidakarim
Copy link
Contributor

Figure out what -70 is doing in this line of code, perhaps remove magic number and test for different screen sizes.

@amalnanavati
Copy link
Contributor

amalnanavati commented Apr 19, 2023

The -70 is a vertical margin. However, the fact that we have a hardcoded value is bad -- instead the value should change based on window size. Further, why is there only a vertical margin and not a horizontal margin?

@Raidakarim this is part of #9, which you self-assigned; in fact, I explicitly link to this line of code in that issue.

I would prefer if we solve all facets of one issue at once, as opposed to breaking off subparts of the issue for other people. "Responsiveness" is one desired feature, so all the changes addressing responsiveness should be in one PR/change, so that once that issue is closed we are confident that the app is responsive. Therefore, I am closing this issue, since the -70 should be addressed by #9 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants