Merge pull request #239 from pharmaverse/238-unexpected-lintr-message

Closes #238

Author: kodesiba

R/get.R

@@ -304,15 +304,16 @@ get_unapproved_use <- function(approved_packages, used_packages) {
 #'
 get_lint_results <- function(file) {
 
-   if (!requireNamespace("lintr", quietly = TRUE)) {
-      message(strwrap("Linting will not be included in the log. Install the
-         lintr package to use the log.rx.lint feature.",
-         prefix = " ", initial = ""))
-      return()
-   }
-
    # lint file if option is turned on
    if (!is.logical(getOption('log.rx.lint'))) {
+
+      if (!requireNamespace("lintr", quietly = TRUE)) {
+         message(strwrap("Linting will not be included in the log. Install the
+         lintr package to use the log.rx.lint feature.",
+            prefix = " ", initial = ""))
+         return()
+      }
+
       lintr::lint(file, getOption('log.rx.lint'))
    }
 }

tests/testthat/test-get.R

@@ -174,6 +174,12 @@ test_that("lint returns expected result when using the default log.rx.lint optio
    expect_identical(get_lint_results(filename), NULL)
 })
 
+test_that("get_lint_results does not return a message if the option set to FALSE", {
+   options(log.rx.lint = FALSE)
+   filename <- test_path("ref", "ex6.R")
+   expect_no_message(get_lint_results(filename))
+})
+
 test_that("lint returns expected result when option is changed", {
    skip_if_not_installed("lintr")