-
Notifications
You must be signed in to change notification settings - Fork 8
Changes needed to localeData.json #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
From @solaolateju in phetsims/chipper#1332 (comment) You are right. There are no sim translations for both affected locales. ![]() ![]() |
This is our first batch of changes to localeData.json since the initial MR over in phetsims/joist#963. @jonathanolson mentioned the following steps:
|
IANA list for "validation". @jonathanolson and I discussed perhaps checking this into babel: https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry |
…new locale pr, and adding bcp 47 values, see #26
@mattpen when you're back, I'll want to coordinate with you on whether this would potentially break anything. Patch to update localeData is in the commit above (on the bcp47 branch in babel). |
EDIT: comment deleted, looks like this was already discussed. |
I imported the changes into the website, it actually looks like an improvement as Java is now recognizing the new locales and providing localized names. @jonathanolson - we have a production deployment planned next week, I think after that happens this can proceed. |
Sounds good! Thanks |
From phetsims/chipper#1332 (comment), @solaolateju and I have found some changes we want to make in the localeData for all sims.
rh
roh
Romansh: It should berm
(right) and notrh
(wrong).nk
nor
Norwegian: similarly, it should beno
(right) and notnk
(wrong).ar_EG
should add a locale3 calledarz
. That is in the IANA list. I'm not sure about the process for this. It may require a rebuilt of all sims to support it as a query parameter.pr
I will coordinate with @jonathanolson to make this happen.
The text was updated successfully, but these errors were encountered: