Skip to content

Changes needed to localeData.json #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks
zepumph opened this issue Feb 18, 2025 · 7 comments
Open
5 tasks

Changes needed to localeData.json #26

zepumph opened this issue Feb 18, 2025 · 7 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Feb 18, 2025

From phetsims/chipper#1332 (comment), @solaolateju and I have found some changes we want to make in the localeData for all sims.

  • rh roh Romansh: It should be rm(right) and not rh (wrong).
  • nk nor Norwegian: similarly, it should be no (right) and not nk (wrong).
  • We also noticed that ar_EG should add a locale3 called arz. That is in the IANA list. I'm not sure about the process for this. It may require a rebuilt of all sims to support it as a query parameter.
  • Add a new locale: pr
  • Add BCP47 values, from spreadsheet updates in Adjust HTML language attribute chipper#1332

I will coordinate with @jonathanolson to make this happen.

@zepumph
Copy link
Member Author

zepumph commented Feb 18, 2025

From @solaolateju in phetsims/chipper#1332 (comment)

You are right. There are no sim translations for both affected locales.

Image Image

@zepumph
Copy link
Member Author

zepumph commented Feb 18, 2025

This is our first batch of changes to localeData.json since the initial MR over in phetsims/joist#963.

@jonathanolson mentioned the following steps:

  • Coordinate with @mattpen because the website uses this file too
  • Do a translation deploy so we don't increment the MR.
  • Test these changes quickly after deploy to make sure the new localeData.json is behaving correctly (because it will be live immediately).
  • Double check with @solaolateju to see if there are any other changes to add.
  • Add validation based on IANA list.

@zepumph
Copy link
Member Author

zepumph commented Mar 18, 2025

IANA list for "validation". @jonathanolson and I discussed perhaps checking this into babel: https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry

@zepumph zepumph assigned jonathanolson and unassigned zepumph Mar 18, 2025
jonathanolson added a commit that referenced this issue Mar 19, 2025
@jonathanolson
Copy link
Contributor

@mattpen when you're back, I'll want to coordinate with you on whether this would potentially break anything. Patch to update localeData is in the commit above (on the bcp47 branch in babel).

@mattpen
Copy link

mattpen commented Apr 4, 2025

EDIT: comment deleted, looks like this was already discussed.

@mattpen
Copy link

mattpen commented Apr 4, 2025

I imported the changes into the website, it actually looks like an improvement as Java is now recognizing the new locales and providing localized names. @jonathanolson - we have a production deployment planned next week, I think after that happens this can proceed.

@jonathanolson
Copy link
Contributor

Sounds good! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants